From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.81]) by mx.groups.io with SMTP id smtpd.web12.1888.1573635446281284475 for ; Wed, 13 Nov 2019 00:57:26 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=gJHLJ79i; spf=pass (domain: redhat.com, ip: 207.211.31.81, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1573635445; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kWQrCZGpoR9GpAju4mJUh09Liwk7SPKoxeZsGDVwR70=; b=gJHLJ79iO1YnIrX2nbbP76ufdf89HXUN1JUpAv2xvpthxNaK1Ozku6xd+cZyayNHuYMazk lfjofT4X+tRRzAmv7R3IfngnXS19hivIU7rQdQ/rRMO5LyNfJCXTxLoqVnnZnBP9vxr9fq pkajt3+ZYvwxlp8z19vaETcJJ3a8AHE= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-239-zkEHfEAhM8u73ZgY2QQIsA-1; Wed, 13 Nov 2019 03:57:22 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E1B1EDBBC; Wed, 13 Nov 2019 08:57:20 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-243.ams2.redhat.com [10.36.116.243]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7DE5A1D0; Wed, 13 Nov 2019 08:57:19 +0000 (UTC) Subject: Re: [edk2-devel] EDK II Maintainers - EDK II CI is now active on edk2/master To: devel@edk2.groups.io, michael.d.kinney@intel.com, Sean Brogan , Bret Barkelew , "Gao, Liming" , Ray Ni References: From: "Laszlo Ersek" Message-ID: Date: Wed, 13 Nov 2019 09:57:18 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-MC-Unique: zkEHfEAhM8u73ZgY2QQIsA-1 X-Mimecast-Spam-Score: 0 Content-Language: en-US Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable Hi again, (+Ray) On 11/12/19 03:55, Michael D Kinney wrote: > EDK II Maintainers, >=20 > EDK II CI Phase 1 feature is now active on edk2/master. >=20 > Please use a GitHub pull request from a branch in a personal > fork of the edk2 repository with a 'push' label to request > a set of patches to be pushed to edk2/master. The GitHub PR > replaces the 'git push' operation currently used to commit > changes to edk2/master. >=20 > You will need to configure your notifications from the edk2 > repository to make sure you receive email notifications > when the checks against the GitHub PR passes or fails. >=20 > If you submit a GitHub Pull Request without the 'push' > label, then the CI checks are run and the results are > generated. >=20 > Please let us know if there are any questions about this > change in the development process. now that a few PRs have been merged "in production", using the above procedure, I'd like to propose an addition. I've received a number of PR notifications, and I generally have no idea how to associate them with what happens on the list. My proposal is supposed to improve on that. Note that, I have always suggested / requested including links, pointing into the mailing list archive, in Bugzilla tickets for which new versions of patch sets have been posted. This (brief) proposal is a natural continuation / extension of that idea. - When opening a GitHub PR, as described in the above procedure, please *always* include a reference in the PR's title to the associated TianoCore bugzilla ticket, if there is one. - Similarly, please add a link, pointing to the GitHub PR, to the bugzilla ticket. For example, if I look at the following email: [tianocore/edk2] Cpu/remove xd (#164) it tells me basically *nothing*. And if I open https://github.com/tianocore/edk2/pull/164 in my web browser, it still tells me nothing. The PR title should include a reference to TianoCore#2329, and TianoCore#2329 should include a reference to . Yes, this is more work than before. It is necessary because now we have *more artifacts* related to pushing (merging) a patch series. Those artifacts should not just hang in the air. Ray: now that the series has been merged, can you please reference the GitHub PR, and the resultant commit range, in TianoCore#2329? Also, can you please close the bugzilla as fixed? Thanks, Laszlo