From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 34BA2AC10D5 for ; Wed, 24 Jan 2024 14:57:11 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=GJzHhiJt3cf+mb+uc8EFBK7a7kKkhtDQYKOlYiQO+SE=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:Reply-To:References:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1706108229; v=1; b=AGNObrJkTQIxf1Jqmu2GlHGVpEOvrwMVqJXzOv1pYOcJUGiZ1MufErNoHVFjWe307S+/89wP t4Md0InkY37p+o0PwpxtCb7IWQI76ukZNuHDITSpvffMMLtDV/KPH9Tvayv5W5ORK4dg/Tz3Ycq f9lwp1eRClMUL9CojQq56lEM= X-Received: by 127.0.0.2 with SMTP id JKf9YY7687511xExFGRLGqSf; Wed, 24 Jan 2024 06:57:09 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web11.24610.1706108229239029094 for ; Wed, 24 Jan 2024 06:57:09 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-673-rFvfU5RNPvSFqKBWyOtFRg-1; Wed, 24 Jan 2024 09:57:07 -0500 X-MC-Unique: rFvfU5RNPvSFqKBWyOtFRg-1 X-Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E3669101A526; Wed, 24 Jan 2024 14:57:06 +0000 (UTC) X-Received: from [10.39.195.127] (unknown [10.39.195.127]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3FDE83C2E; Wed, 24 Jan 2024 14:57:06 +0000 (UTC) Message-ID: Date: Wed, 24 Jan 2024 15:57:05 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] pixiefail From: "Laszlo Ersek" To: devel@edk2.groups.io, dougflick@microsoft.com, Gerd Hoffmann Cc: Jon Maloy Reply-To: devel@edk2.groups.io,lersek@redhat.com References: In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 0jhlWJ3xr8CXz6Djf5rn9ARsx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=AGNObrJk; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 1/24/24 15:35, Laszlo Ersek wrote: > I figure the most flexible approach for those that dislike email-based > review for embargoed patches would be if github.com supported locked > down *PRs* (i.e., not private organizatons). In other words, if those > PRs would be submitted against the same base repository and master > branch as every other PR, *but* they wouldn't be visible to anyone > except to a restricted group, and could never be merged. (For merging, > the approved version of the series would have to be posted publicly, > after the embargo.) >=20 > ... Technically, the last paragraph could be implemented with current > github.com features: create a locked-down organization, fork edk2 under > that organization (without adding any non-upstream changes to the fork), > and submit the embargoed patch series as a PR against the fork. Never > merge the patch set into the fork (only use the fork for patch review). Well, running the usual CI checks on the embargoed patch set, *inside the fork*, would be an extra problem... I don't know how github.com accounts for CI minutes in forks. Especially closed forks. Laszlo -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114307): https://edk2.groups.io/g/devel/message/114307 Mute This Topic: https://groups.io/mt/103913088/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-