From: "Michael Brown" <mcb30@ipxe.org>
To: devel@edk2.groups.io, lersek@redhat.com, maciej.rabeda@linux.intel.com
Cc: Jiaxin Wu <jiaxin.wu@intel.com>, Siyuan Fu <siyuan.fu@intel.com>,
Seven.ding@lcfuturecenter.com
Subject: Re: [edk2-devel] [PATCH v1] NetworkPkg/UefiPxeBcDxe: Fix PXE_BOOT_SERVERS usage in boot info parse flow
Date: Wed, 19 Aug 2020 19:46:34 +0100 [thread overview]
Message-ID: <ebe7edd2-87ab-2301-02a7-a29df3b05422@ipxe.org> (raw)
In-Reply-To: <2dde2087-e291-0232-62e2-a30cdf4e09b2@redhat.com>
On 19/08/2020 19:13, Laszlo Ersek wrote:
> I'm still undecided whether option#43 / tag#6 / bit#3 being clear means
> we should *ignore* PXE_BOOT_SERVERS (tag#8), but I'm willing to defer to
> you on that. So, I can give a cautious
>
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
>
> for this patch.
FWIW, iPXE's equivalent logic (based on a combination of what the PXE
spec says and what the Intel reference PXE implementation actually does,
which is not necessarily the same thing) is to *ignore* PXE_BOOT_SERVERS
if a DHCP filename is available and option 43 tag 6 bit 3 is *set*.
Michael
next prev parent reply other threads:[~2020-08-19 18:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-19 16:53 [PATCH v1] NetworkPkg/UefiPxeBcDxe: Fix PXE_BOOT_SERVERS usage in boot info parse flow Maciej Rabeda
2020-08-19 18:13 ` [edk2-devel] " Laszlo Ersek
2020-08-19 18:46 ` Michael Brown [this message]
2020-08-21 11:19 ` Laszlo Ersek
2020-08-23 16:24 ` Michael Brown
2020-08-19 19:20 ` Laszlo Ersek
2020-08-20 10:44 ` Maciej Rabeda
2020-08-20 13:41 ` Michael Brown
2020-08-21 9:11 ` Laszlo Ersek
2020-08-21 10:57 ` 回复: " Ding, Seven
2020-08-21 11:15 ` Maciej Rabeda
2020-08-20 3:35 ` Siyuan, Fu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ebe7edd2-87ab-2301-02a7-a29df3b05422@ipxe.org \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox