From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from blyat.fensystems.co.uk (blyat.fensystems.co.uk [54.246.183.96]) by mx.groups.io with SMTP id smtpd.web12.94419.1597862798830148592 for ; Wed, 19 Aug 2020 11:46:40 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: ipxe.org, ip: 54.246.183.96, mailfrom: mcb30@ipxe.org) Received: from dolphin.home (unknown [IPv6:2a00:23c6:5495:5e00:beee:7bff:fe8d:f03d]) by blyat.fensystems.co.uk (Postfix) with ESMTPSA id 4445142B6B; Wed, 19 Aug 2020 18:46:35 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v1] NetworkPkg/UefiPxeBcDxe: Fix PXE_BOOT_SERVERS usage in boot info parse flow To: devel@edk2.groups.io, lersek@redhat.com, maciej.rabeda@linux.intel.com Cc: Jiaxin Wu , Siyuan Fu , Seven.ding@lcfuturecenter.com References: <20200819165338.681-1-maciej.rabeda@linux.intel.com> <2dde2087-e291-0232-62e2-a30cdf4e09b2@redhat.com> From: "Michael Brown" Message-ID: Date: Wed, 19 Aug 2020 19:46:34 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <2dde2087-e291-0232-62e2-a30cdf4e09b2@redhat.com> X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on blyat.fensystems.co.uk Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 19/08/2020 19:13, Laszlo Ersek wrote: > I'm still undecided whether option#43 / tag#6 / bit#3 being clear means > we should *ignore* PXE_BOOT_SERVERS (tag#8), but I'm willing to defer to > you on that. So, I can give a cautious > > Reviewed-by: Laszlo Ersek > > for this patch. FWIW, iPXE's equivalent logic (based on a combination of what the PXE spec says and what the Intel reference PXE implementation actually does, which is not necessarily the same thing) is to *ignore* PXE_BOOT_SERVERS if a DHCP filename is available and option 43 tag 6 bit 3 is *set*. Michael