* [edk2-devel][edk2-platforms][PATCH V2 0/3] These commits fix some small build issues from various changes.
@ 2022-09-11 1:52 Isaac Oram
2022-09-11 1:52 ` [edk2-devel][edk2-platforms][PATCH V2 1/3] MinPlatformPkg/Include: Add PEI DevicePathLib instance Isaac Oram
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Isaac Oram @ 2022-09-11 1:52 UTC (permalink / raw)
To: devel; +Cc: Isaac Oram, Chasel Chiu, Nate DeSimone, Liming Gao, Eric Dong
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Eric Dong <eric.dong@intel.com>
Signed-off-by: Isaac Oram <isaac.w.oram@intel.com>
Isaac Oram (3):
MinPlatformPkg/Include: Add PEI DevicePathLib instance
PlatformPayloadFeaturePkg/Build: Use MinPlatform PCD include
Platform/Intel: Fix missing package issue
.../PlatformPayloadFeaturePkg.dsc | 13 +++++--------
.../Features/Tbt/TbtInit/Smm/TbtSmm.inf | 2 +-
.../Features/Tbt/TbtInit/Smm/TbtSmm.inf | 1 +
.../BasePlatformHookLib/BasePlatformHookLib.inf | 1 +
.../BasePlatformHookLib/BasePlatformHookLib.inf | 1 +
.../Intel/MinPlatformPkg/Include/Dsc/CorePeiLib.dsc | 1 +
.../Features/Tbt/TbtInit/Smm/TbtSmm.inf | 2 +-
7 files changed, 11 insertions(+), 10 deletions(-)
--
2.36.1.windows.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* [edk2-devel][edk2-platforms][PATCH V2 1/3] MinPlatformPkg/Include: Add PEI DevicePathLib instance
2022-09-11 1:52 [edk2-devel][edk2-platforms][PATCH V2 0/3] These commits fix some small build issues from various changes Isaac Oram
@ 2022-09-11 1:52 ` Isaac Oram
2022-09-12 22:41 ` [edk2-devel] [edk2-platforms][PATCH " Chaganty, Rangasai V
2022-09-11 1:52 ` [edk2-devel][edk2-platforms][PATCH V2 2/3] PlatformPayloadFeaturePkg/Build: Use MinPlatform PCD include Isaac Oram
2022-09-11 1:52 ` [edk2-devel][edk2-platforms][PATCH V2 3/3] Platform/Intel: Fix missing package issue Isaac Oram
2 siblings, 1 reply; 7+ messages in thread
From: Isaac Oram @ 2022-09-11 1:52 UTC (permalink / raw)
To: devel; +Cc: Isaac Oram, Chasel Chiu, Nate DeSimone, Liming Gao, Eric Dong
PEI DevicePathLib instance required by NvmExpressPei.inf
due to recent change.
Cc: Chasel Chiu <chasel.chiu@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Eric Dong <eric.dong@intel.com>
Signed-off-by: Isaac Oram <isaac.w.oram@intel.com>
---
Platform/Intel/MinPlatformPkg/Include/Dsc/CorePeiLib.dsc | 1 +
1 file changed, 1 insertion(+)
diff --git a/Platform/Intel/MinPlatformPkg/Include/Dsc/CorePeiLib.dsc b/Platform/Intel/MinPlatformPkg/Include/Dsc/CorePeiLib.dsc
index 9bac751eaf..4424ebaecc 100644
--- a/Platform/Intel/MinPlatformPkg/Include/Dsc/CorePeiLib.dsc
+++ b/Platform/Intel/MinPlatformPkg/Include/Dsc/CorePeiLib.dsc
@@ -27,6 +27,7 @@
MemoryAllocationLib|MdePkg/Library/PeiMemoryAllocationLib/PeiMemoryAllocationLib.inf
ReportStatusCodeLib|MdeModulePkg/Library/PeiReportStatusCodeLib/PeiReportStatusCodeLib.inf
ExtractGuidedSectionLib|MdePkg/Library/PeiExtractGuidedSectionLib/PeiExtractGuidedSectionLib.inf
+ DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLibBase.inf
LockBoxLib|MdeModulePkg/Library/SmmLockBoxLib/SmmLockBoxPeiLib.inf
CpuExceptionHandlerLib|UefiCpuPkg/Library/CpuExceptionHandlerLib/SecPeiCpuExceptionHandlerLib.inf
--
2.36.1.windows.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [edk2-devel][edk2-platforms][PATCH V2 2/3] PlatformPayloadFeaturePkg/Build: Use MinPlatform PCD include
2022-09-11 1:52 [edk2-devel][edk2-platforms][PATCH V2 0/3] These commits fix some small build issues from various changes Isaac Oram
2022-09-11 1:52 ` [edk2-devel][edk2-platforms][PATCH V2 1/3] MinPlatformPkg/Include: Add PEI DevicePathLib instance Isaac Oram
@ 2022-09-11 1:52 ` Isaac Oram
2022-09-11 7:13 ` Chaganty, Rangasai V
2022-09-11 1:52 ` [edk2-devel][edk2-platforms][PATCH V2 3/3] Platform/Intel: Fix missing package issue Isaac Oram
2 siblings, 1 reply; 7+ messages in thread
From: Isaac Oram @ 2022-09-11 1:52 UTC (permalink / raw)
To: devel; +Cc: Isaac Oram, Sai Chaganty, Nate DeSimone
Fix build issue from removed PCD and use MinPlatformFeaturesPcd.dsc.inc.
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Signed-off-by: Isaac Oram <isaac.w.oram@intel.com>
---
.../PlatformPayloadFeaturePkg.dsc | 13 +++++--------
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/Features/Intel/PlatformPayloadFeaturePkg/PlatformPayloadFeaturePkg.dsc b/Features/Intel/PlatformPayloadFeaturePkg/PlatformPayloadFeaturePkg.dsc
index 1b79e0039b..e36e5d6e1e 100644
--- a/Features/Intel/PlatformPayloadFeaturePkg/PlatformPayloadFeaturePkg.dsc
+++ b/Features/Intel/PlatformPayloadFeaturePkg/PlatformPayloadFeaturePkg.dsc
@@ -48,16 +48,13 @@
#
################################################################################
-#
-# Since there are no 32b libraries or components in this package, these PCD are specified for 64b only
-#
-[PcdsFeatureFlag]
#
- # PCD needed for MinPlatform build includes
+ # MinPlatform common include for required feature PCD
+ # These PCD must be set before the core include files, CoreCommonLib,
+ # CorePeiLib, and CoreDxeLib.
+ # Optional MinPlatformPkg features should be enabled after this
#
- gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable |FALSE
- gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable |FALSE
- gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable |FALSE
+ !include MinPlatformPkg/Include/Dsc/MinPlatformFeaturesPcd.dsc.inc
[PcdsPatchableInModule]
gEfiMdePkgTokenSpaceGuid.PcdReportStatusCodePropertyMask|0x7
--
2.36.1.windows.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* [edk2-devel][edk2-platforms][PATCH V2 3/3] Platform/Intel: Fix missing package issue
2022-09-11 1:52 [edk2-devel][edk2-platforms][PATCH V2 0/3] These commits fix some small build issues from various changes Isaac Oram
2022-09-11 1:52 ` [edk2-devel][edk2-platforms][PATCH V2 1/3] MinPlatformPkg/Include: Add PEI DevicePathLib instance Isaac Oram
2022-09-11 1:52 ` [edk2-devel][edk2-platforms][PATCH V2 2/3] PlatformPayloadFeaturePkg/Build: Use MinPlatform PCD include Isaac Oram
@ 2022-09-11 1:52 ` Isaac Oram
2022-09-11 7:10 ` Chaganty, Rangasai V
2 siblings, 1 reply; 7+ messages in thread
From: Isaac Oram @ 2022-09-11 1:52 UTC (permalink / raw)
To: devel; +Cc: Isaac Oram, Sai Chaganty, Nate DeSimone
Update all consumers of PcdAcpiBaseAddress to include
IntelSiliconPkg/IntelSiliconPkg.dec.
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Signed-off-by: Isaac Oram <isaac.w.oram@intel.com>
---
.../CometlakeOpenBoardPkg/Features/Tbt/TbtInit/Smm/TbtSmm.inf | 2 +-
.../KabylakeOpenBoardPkg/Features/Tbt/TbtInit/Smm/TbtSmm.inf | 1 +
.../Library/BasePlatformHookLib/BasePlatformHookLib.inf | 1 +
.../Library/BasePlatformHookLib/BasePlatformHookLib.inf | 1 +
.../WhiskeylakeOpenBoardPkg/Features/Tbt/TbtInit/Smm/TbtSmm.inf | 2 +-
5 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/Platform/Intel/CometlakeOpenBoardPkg/Features/Tbt/TbtInit/Smm/TbtSmm.inf b/Platform/Intel/CometlakeOpenBoardPkg/Features/Tbt/TbtInit/Smm/TbtSmm.inf
index c4dd863c3e..9f6d43172f 100644
--- a/Platform/Intel/CometlakeOpenBoardPkg/Features/Tbt/TbtInit/Smm/TbtSmm.inf
+++ b/Platform/Intel/CometlakeOpenBoardPkg/Features/Tbt/TbtInit/Smm/TbtSmm.inf
@@ -41,6 +41,7 @@
MdePkg/MdePkg.dec
MdeModulePkg/MdeModulePkg.dec
MinPlatformPkg/MinPlatformPkg.dec
+ IntelSiliconPkg/IntelSiliconPkg.dec
CometlakeOpenBoardPkg/OpenBoardPkg.dec
CoffeelakeSiliconPkg/SiPkg.dec
@@ -77,4 +78,3 @@
gEfiVariableWriteArchProtocolGuid AND
gEfiVariableArchProtocolGuid AND
gEfiSmmVariableProtocolGuid
-
diff --git a/Platform/Intel/KabylakeOpenBoardPkg/Features/Tbt/TbtInit/Smm/TbtSmm.inf b/Platform/Intel/KabylakeOpenBoardPkg/Features/Tbt/TbtInit/Smm/TbtSmm.inf
index 13116488ea..8d932ed094 100644
--- a/Platform/Intel/KabylakeOpenBoardPkg/Features/Tbt/TbtInit/Smm/TbtSmm.inf
+++ b/Platform/Intel/KabylakeOpenBoardPkg/Features/Tbt/TbtInit/Smm/TbtSmm.inf
@@ -39,6 +39,7 @@
MdePkg/MdePkg.dec
MdeModulePkg/MdeModulePkg.dec
MinPlatformPkg/MinPlatformPkg.dec
+ IntelSiliconPkg/IntelSiliconPkg.dec
KabylakeOpenBoardPkg/OpenBoardPkg.dec
KabylakeSiliconPkg/SiPkg.dec
diff --git a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BasePlatformHookLib/BasePlatformHookLib.inf b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BasePlatformHookLib/BasePlatformHookLib.inf
index 5f65f02a9f..e30ca0c438 100644
--- a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BasePlatformHookLib/BasePlatformHookLib.inf
+++ b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BasePlatformHookLib/BasePlatformHookLib.inf
@@ -31,6 +31,7 @@
MdePkg/MdePkg.dec
MdeModulePkg/MdeModulePkg.dec
MinPlatformPkg/MinPlatformPkg.dec
+ IntelSiliconPkg/IntelSiliconPkg.dec
KabylakeOpenBoardPkg/OpenBoardPkg.dec
KabylakeSiliconPkg/SiPkg.dec
diff --git a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BasePlatformHookLib/BasePlatformHookLib.inf b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BasePlatformHookLib/BasePlatformHookLib.inf
index 8bdf13b1ce..ba73140a6b 100644
--- a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BasePlatformHookLib/BasePlatformHookLib.inf
+++ b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BasePlatformHookLib/BasePlatformHookLib.inf
@@ -31,6 +31,7 @@
MdePkg/MdePkg.dec
MdeModulePkg/MdeModulePkg.dec
MinPlatformPkg/MinPlatformPkg.dec
+ IntelSiliconPkg/IntelSiliconPkg.dec
KabylakeOpenBoardPkg/OpenBoardPkg.dec
KabylakeSiliconPkg/SiPkg.dec
diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/Features/Tbt/TbtInit/Smm/TbtSmm.inf b/Platform/Intel/WhiskeylakeOpenBoardPkg/Features/Tbt/TbtInit/Smm/TbtSmm.inf
index 83ebc790ae..c3ba13c037 100644
--- a/Platform/Intel/WhiskeylakeOpenBoardPkg/Features/Tbt/TbtInit/Smm/TbtSmm.inf
+++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/Features/Tbt/TbtInit/Smm/TbtSmm.inf
@@ -41,6 +41,7 @@
MdePkg/MdePkg.dec
MdeModulePkg/MdeModulePkg.dec
MinPlatformPkg/MinPlatformPkg.dec
+ IntelSiliconPkg/IntelSiliconPkg.dec
WhiskeylakeOpenBoardPkg/OpenBoardPkg.dec
CoffeelakeSiliconPkg/SiPkg.dec
@@ -77,4 +78,3 @@
gEfiVariableWriteArchProtocolGuid AND
gEfiVariableArchProtocolGuid AND
gEfiSmmVariableProtocolGuid
-
--
2.36.1.windows.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [edk2-devel][edk2-platforms][PATCH V2 3/3] Platform/Intel: Fix missing package issue
2022-09-11 1:52 ` [edk2-devel][edk2-platforms][PATCH V2 3/3] Platform/Intel: Fix missing package issue Isaac Oram
@ 2022-09-11 7:10 ` Chaganty, Rangasai V
0 siblings, 0 replies; 7+ messages in thread
From: Chaganty, Rangasai V @ 2022-09-11 7:10 UTC (permalink / raw)
To: Oram, Isaac W, devel@edk2.groups.io; +Cc: Desimone, Nathaniel L
Reviewed-by: Sai Chaganty <rangasai.v.chaganty@intel.com>
-----Original Message-----
From: Oram, Isaac W <isaac.w.oram@intel.com>
Sent: Saturday, September 10, 2022 6:52 PM
To: devel@edk2.groups.io
Cc: Oram, Isaac W <isaac.w.oram@intel.com>; Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>
Subject: [edk2-devel][edk2-platforms][PATCH V2 3/3] Platform/Intel: Fix missing package issue
Update all consumers of PcdAcpiBaseAddress to include IntelSiliconPkg/IntelSiliconPkg.dec.
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Signed-off-by: Isaac Oram <isaac.w.oram@intel.com>
---
.../CometlakeOpenBoardPkg/Features/Tbt/TbtInit/Smm/TbtSmm.inf | 2 +-
.../KabylakeOpenBoardPkg/Features/Tbt/TbtInit/Smm/TbtSmm.inf | 1 +
.../Library/BasePlatformHookLib/BasePlatformHookLib.inf | 1 +
.../Library/BasePlatformHookLib/BasePlatformHookLib.inf | 1 +
.../WhiskeylakeOpenBoardPkg/Features/Tbt/TbtInit/Smm/TbtSmm.inf | 2 +-
5 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/Platform/Intel/CometlakeOpenBoardPkg/Features/Tbt/TbtInit/Smm/TbtSmm.inf b/Platform/Intel/CometlakeOpenBoardPkg/Features/Tbt/TbtInit/Smm/TbtSmm.inf
index c4dd863c3e..9f6d43172f 100644
--- a/Platform/Intel/CometlakeOpenBoardPkg/Features/Tbt/TbtInit/Smm/TbtSmm.inf
+++ b/Platform/Intel/CometlakeOpenBoardPkg/Features/Tbt/TbtInit/Smm/TbtS
+++ mm.inf
@@ -41,6 +41,7 @@
MdePkg/MdePkg.dec
MdeModulePkg/MdeModulePkg.dec
MinPlatformPkg/MinPlatformPkg.dec
+ IntelSiliconPkg/IntelSiliconPkg.dec
CometlakeOpenBoardPkg/OpenBoardPkg.dec
CoffeelakeSiliconPkg/SiPkg.dec
@@ -77,4 +78,3 @@
gEfiVariableWriteArchProtocolGuid AND
gEfiVariableArchProtocolGuid AND
gEfiSmmVariableProtocolGuid
-
diff --git a/Platform/Intel/KabylakeOpenBoardPkg/Features/Tbt/TbtInit/Smm/TbtSmm.inf b/Platform/Intel/KabylakeOpenBoardPkg/Features/Tbt/TbtInit/Smm/TbtSmm.inf
index 13116488ea..8d932ed094 100644
--- a/Platform/Intel/KabylakeOpenBoardPkg/Features/Tbt/TbtInit/Smm/TbtSmm.inf
+++ b/Platform/Intel/KabylakeOpenBoardPkg/Features/Tbt/TbtInit/Smm/TbtSm
+++ m.inf
@@ -39,6 +39,7 @@
MdePkg/MdePkg.dec
MdeModulePkg/MdeModulePkg.dec
MinPlatformPkg/MinPlatformPkg.dec
+ IntelSiliconPkg/IntelSiliconPkg.dec
KabylakeOpenBoardPkg/OpenBoardPkg.dec
KabylakeSiliconPkg/SiPkg.dec
diff --git a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BasePlatformHookLib/BasePlatformHookLib.inf b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BasePlatformHookLib/BasePlatformHookLib.inf
index 5f65f02a9f..e30ca0c438 100644
--- a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BasePlatformHookLib/BasePlatformHookLib.inf
+++ b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/Library/BasePlatfor
+++ mHookLib/BasePlatformHookLib.inf
@@ -31,6 +31,7 @@
MdePkg/MdePkg.dec
MdeModulePkg/MdeModulePkg.dec
MinPlatformPkg/MinPlatformPkg.dec
+ IntelSiliconPkg/IntelSiliconPkg.dec
KabylakeOpenBoardPkg/OpenBoardPkg.dec
KabylakeSiliconPkg/SiPkg.dec
diff --git a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BasePlatformHookLib/BasePlatformHookLib.inf b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BasePlatformHookLib/BasePlatformHookLib.inf
index 8bdf13b1ce..ba73140a6b 100644
--- a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BasePlatformHookLib/BasePlatformHookLib.inf
+++ b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Library/BasePlatf
+++ ormHookLib/BasePlatformHookLib.inf
@@ -31,6 +31,7 @@
MdePkg/MdePkg.dec
MdeModulePkg/MdeModulePkg.dec
MinPlatformPkg/MinPlatformPkg.dec
+ IntelSiliconPkg/IntelSiliconPkg.dec
KabylakeOpenBoardPkg/OpenBoardPkg.dec
KabylakeSiliconPkg/SiPkg.dec
diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/Features/Tbt/TbtInit/Smm/TbtSmm.inf b/Platform/Intel/WhiskeylakeOpenBoardPkg/Features/Tbt/TbtInit/Smm/TbtSmm.inf
index 83ebc790ae..c3ba13c037 100644
--- a/Platform/Intel/WhiskeylakeOpenBoardPkg/Features/Tbt/TbtInit/Smm/TbtSmm.inf
+++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/Features/Tbt/TbtInit/Smm/Tb
+++ tSmm.inf
@@ -41,6 +41,7 @@
MdePkg/MdePkg.dec
MdeModulePkg/MdeModulePkg.dec
MinPlatformPkg/MinPlatformPkg.dec
+ IntelSiliconPkg/IntelSiliconPkg.dec
WhiskeylakeOpenBoardPkg/OpenBoardPkg.dec
CoffeelakeSiliconPkg/SiPkg.dec
@@ -77,4 +78,3 @@
gEfiVariableWriteArchProtocolGuid AND
gEfiVariableArchProtocolGuid AND
gEfiSmmVariableProtocolGuid
-
--
2.36.1.windows.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [edk2-devel][edk2-platforms][PATCH V2 2/3] PlatformPayloadFeaturePkg/Build: Use MinPlatform PCD include
2022-09-11 1:52 ` [edk2-devel][edk2-platforms][PATCH V2 2/3] PlatformPayloadFeaturePkg/Build: Use MinPlatform PCD include Isaac Oram
@ 2022-09-11 7:13 ` Chaganty, Rangasai V
0 siblings, 0 replies; 7+ messages in thread
From: Chaganty, Rangasai V @ 2022-09-11 7:13 UTC (permalink / raw)
To: Oram, Isaac W, devel@edk2.groups.io; +Cc: Desimone, Nathaniel L
Reviewed-by: Sai Chaganty <rangasai.v.chaganty@intel.com>
-----Original Message-----
From: Oram, Isaac W <isaac.w.oram@intel.com>
Sent: Saturday, September 10, 2022 6:52 PM
To: devel@edk2.groups.io
Cc: Oram, Isaac W <isaac.w.oram@intel.com>; Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>; Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>
Subject: [edk2-devel][edk2-platforms][PATCH V2 2/3] PlatformPayloadFeaturePkg/Build: Use MinPlatform PCD include
Fix build issue from removed PCD and use MinPlatformFeaturesPcd.dsc.inc.
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
Signed-off-by: Isaac Oram <isaac.w.oram@intel.com>
---
.../PlatformPayloadFeaturePkg.dsc | 13 +++++--------
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/Features/Intel/PlatformPayloadFeaturePkg/PlatformPayloadFeaturePkg.dsc b/Features/Intel/PlatformPayloadFeaturePkg/PlatformPayloadFeaturePkg.dsc
index 1b79e0039b..e36e5d6e1e 100644
--- a/Features/Intel/PlatformPayloadFeaturePkg/PlatformPayloadFeaturePkg.dsc
+++ b/Features/Intel/PlatformPayloadFeaturePkg/PlatformPayloadFeaturePkg
+++ .dsc
@@ -48,16 +48,13 @@
#
################################################################################
-#
-# Since there are no 32b libraries or components in this package, these PCD are specified for 64b only -# -[PcdsFeatureFlag]
#
- # PCD needed for MinPlatform build includes
+ # MinPlatform common include for required feature PCD # These PCD
+ must be set before the core include files, CoreCommonLib, #
+ CorePeiLib, and CoreDxeLib.
+ # Optional MinPlatformPkg features should be enabled after this
#
- gMinPlatformPkgTokenSpaceGuid.PcdSmiHandlerProfileEnable |FALSE
- gMinPlatformPkgTokenSpaceGuid.PcdUefiSecureBootEnable |FALSE
- gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable |FALSE
+ !include MinPlatformPkg/Include/Dsc/MinPlatformFeaturesPcd.dsc.inc
[PcdsPatchableInModule]
gEfiMdePkgTokenSpaceGuid.PcdReportStatusCodePropertyMask|0x7
--
2.36.1.windows.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [edk2-platforms][PATCH V2 1/3] MinPlatformPkg/Include: Add PEI DevicePathLib instance
2022-09-11 1:52 ` [edk2-devel][edk2-platforms][PATCH V2 1/3] MinPlatformPkg/Include: Add PEI DevicePathLib instance Isaac Oram
@ 2022-09-12 22:41 ` Chaganty, Rangasai V
0 siblings, 0 replies; 7+ messages in thread
From: Chaganty, Rangasai V @ 2022-09-12 22:41 UTC (permalink / raw)
To: Isaac Oram, devel
[-- Attachment #1: Type: text/plain, Size: 61 bytes --]
Reviewed-by: Sai Chaganty < rangasai.v.chaganty@intel.com >
[-- Attachment #2: Type: text/html, Size: 144 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-09-12 22:41 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-11 1:52 [edk2-devel][edk2-platforms][PATCH V2 0/3] These commits fix some small build issues from various changes Isaac Oram
2022-09-11 1:52 ` [edk2-devel][edk2-platforms][PATCH V2 1/3] MinPlatformPkg/Include: Add PEI DevicePathLib instance Isaac Oram
2022-09-12 22:41 ` [edk2-devel] [edk2-platforms][PATCH " Chaganty, Rangasai V
2022-09-11 1:52 ` [edk2-devel][edk2-platforms][PATCH V2 2/3] PlatformPayloadFeaturePkg/Build: Use MinPlatform PCD include Isaac Oram
2022-09-11 7:13 ` Chaganty, Rangasai V
2022-09-11 1:52 ` [edk2-devel][edk2-platforms][PATCH V2 3/3] Platform/Intel: Fix missing package issue Isaac Oram
2022-09-11 7:10 ` Chaganty, Rangasai V
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox