From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.11899.1639668389054896459 for ; Thu, 16 Dec 2021 07:26:29 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: pierre.gondois@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B57C71435; Thu, 16 Dec 2021 07:26:28 -0800 (PST) Received: from [10.34.125.45] (e126645.nice.arm.com [10.34.125.45]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0F9073F73B; Thu, 16 Dec 2021 07:26:25 -0800 (PST) Subject: Re: [edk2-platforms PATCH 0/8] Update Arm platforms following addition of EFI_MP_SERVICES_PROTOCOL support in edk2 To: Rebecca Cran , Sami Mujawar , Ard Biesheuvel Cc: edk2-devel-groups-io , Ard Biesheuvel , Samer El-Haj-Mahmoud , Leif Lindholm , Masami Hiramatsu , Graeme Gregory , Radoslaw Biernacki , Marcin Wojtas , nd References: <20211215000324.11591-1-rebecca@nuviainc.com> <34eb1118-89a1-7d4d-3705-d9915d5ae859@nuviainc.com> <8107317F-6D08-45FD-8749-23BABC72215F@arm.com> From: "PierreGondois" Message-ID: Date: Thu, 16 Dec 2021 16:26:29 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Hi Rebecca, On 12/16/21 3:59 PM, Rebecca Cran wrote: > On 12/16/21 6:26 AM, Sami Mujawar wrote: > >> [SAMI] I posted the following patches to fix some of the issues you me= ntion above: >> Platform/Socionext: Fix build break for SynQuacerEvalBoard (https://ed= k2.groups.io/g/devel/message/83553) >> Platform/LeMaker: Fix build break for CelloBoard (https://edk2.groups.= io/g/devel/message/83556) >> Platform/Socionext/SynQuacerEvalBoard: Add missing ArmSoftFloatLib (ht= tps://edk2.groups.io/g/devel/message/83554) >> Platform/Socionext/SynQuacerEvalBoard: Disable EbcDxe for AArch32=C2=A0= Builds (https://edk2.groups.io/g/devel/message/83557) >> >> If it helps, I can carve out these patches in a separate series and po= st them to the list. >> >> I feel we need a CI for edk2-platforms. Without this it is going to be= hard to keep track of such build breaks. >> [/SAMI] > > > Thanks, I'll take a look at those and post any comments. > > I agree, CI for edk2-platforms would be good. I'm hoping to find some t= ime next week to work on it. A useful step, even if it's just the first o= f many, would be to simply run lots of 'build' commands for each platform= . > > The following patchset should enable a CI in edk2-platforms for the Juno = platorm, but it was tested before uncrustify was enabled. The patch-set i= s also relying on a modification in edk2-pytool-extensions: https://edk2.groups.io/g/devel/message/83803 https://github.com/tianocore/edk2-pytool-extensions/pull/279 There is a bugzilla on this topic at: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3509 Feel free to use the patches (or not) and to take the bugzilla (or not). = It didn't seem the feature was really appealing until now, Regards, Pierre