Re: [PATCH 4/4] OvmfPkg: Introduce UDF_ENABLE build flag

[Paulo Alcantara <pcacjr@zytor.com>]

Hi,

On 8/9/2017 6:44 AM, Laszlo Ersek wrote:
> CC Ard and Andrew
> 
> On 08/08/17 21:31, Paulo Alcantara wrote:
>> By defining this build flag, OVMF will support booting from UDF file
>> systems.
>>
>> Cc: Jordan Justen <jordan.l.justen@intel.com>
>> Cc: Laszlo Ersek <lersek@redhat.com>
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Paulo Alcantara <pcacjr@zytor.com>
>> ---
>>   OvmfPkg/OvmfPkgIa32.dsc    | 7 +++++++
>>   OvmfPkg/OvmfPkgIa32.fdf    | 3 +++
>>   OvmfPkg/OvmfPkgIa32X64.dsc | 7 +++++++
>>   OvmfPkg/OvmfPkgIa32X64.fdf | 3 +++
>>   OvmfPkg/OvmfPkgX64.dsc     | 7 +++++++
>>   OvmfPkg/OvmfPkgX64.fdf     | 3 +++
>>   6 files changed, 30 insertions(+)
> 
> Ray already mentioned that PcdUdfFileSystemSupport is not needed. I
> agree. Similarly, I think UDF_ENABLE is also not needed, the new driver
> should be added to the DSC and FDF files right after "Fat.inf" (like you
> are doing it now, just unconditionally).

OK - I'll send a v2 as soon as I can with its removal.

> 
> Furthermore, can you please do the same in the ArmVirtPkg DSC and FDF
> files? (Just grep the tree for "Fat.inf".) EmulatorPkg and Nt32Pkg are
> further emulation platforms that might want to include this.

Sure. That'd be great if someone could help me testing on those 
platforms. I'll try to set up an environment and then test it on them.

> Paulo, I'll check if I can test your driver with some 3rd party media
> (i.e., a DVD image that I don't prepare myself).

Thanks!

Paulo