From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.zytor.com (terminus.zytor.com [65.50.211.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0177A209589CA for ; Wed, 9 Aug 2017 06:40:26 -0700 (PDT) Received: from [10.26.0.110] (corporativo.static.gvt.net.br [177.135.97.54] (may be forged)) (authenticated bits=0) by mail.zytor.com (8.15.2/8.15.2) with ESMTPSA id v79DcGld019866 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NO); Wed, 9 Aug 2017 06:38:17 -0700 To: Laszlo Ersek Cc: edk2-devel@lists.01.org, Jordan Justen , Ard Biesheuvel , Andrew Fish References: <20170808193143.18128-1-pcacjr@zytor.com> <20170808193143.18128-5-pcacjr@zytor.com> From: Paulo Alcantara Message-ID: Date: Wed, 9 Aug 2017 10:38:12 -0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: Subject: Re: [PATCH 4/4] OvmfPkg: Introduce UDF_ENABLE build flag X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Aug 2017 13:40:27 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Hi, On 8/9/2017 6:44 AM, Laszlo Ersek wrote: > CC Ard and Andrew > > On 08/08/17 21:31, Paulo Alcantara wrote: >> By defining this build flag, OVMF will support booting from UDF file >> systems. >> >> Cc: Jordan Justen >> Cc: Laszlo Ersek >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Paulo Alcantara >> --- >> OvmfPkg/OvmfPkgIa32.dsc | 7 +++++++ >> OvmfPkg/OvmfPkgIa32.fdf | 3 +++ >> OvmfPkg/OvmfPkgIa32X64.dsc | 7 +++++++ >> OvmfPkg/OvmfPkgIa32X64.fdf | 3 +++ >> OvmfPkg/OvmfPkgX64.dsc | 7 +++++++ >> OvmfPkg/OvmfPkgX64.fdf | 3 +++ >> 6 files changed, 30 insertions(+) > > Ray already mentioned that PcdUdfFileSystemSupport is not needed. I > agree. Similarly, I think UDF_ENABLE is also not needed, the new driver > should be added to the DSC and FDF files right after "Fat.inf" (like you > are doing it now, just unconditionally). OK - I'll send a v2 as soon as I can with its removal. > > Furthermore, can you please do the same in the ArmVirtPkg DSC and FDF > files? (Just grep the tree for "Fat.inf".) EmulatorPkg and Nt32Pkg are > further emulation platforms that might want to include this. Sure. That'd be great if someone could help me testing on those platforms. I'll try to set up an environment and then test it on them. > Paulo, I'll check if I can test your driver with some 3rd party media > (i.e., a DVD image that I don't prepare myself). Thanks! Paulo