From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com [209.85.167.51]) by mx.groups.io with SMTP id smtpd.web11.321.1594833000594185221 for ; Wed, 15 Jul 2020 10:10:01 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@broadcom.com header.s=google header.b=XPmwnP/4; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: broadcom.com, ip: 209.85.167.51, mailfrom: vladimir.olovyannikov@broadcom.com) Received: by mail-lf1-f51.google.com with SMTP id t9so1467328lfl.5 for ; Wed, 15 Jul 2020 10:10:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:references:in-reply-to:mime-version:thread-index:date :message-id:subject:to:cc; bh=qSwD2LThr7mJ32UDAB4+FTT4Juuezb/GBvTsi2TCxCA=; b=XPmwnP/4CRxpu5EKtSInp6teXtgsmPuwve45whQzKDBxsz64qpIywt6fqaFufbVET9 0JO4815oMS1iEd25XNrgUlEh7tpTOqt0wnhNJYGnqHeGBXqPVq6Huzgl1RNUsCUfQuLx G2LtBK63pbAbZ2KVaRcL/l39De8ZJDoiyVHDU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:references:in-reply-to:mime-version :thread-index:date:message-id:subject:to:cc; bh=qSwD2LThr7mJ32UDAB4+FTT4Juuezb/GBvTsi2TCxCA=; b=aWRTYWp7iyhCnnR/lUQKRoFMxxwW04CmoKHNk3+qAbt2dQepnOfNL0nj0awZS1hzYS svxHrCVWrtgLgE/p/plm+gCOrFUsFVQFjJ0FzmfQ26I6WwaB9S3T6rFNp9HUf87o2iR5 BBoGECe60rUfY9+8RDjYTthewhvTXsUi/HK93+T5cNz399vRmiYgoRC1fMz2DZsfJJEX szCbYkJTXh45v28EZ0gaKCEd4S3OIhyUfhaouNhREAnRkNgqWkg5XyYayhxjmDbdd5I+ gBInj8WgNEEKQQJ7OsztPFNM1+gWKLbdPYwkdsYojW4DhlNf9n5VbHnb6YjYmMmfN2+j yGZw== X-Gm-Message-State: AOAM530qGVAwqLwXjKOYqzfPWE5oQcfeJdXTY1ki0iQG1D0pn9xeV2cC UTRD62P/iG9BJk1aRN2C7mRznb+Y3gOVK0WVvDv6y4f+7+o= X-Google-Smtp-Source: ABdhPJzrba+lPmbyaRrTeQ4wGDhPLIXQOnmWfaZufWlRfAIartPXaozOpBgNlIg2bZsVMYC3IVqfIEL69sg/XIMzR60= X-Received: by 2002:ac2:548a:: with SMTP id t10mr35108lfk.142.1594832998307; Wed, 15 Jul 2020 10:09:58 -0700 (PDT) From: "Vladimir Olovyannikov" References: <20200713183137.9825-1-vladimir.olovyannikov@broadcom.com> <17bab469-76af-0ffc-b99c-962f4eb20010@redhat.com> In-Reply-To: MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQHWOTapeOQNV4NQfAeaKbZPaHyXkQF6CKeRAhRV4gGo7K+RsA== Date: Wed, 15 Jul 2020 10:09:57 -0700 Message-ID: Subject: Re: [edk2-devel] [PATCH v3 1/1] ShellPkg/DynamicCommand: add HttpDynamicCommand To: devel@edk2.groups.io, lersek@redhat.com Cc: Samer El-Haj-Mahmoud , Zhichao Gao , Maciej Rabeda , Jiaxin Wu , Siyuan Fu , Ray Ni , Liming Gao , Nd Content-Type: text/plain; charset="UTF-8" Hi Laszlo, Thank you for supporting this. I can add required support. But shouldn't we wait until the patch is reviewed and approved first? I don't know the proper procedure. Please advise. Thank you, Vladimir > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Laszlo > Ersek > Sent: Wednesday, July 15, 2020 5:59 AM > To: devel@edk2.groups.io; vladimir.olovyannikov@broadcom.com > Cc: Samer El-Haj-Mahmoud ; Zhichao > Gao ; Maciej Rabeda > ; Jiaxin Wu ; Siyuan > Fu ; Ray Ni ; Liming Gao > ; Nd > Subject: Re: [edk2-devel] [PATCH v3 1/1] ShellPkg/DynamicCommand: add > HttpDynamicCommand > > On 07/15/20 14:55, Laszlo Ersek wrote: > > On 07/13/20 20:31, Vladimir Olovyannikov via groups.io wrote: > >> Introduce an http client utilizing EDK2 HTTP protocol, to allow fast > >> image downloading from http/https servers. > >> HTTP download speed is usually faster than tftp. > >> The client is based on the same approach as tftp dynamic command, and > >> uses the same UEFI Shell command line parameters. This makes it easy > >> integrating http into existing UEFI Shell scripts. > >> Note that to enable HTTP download, feature Pcd > >> gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections must be set > to > >> TRUE. > >> > >> Signed-off-by: Vladimir Olovyannikov > >> > >> Tested-By: Samer El-Haj-Mahmoud > >> Cc: Zhichao Gao > >> Cc: Maciej Rabeda > >> Cc: Jiaxin Wu > >> Cc: Siyuan Fu > >> Cc: Ray Ni > >> Cc: Liming Gao > >> Cc: Nd > >> --- > >> .../DynamicCommand/HttpDynamicCommand/Http.c | 1700 > +++++++++++++++++ > >> .../DynamicCommand/HttpDynamicCommand/Http.h | 84 + > >> .../HttpDynamicCommand/Http.uni | 113 ++ > >> .../HttpDynamicCommand/HttpApp.c | 53 + > >> .../HttpDynamicCommand/HttpApp.inf | 58 + > >> .../HttpDynamicCommand/HttpDynamicCommand.c | 134 ++ > >> .../HttpDynamicCommand/HttpDynamicCommand.inf | 63 + > >> ShellPkg/Include/Guid/ShellLibHiiGuid.h | 5 + > >> ShellPkg/ShellPkg.dec | 1 + > >> ShellPkg/ShellPkg.dsc | 5 + > >> 10 files changed, 2216 insertions(+) create mode 100644 > >> ShellPkg/DynamicCommand/HttpDynamicCommand/Http.c > >> create mode 100644 > ShellPkg/DynamicCommand/HttpDynamicCommand/Http.h > >> create mode 100644 > >> ShellPkg/DynamicCommand/HttpDynamicCommand/Http.uni > >> create mode 100644 > >> ShellPkg/DynamicCommand/HttpDynamicCommand/HttpApp.c > >> create mode 100644 > >> ShellPkg/DynamicCommand/HttpDynamicCommand/HttpApp.inf > >> create mode 100644 > >> > ShellPkg/DynamicCommand/HttpDynamicCommand/HttpDynamicCommand > .c > >> create mode 100644 > >> > ShellPkg/DynamicCommand/HttpDynamicCommand/HttpDynamicCommand > .inf > > > > This feature sounds very attractive for virtualization too. > > > > I suggest filing a BZ for collecting the various versions of the patch > > (or patch series) in a common spot. (Based on the size of the patch, I > > assume there could be multiple versions.) > > Sorry, I didn't look carefully enough at the subject -- I see we're > already at v3. > In that case, the BZ should please reference all three versions of the > patch > (thus far): > > * version 1: > [edk2-devel] [PATCH 1/1] ShellPkg/DynamicCommand: add > HttpDynamicCommand > https://edk2.groups.io/g/devel/message/53483 > http://mid.mail-archive.com/20200125005718.8931-1- > vladimir.olovyannikov@broadcom.com > > * version 2: > [edk2-devel] [PATCH v2 1/1] ShellPkg/DynamicCommand: add > HttpDynamicCommand > https://edk2.groups.io/g/devel/message/59160 > http://mid.mail-archive.com/20200511180310.30964-1- > vladimir.olovyannikov@broadcom.com > > * version 3 (this version): > [edk2-devel] [PATCH v3 1/1] ShellPkg/DynamicCommand: add > HttpDynamicCommand > https://edk2.groups.io/g/devel/message/62452 > http://mid.mail-archive.com/20200713183137.9825-1- > vladimir.olovyannikov@broadcom.com > > Thanks! > Laszlo > > >