From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (no SPF record) identity=mailfrom; client-ip=2a00:1450:4864:20::544; helo=mail-ed1-x544.google.com; envelope-from=pete@akeo.ie; receiver=edk2-devel@lists.01.org Received: from mail-ed1-x544.google.com (mail-ed1-x544.google.com [IPv6:2a00:1450:4864:20::544]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E4AFB21962301 for ; Fri, 7 Dec 2018 06:33:23 -0800 (PST) Received: by mail-ed1-x544.google.com with SMTP id h50so3881819ede.5 for ; Fri, 07 Dec 2018 06:33:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akeo-ie.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=sgMVrJ7rdYrliQrhzXqw0Y+GGTrb8QAaVNULHxlXqP8=; b=CUFwxvPgs4/6MiqT7L54S5beouZ1zTXxek8OZtHPeQN3qWaUIsLXee9mwJDACSAu+5 rjaaU1RJbefndGkaFoReGQdsYfhooAbMeOm0GxolCWtgf9CGZ04HrKH3QjQ+bjF0bLWX gOPzetFUXyFe+zkQzavRHhhGtyHuG2LCNVw5ij5rRicrp41+yQeKVxpWg7kJaFP4+75d OR9ju+uyyfUapeyBh+LhopjNBcX6G5uEA25fCdWIaFMNVMRrIWXm04AS/d2wRHhH0j9E UaQazTiXpl+IL0yb2TIGSEQUzxcrW1GzO+I3wbD1cZeubxw+u86r+hWMGZQ0Ddbuz2KG TZTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=sgMVrJ7rdYrliQrhzXqw0Y+GGTrb8QAaVNULHxlXqP8=; b=S9PSjA9GX/QrwF2cfaWSwuuUwUUUVFEP7AxR8sChwm1MBXKt5GnPfcf0BjypQl7gSL i4KGTyPi0anOGnIXQ9IUC28R/+FJm8WEGu97uPDLLAm/UivYvnEiHM7gfdc0jWwHXS2u /57UDdznGxLGCLYkqkR6Uxd9LNyMobn8wd/4a0Q76gwqM5rW6V/QLsStM3iFlfmYz6ps lo9z1C71thPmRf8ZtOT4SRxvSsbw5FL71lHKBh4Pv1d4uBcTjKbVduJkqw9ttg1nhuLu NTup1Hkoa2LvSoW+gTUegw1k1wI4yBbCAqqA620B+vpGTra4wKsNglB7gZrQi0rfuVVY N6wg== X-Gm-Message-State: AA+aEWZi8l/eUd/r+azVxJYau80iuFyYZ/WKVf+jDri4riDIJZDCFVT4 WgS9mqZhVmzOLY0BokzxD+AUOune5p0= X-Google-Smtp-Source: AFSGD/VS1PchnSBPIXtwio1qR0hdKDtnUeGih7Pvx7Enm92kiCy3OORZ9hl/AQzD+eFVzT6YHYdr9Q== X-Received: by 2002:a50:8d46:: with SMTP id t6mr2436991edt.269.1544193201818; Fri, 07 Dec 2018 06:33:21 -0800 (PST) Received: from [10.0.0.101] ([84.203.68.105]) by smtp.googlemail.com with ESMTPSA id s3sm1049953edm.31.2018.12.07.06.33.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 07 Dec 2018 06:33:21 -0800 (PST) To: Ard Biesheuvel Cc: "edk2-devel@lists.01.org" References: <20181207120511.8724-1-pete@akeo.ie> From: Pete Batard Message-ID: Date: Fri, 7 Dec 2018 14:33:20 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.3.2 MIME-Version: 1.0 In-Reply-To: Subject: Re: [PATCH v1 edk2-platfoms 0/2] Platform/Broadcom: Add Raspberry Pi 3 support X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 07 Dec 2018 14:33:24 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Hi Ard, On 2018.12.07 14:08, Ard Biesheuvel wrote: > On Fri, 7 Dec 2018 at 13:13, Pete Batard wrote: >> >> Preamble: >> >> Because of its price point, ease of use and availability, the Raspberry Pi is >> undeniably one of the most successful ARM platform in existence today. Its >> widespread adoption therefore makes it a perfect fit as an EDK2 platform. >> >> However, up until now, the Raspberry Pi hasn't been supported as a bona fide >> platform in our repository. This series of patches remedies that by introducing >> the Raspberry Pi 3 Model B and Model B+ as a viable EDK2 platforms. >> > > Thanks Pete, this is excellent work Well, most of it is based on your initial work for that platform... ;) >> Patch Breakdown: >> >> Since this is a platform introduction, we simply chose to break the commits >> into edk2-platforms and edk2-non-osi components, as we see little point in >> splitting the series into further subcomponents, when the structure would be >> similar to the overall subdirectory layout and of course, one needs to apply >> all components at once to be able to test the firmware. >> > > You will have to split it up, or i won't be able to review it. Do you have a preference with regards to breaking it down? Would a 4-way ACPI / Drivers / Library / Non-OSI work for you, or do you want to go more fine grained? I'm not sure what will make the reviewing process easier, so if you have guidance as to how you'd prefer to see things split, I'll take it. > BTW I managed to build the code with GCC 6 just fine - are you sure > the GCC 5.5 limitation still exists? Well, the problem we've seen isn't with building the firmware itself, but with getting sporadic (but not systematic) Synchronous Exceptions during early boot, when using GCC 6 or later. After switching to GCC 5.5, I have not seen any of these exceptions occur, so, even if we have applied other changes that may have helped since, I prefer erring on the side of caution for the time being... Regards, /Pete