From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (NAM11-DM6-obe.outbound.protection.outlook.com [40.107.223.125]) by mx.groups.io with SMTP id smtpd.web11.3624.1657769657904004961 for ; Wed, 13 Jul 2022 20:34:18 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@os.amperecomputing.com header.s=selector2 header.b=Wa8tiRoW; spf=pass (domain: os.amperecomputing.com, ip: 40.107.223.125, mailfrom: nhi@os.amperecomputing.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VZQgUbno5+htbJy9dZdaK+Cp+rnYmsCdXdBAX7Ul+ZiRvbpXVkqsS+KE+CfvWblNitkj3Nz62hV+FifB72pFg1goWHNug8XemeeMJh6D28bSlP33ukcOwmN45wUrFcIG3uxPyCU4tJ7PtuzXoEYoM+T8C33lMr3WVwH9M9ZqCcyDtANdesxYOI8z/rb8usOJsIqATUkuDvhxkogC2iZFWhEk1aEL0wfvdEE17Slk7uUMvbkfaHlHJKKT+bWgBXG7+x+tl4AC4ja5dRaz/3y1ys926s8ZxA6VpkJgbVTFut0QNN8xbAU+J7OvKdEdpYcRibVRAw0+ixVeZYK0PfG3jg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xk//jORE98605WC1ZNX7gMsUDw0HQjgFZ1w9ntL396A=; b=D3GAMnKz0hZE/GvAQVLqNl2OIHBzgw+AjqIYkbNyATqamiw+DFkgbPHhFbZxEA5ixOYsGB8p8mHGUJzYTC0yNinD348DR5/R57SjVMCbF/YTDaZfVeQrJ0n70v5aioaTTPGGz/ZkGthtlCAIe8/gguyNRfSdfJMqfojv7HJ0Tf3PU5MKvT54xa/5kzzyhstqHluSeIuut+NR1h7vJ4ifQua23M4kBet0gDssRWNPPYSp0jlOC7GqjD+4l9Ga0do/3MmInVU2TceWmQGZrw2Y7mAIPCZ3dHDHml1PIM+4amnOzPmswFLqb8Ktjw+EtrdybSwKWJPo7X6BUwxv7MFAfw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=os.amperecomputing.com; dkim=pass header.d=os.amperecomputing.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=os.amperecomputing.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xk//jORE98605WC1ZNX7gMsUDw0HQjgFZ1w9ntL396A=; b=Wa8tiRoWjnMLuhYscylJKasbXzgE0wPwY3/FySlUTJ7sHgnWgzEFQq0TqE1dsdQ7VWFgNZ7Z0uHjFPUcVbGTbZfd0TIA0Y6kiENSLt2qEO+QKdzJOsV0uIJMMiYEK4tyKf1902Gxr8F5XUDmEY/LuJlyRUM+9iFQ224xlihlpP4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=os.amperecomputing.com; Received: from PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) by SJ0PR01MB7527.prod.exchangelabs.com (2603:10b6:a03:3da::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5417.25; Thu, 14 Jul 2022 03:34:13 +0000 Received: from PH0PR01MB7287.prod.exchangelabs.com ([fe80::b476:d1a1:cacb:d7fe]) by PH0PR01MB7287.prod.exchangelabs.com ([fe80::b476:d1a1:cacb:d7fe%9]) with mapi id 15.20.5417.026; Thu, 14 Jul 2022 03:34:13 +0000 Message-ID: Date: Thu, 14 Jul 2022 10:34:03 +0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH edk2-platforms v3 08/12] Silicon/Ampere: Add VariableFlashInfoLib To: Sami Mujawar , devel@edk2.groups.io Cc: vunguyen@os.amperecomputing.com, thang@os.amperecomputing.com, chuong@os.amperecomputing.com, quic_llindhol@quicinc.com, Matteo.Carlini@arm.com, Akanksha.Jain2@arm.com, Ben.Adderson@arm.com, nd@arm.com References: <20220712144047.3080-1-sami.mujawar@arm.com> <20220712144047.3080-9-sami.mujawar@arm.com> From: "Nhi Pham" In-Reply-To: <20220712144047.3080-9-sami.mujawar@arm.com> X-ClientProxiedBy: SG2PR02CA0055.apcprd02.prod.outlook.com (2603:1096:4:54::19) To PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) Return-Path: nhi@os.amperecomputing.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 58d59155-15cb-4c3d-4a87-08da6549b846 X-MS-TrafficTypeDiagnostic: SJ0PR01MB7527:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dgJsvlvsyLdREuEtHpCW3BPw3J9GESsp0GAGcygkHZQB+rd8/6ieiOH/fixxmpd2Bi+R/vyJjVP91cvDqv7nKwnKsTX+Yh9z/n45GZ8XSszvZ875tI5wwxFbcl+1c2fQBneQEFPm2NW0qjRQD6D8291m8+k1WW1JGHgMQMN9So8wRO4tR0YbMwxeoWTSUkT5lGKTIjdZX4ghbIhgINyHBONeWy7Xw8ZbF5bUTga9PY5fjv667a8buIucGr8Hk6vsU8RtxMhxDbMpaOsoC0rkaoJzQqyi0N/1KgoB+OTnKI1DM6RHZEneFvZqX/ofaCQTB7+bELshFPH9mYiHWkawaKmTIPJ4D/8v0KEI2XdcaVG+KB5UAluEqoc55iQCfC2tWS9etfwwLQK2U1yCIamqHWuJx0JonlMjXUf0QVoo5zOmUXHNAoKSn+EtMdxQsZ8Kmas3d6SmbxwE4Pt5oOYTh7GP/ciHB73CAZ4j6Uk6GNL9OIpTKcQWXnQq1us4zUKEbRETGzaZzcOgQNUxR1GKyXwwY10gMRm+QLZJIesdcrT+yjs4bt7t2XMWLzh0UkRfvN9TR14PvlAP3U0pjBcRN07wlCiw1X6t5Qbdbsj+OJtjhopqW0nz2OYKzMCLM+giSmoZMUVXHObXoEJibdFiFWE47BrtLI+62Mxkx3sJ5N+tlIyIVVtmYo9O8yOhnwicvaxNvjh/4RpaUXW9KyRpa44XxIQDy+q+z6MeNt9gG/2RJqqEMTxZ5Yz8CAP3bNb6aY6JmViTRg1+QB1HAHHF9nIsxhl9I3KXd8MMZV7ZrQtLHqWPNSWYIA4yueRoyqshLvFfLLhb1f+UzCAT9o34AVkVI/25irUjtOI9/dcgrtUHu7+KUVvxbk1rQvAJ8W6G X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR01MB7287.prod.exchangelabs.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(39850400004)(396003)(366004)(376002)(346002)(136003)(2906002)(8676002)(31686004)(6666004)(38100700002)(478600001)(38350700002)(31696002)(5660300002)(8936002)(316002)(83380400001)(41300700001)(186003)(4326008)(66556008)(52116002)(6506007)(66476007)(86362001)(66946007)(6512007)(2616005)(26005)(53546011)(6486002)(43740500002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MnI0YUJ2a1FiMENTbHdzT1kvcE1scitBVFBkODdpUEl3NWpvdFNKOTE1R0Ns?= =?utf-8?B?Q2dlVVVIYm5FTW9oc0xNd20rZ0VyQ3c4c3FBYTZzZGpPMjg0YUE4K1IrRlVZ?= =?utf-8?B?WWg0TWxKa2VKK2tNSHNzekk3UW9UcW8wd2oyMUpGMEszZkV4UTkrb1lieU5P?= =?utf-8?B?NUc1aFZ5WXowRjIvQ0kzY1gvMGlNMHIydTVpbnlLQm9OSnhjaERrdHRvUUxy?= =?utf-8?B?RzV3anlQYklNMGZSbFpENml6Lzg0SWxFRXN1R0R6K2t4dUsvMTJLYWo3ZlpM?= =?utf-8?B?YjJjcTN3YlFiRWllU3dkZlFjekZUbG1UQkxpVG1Ib3VTVzVHY2NaTndRYUJO?= =?utf-8?B?TThmM3ZmVE1xNlZEV3FWOE1DZm1NQURZeDZzWWd5QUh5M2QrWUloZHBXZTNo?= =?utf-8?B?NjVTcFN2Qk8yR3JnRjNsVVorSmV3QUVjVjRIaEVQVEE2OFJXMFhYakhmamZM?= =?utf-8?B?VURleFlwT1VLcEQzb1JoM1dXd3BORXhrOXI1cm9RQWRjazVneEVSMmpITUVX?= =?utf-8?B?Um1Mc0tmYlBOV0lybkJRNVpsNHJpWCt5cG1SNlZRUng3Q3RIaDRBZ0xHR3R4?= =?utf-8?B?ZWFuRXZtTmJIdGFURWp5Ly9QRW1LYXdnUU1rSzRWWXBqNitZL3h3Q2l5YVY2?= =?utf-8?B?a3U1UkxsakFqY29PQXlHOUtoT0lTdko5ci9vN0xhRVkvYWQwZTNuU1E2Vi90?= =?utf-8?B?eHQ3VnZhRjF1TUw4NDYzbGwrLzVPTkRVaUJIT280YjM5MENoRnR6NnVCWGtr?= =?utf-8?B?ODVubWpUTDcvakkxTjVqREdiM3hGYmdsU1gxUjVqODl6MWd4WnNYMFY1cGNq?= =?utf-8?B?R3FMS1Uvbm9mVzluUktaVmd6Z0VSSlBaZFdmaCtlWnlFWElHeDQ0WVNEbzdI?= =?utf-8?B?bjFvTkFaWi9oeC9YV000T2w1TUJCakQzL1p6cWsxTVNMck1wSEx4cjJlUUpa?= =?utf-8?B?ajZPZkdydDVWWXR5MWRha1lqT3JuaTVmcTlPNFlvd0Fidkl2Z0FLdDFQbzky?= =?utf-8?B?RWRwNXZ3MzhuVm5NK3plUlVMcmRsMHZYWjhZS09waW1tbGZlTXRpM0xCZG9R?= =?utf-8?B?RjFoNkFwblg4T1drZVl5Q1FMU3c1NzBhUFdqSytJcXRXU3ZvZVZmNXRNa2tR?= =?utf-8?B?bi82WktuelNqSGxEWFptbWgxY2FrbU5LK3dMMUVxNHBZSDRwY1hrdmpHRzVs?= =?utf-8?B?YkVDanVyTFZNdDlGdzZqbzB3eUhSa2dWbGs1N0FqUFRmdU5LWHhhQXJGVUFp?= =?utf-8?B?YXZXTk5yQ2dtVWQwelVzdCt6N041TFNSSERhWmJkbkZLRVhyc3N1Z3R2OUQy?= =?utf-8?B?azRnbUMySms1R01hSGVPaFVLbXBNUDdkaFI4bW9Ic0ZpR2ZabTY4NkJiMzJS?= =?utf-8?B?VzdJQnZNRjZJTVQwQjRodU9TcnRNZmZqYTl4Qzc2UmZ3aStHczdnME9kNzln?= =?utf-8?B?bHg3cDF2SllQNDJHSzhOeXFpL0daZ2dzMWljeUttbVZrZlJHeGpPYkhGNVRm?= =?utf-8?B?eEViVmFabURleTZxSFczeEJydmpINmtzd1pYMzZSZ1pReHpjWERFRGwxbFRO?= =?utf-8?B?L2laTFhOQzdOTUY3UWdsWnFVWE42T2dadkM4SXV0ek94amx6SFJxQjRMNnRR?= =?utf-8?B?eHFFRUFBUVBZVE84Vnk1a3FxUUFBZmNuTVh4L0ErRXJCN3dnQ2o1dGFZSXV1?= =?utf-8?B?Ymlva0NQMENURTh5QmVGellUbityOU5POHlJR2xhZzNvWUR0WWdKV0Fpa01P?= =?utf-8?B?VkZIdWxsb0lPM1RscWJFNURGTHNuY0xTaXB5cnZrZzZ1a2ZFekZHWE5vdXZP?= =?utf-8?B?ZUMrVCtjYllMTlRjS2VwL21Hd0dqeTZVc1dEdWkxdFU0SnFkTys5bHFPRUJj?= =?utf-8?B?d2VuSzArT3VJRWdUaElzSlNwcSsyMCswUnBBZ2FkZnUzanZjTmRIRTVUODJN?= =?utf-8?B?aS9wdmk1L3FzQW1hMGJOQXpnSXR0eGg2RU00c0s3SC9rdGNXamw3VjJEUFVk?= =?utf-8?B?ai9wNEVkZG1nVktmbHhndFVDdlBaNjRkSFgzbmZEQTBGTVJIZk5Xc3c3UkEx?= =?utf-8?B?Q3VtM2hLMG9pdXIzejAvNGZUSlpoUFcvM3NuRXYzRFRFVXEvczg3TzgyWWxp?= =?utf-8?B?M1VqbGgzemlkYzNEZ3pEYVJhYjUvdEtpcFU5S1VBdk1lYWE2L1B6eC92MmlY?= =?utf-8?Q?WRAcVdKHwTO8peUY1Mt0/pE=3D?= X-OriginatorOrg: os.amperecomputing.com X-MS-Exchange-CrossTenant-Network-Message-Id: 58d59155-15cb-4c3d-4a87-08da6549b846 X-MS-Exchange-CrossTenant-AuthSource: PH0PR01MB7287.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Jul 2022 03:34:12.9825 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zkNw3gbkQo3nLWA1daYtKaNym/+6DMt3pR/91fBVU5llrPuEyxHJZkJUfDBhoheQ5jVwJqTkcJynhwLUa090oV+ZE0ub+6bqRd0nFYJhExA= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR01MB7527 Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Sami, Could you help update for Silicon/Ampere/AmpereAltraPkg/AmpereAltraLinuxBootPkg.dsc.inc as well? Thanks, Nhi On 12/07/2022 21:40, Sami Mujawar wrote: > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3479 > > Add an instance for the library class VariableFlashInfoLib that > was recently introduced in MdeModulePkg. This allows the variable > driver to build successfully as it has a dependency on this > library class. > > Signed-off-by: Sami Mujawar > --- > Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc b/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc > index f4007d654ec81297d4bbe002b2671c211129d819..d4c29c3c338cc8abefd84cbb3ff14d1727bd4fe4 100644 > --- a/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc > +++ b/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc > @@ -154,6 +154,7 @@ [LibraryClasses.common] > AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf > !endif > VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf > + VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/BaseVariableFlashInfoLib.inf > VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf > > #