public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Oliver Smith-Denny" <osde@linux.microsoft.com>
To: Rebecca Cran <rebecca@os.amperecomputing.com>, devel@edk2.groups.io
Cc: Leif Lindholm <quic_llindhol@quicinc.com>,
	Ard Biesheuvel <ardb+tianocore@kernel.org>,
	Jian J Wang <jian.j.wang@intel.com>,
	Liming Gao <gaoliming@byosoft.com.cn>,
	Dandan Bi <dandan.bi@intel.com>
Subject: Re: [edk2-devel] AArch64 with HeapGuard: page allocations wrongly aligned
Date: Mon, 5 Feb 2024 12:36:46 -0800	[thread overview]
Message-ID: <ec726b90-60ee-4321-861a-2a08d993faf7@linux.microsoft.com> (raw)
In-Reply-To: <bc2576d2-49f3-4147-a9d4-f88d0ea86aec@os.amperecomputing.com>

On 2/5/2024 9:58 AM, Rebecca Cran wrote:
> On 2/5/2024 10:51 AM, Oliver Smith-Denny wrote:
>> Well that's a bummer :). I moved to top of tree edk2 and added
>> StatusCodeHandlerRuntimeDxe to the ArmVirtQemu build and I am
>> not seeing your crash. Do you have any PCDs set for this driver?
> 
> Our code is pretty heavily customized, so it's likely it's doing 
> something differently. I can debug it further later this week.
> 

Ok, it would be interesting to see what is happening here. Out of
curiousity, does this repro if you only have page or pool guards set,
not both? My shell bug only repros if both are set (which would seem
to point to a bug in shared guard pages).

>>
>> I am running with the HeapGuard PCDs you sent before:
>>
>> gEfiMdeModulePkgTokenSpaceGuid.PcdHeapGuardPropertyMask|0x0F
>> gEfiMdeModulePkgTokenSpaceGuid.PcdHeapGuardPageType|0xC00000000000FFFF
>> gEfiMdeModulePkgTokenSpaceGuid.PcdHeapGuardPoolType|0xC00000000000FFFF
>>
>> However, I am seeing a crash when the shell launches now, so I will
>> debug this. Something changed in the upstream, probably exposing a bug
>> in my code. Let's see if it is the same thing as you are seeing.
> 
> Could it be this bug you're running into? 
> https://bugzilla.tianocore.org/show_bug.cgi?id=1463
> 

Unfortunately the suggested patch does not fix the bug.

Thanks,
Oliver


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115127): https://edk2.groups.io/g/devel/message/115127
Mute This Topic: https://groups.io/mt/103810212/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



  reply	other threads:[~2024-02-05 20:36 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-18 15:27 [edk2-devel] AArch64 with HeapGuard: page allocations wrongly aligned Rebecca Cran via groups.io
2024-01-18 16:48 ` Oliver Smith-Denny
2024-01-18 17:42   ` Rebecca Cran via groups.io
2024-01-18 18:38     ` Oliver Smith-Denny
2024-01-18 18:45       ` Rebecca Cran via groups.io
2024-01-18 19:04         ` Oliver Smith-Denny
2024-01-18 19:26           ` Rebecca Cran via groups.io
     [not found]     ` <17AB84FD31479E00.28523@groups.io>
2024-01-18 19:26       ` Oliver Smith-Denny
2024-01-19 16:34         ` Rebecca Cran via groups.io
2024-01-19 20:03           ` Oliver Smith-Denny
2024-01-22 22:06             ` Rebecca Cran via groups.io
2024-01-23  1:53               ` Oliver Smith-Denny
2024-01-23  2:14                 ` Rebecca Cran via groups.io
2024-01-24 18:29                   ` Oliver Smith-Denny
     [not found]               ` <17ACD713D9397BBF.18300@groups.io>
2024-02-03  0:59                 ` Oliver Smith-Denny
2024-02-05 17:22                   ` Rebecca Cran via groups.io
2024-02-05 17:51                     ` Oliver Smith-Denny
2024-02-05 17:58                       ` Rebecca Cran via groups.io
2024-02-05 20:36                         ` Oliver Smith-Denny [this message]
     [not found]                         ` <17B111E492D567BB.26550@groups.io>
2024-02-06  4:20                           ` Oliver Smith-Denny

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ec726b90-60ee-4321-861a-2a08d993faf7@linux.microsoft.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox