From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.81]) by mx.groups.io with SMTP id smtpd.web10.240.1589226664125754454 for ; Mon, 11 May 2020 12:51:04 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=fIKLINvo; spf=pass (domain: redhat.com, ip: 207.211.31.81, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1589226663; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=x79YsvtPwIa8JTTwFHwUBiOntir4RyM1I6I5GVbhTQk=; b=fIKLINvoLKY0XBtNUwrmP6FOKN2isvKmm+xEoxOTdEfSrBtbnlIbz8e/gTM7gnhlS73JlL DC/Lg7lLNPwO9qqFPvwCR2AN37csGoCnZs5FkMkchHPvXf+xAAbChIBMWmKn7fm0FzBa47 Gg7tasdSoIF/DpEOkCgvMoZv5mhaNXI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-93-yzDDIMh9PRqaguXJRrbbKw-1; Mon, 11 May 2020 15:50:46 -0400 X-MC-Unique: yzDDIMh9PRqaguXJRrbbKw-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C8D49100CCC1; Mon, 11 May 2020 19:50:45 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-113-11.ams2.redhat.com [10.36.113.11]) by smtp.corp.redhat.com (Postfix) with ESMTP id DC978784AF; Mon, 11 May 2020 19:50:44 +0000 (UTC) Subject: Re: [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process To: devel@edk2.groups.io, michael.d.kinney@intel.com, "rebecca@bsdio.com" , "rfc@edk2.groups.io" References: <8ff350e5-64ed-d338-af93-6d12f80004f5@bsdio.com> From: "Laszlo Ersek" Message-ID: Date: Mon, 11 May 2020 21:50:43 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 05/10/20 23:29, Michael D Kinney wrote: > Rebecca, > > There is no difference between CI checks run during code review > and the final CI checks before merge. I think it is an interesting > conversation to decide how many times those CI checks should be > run and if they should run automatically on every change during > review or on demand. > > Mergify is more flexible. We want to make sure the git history > is linear with not git merges and supports both single patches > and patch series without squashing. GitHub merge button by > default squashes all commits into a single commit. ( Wow, "squash-on-merge" is even the *default* now? That's terrible. Unfortunately, github.com sets a very bad example with this, which is made worse by github's popularity. How can we expect developers to think about bisectability and patch series structuring as first class traits of their contributions if github.com actively educates them to ignore those aspects? Shaking my head. ) Laszlo