From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (NAM12-BN8-obe.outbound.protection.outlook.com [40.107.237.132]) by mx.groups.io with SMTP id smtpd.web09.6561.1662550186590582628 for ; Wed, 07 Sep 2022 04:29:46 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="no key for verify" header.i=@amperemail.onmicrosoft.com header.s=selector1-amperemail-onmicrosoft-com header.b=ueNMS82G; spf=pass (domain: os.amperecomputing.com, ip: 40.107.237.132, mailfrom: nhi@os.amperecomputing.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lDnWkmrmHxwrXFeNtFPXIp54SyIMa9xLOkp/mae4eb/v7ZGg9en+mcrRqKnwxPiaiHsK2Uko3tEF7anY+D5Syf99QSZQ/uP7n/8nUuKK1LObeJp6PT+QuGVSv1MxuX4uM5aPeY/jcly4rTbIIZNkNVBNU5ZMkPyGYJNKwBWn2Em2p3JBJFLU+AegPBEDVdkVijP2tgi9BSVJugVRe4z+f4rbng4gku0LeWFc63SwXGL3Evcl5BdB07lG1njaTmxqueEx7w5qrbrThn/i4jnWMFv4s3H7CQVNbFv6++N7EnTo5Qzq3KGPzKqKEgFk+MK+gZ2v1J7mz0CVO0n89j1ClA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=O+GBaRTFffwWY+6zWp77+7fr7IzP+2pdNhq4gw7Svrg=; b=gGGCtEr5WUDsJjZIGNJnEFD3EURlJP/AgwL7r0N6YysS6+jMmSh7JRlX+GQfNGve6SgPY7nQpkd2eC2SFXjzyu55n9JknSF49CsduC2JsS3o/mid+ssy+MlxeBsEuGRaCkEABy/09AYyae9E98HIfal2AcPHdmJ6jFLxG+zqpW/ThOftNnFBewSZ+oJc63+rq8Pja6KolO4xl1kpfyXm++1Xcbn82lssWJmT76BB4a2lyHgvNDkIsHB88QvImbqwsTbfRUvFmH9Vm0d47cboqaf135uCG2Stsh+ILbGFZicJwvEsjtF9AGxivN4+6pPMt3/plvOlptFiS8iHjMgIMQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=amperemail.onmicrosoft.com; dkim=pass header.d=amperemail.onmicrosoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amperemail.onmicrosoft.com; s=selector1-amperemail-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=O+GBaRTFffwWY+6zWp77+7fr7IzP+2pdNhq4gw7Svrg=; b=ueNMS82GPqznW8Kurm7wO2QWcDKZInqU+vk9i5JlSMkX/Lb3vKmaYHg0gcMl4qybrQoCMuQEiAdVQCVzPjX9RmcBk62wvo2HP/g8wzXxXL6A0GOnNMn+6vtVK7ByVcwhZifWyj4ISVxoByKzH/LFakA7eaQQZeEw+uOBJZA1GzU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amperemail.onmicrosoft.com; Received: from PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) by DM6PR01MB4940.prod.exchangelabs.com (2603:10b6:5:9::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5588.12; Wed, 7 Sep 2022 11:29:43 +0000 Received: from PH0PR01MB7287.prod.exchangelabs.com ([fe80::fc6b:4f56:8f32:dfa5]) by PH0PR01MB7287.prod.exchangelabs.com ([fe80::fc6b:4f56:8f32:dfa5%4]) with mapi id 15.20.5612.014; Wed, 7 Sep 2022 11:29:43 +0000 Message-ID: Date: Wed, 7 Sep 2022 18:29:32 +0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 Subject: Re: [PATCH v2 0/6] ArmPkg/SMBIOS fixes and improvements To: Sami Mujawar , Ard Biesheuvel , Nhi Pham CC: "devel@edk2.groups.io" , "quic_llindhol@quicinc.com" , "ardb+tianocore@kernel.org" , "quic_rcran@quicinc.com" , "patches@amperecomputing.com" , nd References: <20220824165032.1784305-1-nhi@os.amperecomputing.com> <3E51D88E-C099-4962-960E-7DB3299B7B6E@arm.com> From: "Nhi Pham" In-Reply-To: <3E51D88E-C099-4962-960E-7DB3299B7B6E@arm.com> X-ClientProxiedBy: SG3P274CA0024.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:be::36) To PH0PR01MB7287.prod.exchangelabs.com (2603:10b6:510:10a::21) Return-Path: nhi@os.amperecomputing.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PH0PR01MB7287:EE_|DM6PR01MB4940:EE_ X-MS-Office365-Filtering-Correlation-Id: 8685ded3-e71e-45d6-5101-08da90c44284 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KgFyeX+4o8c95WzPEvlt1XYP6HJDfRLdrIbP8G9JKaQz0JQDJyrVr0Z18xGtJWXriftX5kAR72NpPAYrK0YmIDPx8UHcUuVtwIU4zkqZeFoK9nL+htpO0Iz+Mj4RNZZIBhiv9DE6tFrKBfs0f8KHH7050p42B8KUB9NTutMHTJMiYd1XuwIKAQCvViD9j9HF5aE+cZi8HQKCmyLxCKrMxnxsr9jQKLVu3iELmz07I52iAISKVjL72VuMjG3SG1CpyfJ/Vo5ANuQd2k4edJlRNxgkxHT8Azfpi+305GVN+e1B2VDG3bPh0UGZzE16/2P9PYEkmweXguExqtHcsX2S5d3dQVkWvdA9yr36VeWEEhwN/zzLODUtG5Yhe4SXJlNwrvBP9IutKs6ZDjcGRjwhXmHemRb0dbFMUf2SmGPvQccB3wIDhh3ZfwdYJ5imkfWzyWpr9vpOfD2xelBqv6PbUsvY3uAJToFCOQXrA7oasyY1+uBne1H/LE4/aDTmyyV4VicCKzRsoAkMf1Huo+EOBURSABlL8qghekj13Tnkln9k3cj6XgP8vBaf9Xl/F4QUMN5dji2MuEaCWufOFcrrGh01Cp6oT3HpuptDbJwTbzexjAQWIQG6aRuAdGhyAmec6Wms48XMbCyQdfC6HVkgcq70cQKUv7AZFomLd3aafZA5SFvVEy1unCjmnBlTyberQy7yEo6TmwDsK62FgC7Nuab8tUNaqARqK5BmXCNYOMCc5s6CtfcG18w8FVbML4X4jmJAJnmoyuxa811uncL61gRgSa3K9MdK0OODN+pVLL8= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PH0PR01MB7287.prod.exchangelabs.com;PTR:;CAT:NONE;SFS:(13230016)(4636009)(39850400004)(376002)(396003)(346002)(136003)(366004)(31696002)(2906002)(83170400001)(83380400001)(45954011)(186003)(4326008)(2616005)(8676002)(66946007)(66556008)(66476007)(5660300002)(42882007)(38350700002)(8936002)(38100700002)(110136005)(54906003)(6486002)(478600001)(6506007)(26005)(6512007)(6666004)(53546011)(52116002)(31686004)(316002)(41300700001)(43740500002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?XHuv2GJzc5WY4FSHByV8GO70evK9oSXXrr83rEw1I645TR0PYKBiF+ZQLvLe?= =?us-ascii?Q?GLBHcRLyT2tp5VNd56SDp09hhXg4zk2IHAwlXMnjYJc8CHDYew8JaGesFNXu?= =?us-ascii?Q?RvHFrbe9FIAIzUMsf4bSkOrK8QxUOhokFOZGSUDzv4EpsYT0+oOJhQ8432fI?= =?us-ascii?Q?uQ2nDxBbWl94zGKsS5fHPtDm0x7X9XLXzk4XWDd/aYb5P2+CcL/SAWhvBrmP?= =?us-ascii?Q?rcwJQuGYR4hpzanypKr+SuG+riWiidXygI1QsxscWBgwkiDmbezLjMH099Fz?= =?us-ascii?Q?vQzw2Lq5AiRIGbg8QMVeViF9EW2tUu+ijv9MEA+IibUMowRmK1g2q9rbdtjI?= =?us-ascii?Q?k0NFL3lQsDhZzgxNAohZ4kcta1VmsgYIvMUzSzca/VxMgIv5hwjU3oi3QOQc?= =?us-ascii?Q?Tsr30QfhAd5IgWbtnt7j751FkIYKv+WnyXwmyBrTIlziE6vl9wawcAvW88NF?= =?us-ascii?Q?4u9Npx0fPbx0DwxpCE59VsyKNRGzVT4Z0vHduUCE+ZD3pZD+H66hhh0rg1qM?= =?us-ascii?Q?XOtuKE16OGw8/1y8AXZN5vwBMirh6XFVWFdnDv6dZFl4DfDQ7zoFGxudxatc?= =?us-ascii?Q?ceJI/lS3RFWsX5bVKN6vz7LrVCQwzes5tEx//w132WWAcWG+A2pCl+8DJNKd?= =?us-ascii?Q?wTDeU23CmFQ9MXwfWTdLADIhxsR0grvWvHC3yRGjmm5rLNvodLZpbOkdw/P7?= =?us-ascii?Q?XsrbXMWMGzxZFF2e93I5atTOCygH9S4UT5h5YGHvhqaw6xS7xa8QC1XHHJF/?= =?us-ascii?Q?/dsDB8c+73p3aPVLAbdPHZJ1Zp5tq0NnMFc6ySHqSl5jofFT/DYCp4gJhe14?= =?us-ascii?Q?41RCum+ACrVRg4F/+RLvbBtrrznzGq5qO2BBtmONrqJR0rpcQ87BNCvXyT4g?= =?us-ascii?Q?7FUqWgxltb0Byh85R1FUEVaSeRf7SSSELWjHDtdU8O73Cpg8Fft3Kzvrqqxd?= =?us-ascii?Q?kFVBqn4HdJXuLSMSBv0ZppGhoaoX3EC6ojdYPn7E5pBu9QFdMbsKw+/SoIm2?= =?us-ascii?Q?rHLEXXvlql7+eIsa3Z0j+0sdJNCNU7mvAEndmJ6slPIJnwSIByat5UYLC0gh?= =?us-ascii?Q?QkECVkxDIhwD+BD4CBLhJ0vk4y0C0ecjoAhhCNCMql5p/DECg/nCQeydfgoW?= =?us-ascii?Q?xSp4LpHJqELpA421RKjAG5eP4RH+xcvFWTgN4CTY9lnAWxMHEHioMSMDzQLu?= =?us-ascii?Q?uofckNzNE2y5UJ6tQUAg6qAGFGA3OZKMKxYGMeMwFaX/Lec4JPFDWWnmrQyL?= =?us-ascii?Q?CfhMmru7kV5+Na8uTYyYXe7vs63w5MqgOWJef5i4I/DxbURJPZyj9WX9Heha?= =?us-ascii?Q?YolZo/aWn6ieUlgzBv29DoqEjRax4eEVl6iYN4nBwBEBmexOQzfKhtZ29NGe?= =?us-ascii?Q?PvpXvER2Xith+ELxfast/z2ipZubQpOwT7PLKePveBk9j407AL/SHD/mXqMr?= =?us-ascii?Q?rEuP2NxXm3Y4Tjel10ZhTEIiVb7Ijhne6t6yTUHeVU74o0HBIk/Z8T0L83Hs?= =?us-ascii?Q?svvrlQ2geL6B9Xntg7Q5CNRkB4hHJKcwMJ69Vs7gLbDUU4dOa7E/e9/6FOYb?= =?us-ascii?Q?6QdRdhRTUOSC9/+4UlEYcB4C67lVADjxnriO69rZ4Ewwrx2On/5B/FdQL9jv?= =?us-ascii?Q?0DSG43ZpSJOftLT0JafLLJo=3D?= X-OriginatorOrg: amperemail.onmicrosoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8685ded3-e71e-45d6-5101-08da90c44284 X-MS-Exchange-CrossTenant-AuthSource: PH0PR01MB7287.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Sep 2022 11:29:43.4570 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: QIkVoscjCrxS81z2m/c8WT60EEa74oyePej3olGBlbsXUfukrZkGokydtsIyGiRegVa/QEw/7mF+O1NBGH9Zw7AMRKtgGjENcgqg7+tV+/k= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR01MB4940 Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Thanks, Sami. I will check and submit the patch for edk2-platforms to=20 fix it. Nhi On 9/7/2022 5:49 PM, Sami Mujawar wrote: > Hi Nhi, > > I was building this patch series and realised that merging this patch ser= ies will break the SbsaQemu platform builds. > Would you be submitting a patch to update SbsaQemu platform to match this= series, please? > > Also, can you check if this patch breaks any other platform. > > Regards, > > Sami Mujawar > > =EF=BB=BFOn 05/09/2022, 12:57, "Ard Biesheuvel" wrote: > > On Wed, 24 Aug 2022 at 18:51, Nhi Pham = wrote: > > > > This patchset is to update the ArmPkg/SMBIOS for fixes and improve= ments. > > > > Changes since v1: > > + Change PartNumber to ProcessorVersion [Sami] > > > > Minh Nguyen (5): > > ArmPkg/ProcessorSubClassDxe: Get processor version from OemMiscL= ib > > ArmPkg: Correct return value of "SMCCC_ARCH_SOC_ID" Function ID = call > > ArmPkg/SmbiosMiscDxe: Fix typo of "AssetTagType02" > > ArmPkg/SmbiosMiscDxe: Remove redundant updates in SMBIOS Type 2 > > ArmPkg/SmbiosMiscDxe: Get SMBIOS information from OemMiscLib > > > > Nhi Pham (1): > > ArmPkg/SmbiosMiscDxe: Support fetching System UUID > > > > As Sami appears to be happy with this series, > > Acked-by: Ard Biesheuvel > > > ArmPkg/Include/Library/OemMiscLib.h = | 37 +++++++++++++++- > > ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c = | 46 ++++++++++++++++++++ > > ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c = | 8 +++- > > ArmPkg/Universal/Smbios/ProcessorSubClassDxe/SmbiosProcessorArmCo= mmon.c | 6 +-- > > ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type00/MiscBiosVendorFuncti= on.c | 32 +++++++++----- > > ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type01/MiscSystemManufactur= erFunction.c | 3 +- > > ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufac= turerFunction.c | 13 +----- > > 7 files changed, 117 insertions(+), 28 deletions(-) > > > > -- > > 2.25.1 > > >