From: "Laszlo Ersek" <lersek@redhat.com>
To: Vitaly Cheptsov <cheptsov@ispras.ru>, devel@edk2.groups.io
Cc: "Andrew Fish" <afish@apple.com>,
"Ard Biesheuvel" <ard.biesheuvel@linaro.org>,
"Bret Barkelew" <bret.barkelew@microsoft.com>,
"Brian J . Johnson" <brian.johnson@hpe.com>,
"Chasel Chiu" <chasel.chiu@intel.com>,
"Jordan Justen" <jordan.l.justen@intel.com>,
"Leif Lindholm" <leif@nuviainc.com>,
"Liming Gao" <liming.gao@intel.com>,
"Marvin Häuser" <mhaeuser@outlook.de>,
"Mike Kinney" <michael.d.kinney@intel.com>,
"Vincent Zimmer" <vincent.zimmer@intel.com>,
"Zhichao Gao" <zhichao.gao@intel.com>
Subject: Re: [PATCH V7 1/1] MdePkg: Fix SafeString performing assertions on runtime checks
Date: Fri, 15 May 2020 13:30:21 +0200 [thread overview]
Message-ID: <ec925339-a4bc-39ae-7cc2-a0ab61420f11@redhat.com> (raw)
In-Reply-To: <20200514173131.38072-2-cheptsov@ispras.ru>
On 05/14/20 19:31, Vitaly Cheptsov wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054
>
> Runtime checks returned via status return code should not work as
> assertions to permit parsing not trusted data with SafeString
> interfaces.
>
> CC: Andrew Fish <afish@apple.com>
> CC: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> CC: Bret Barkelew <bret.barkelew@microsoft.com>
> CC: Brian J. Johnson <brian.johnson@hpe.com>
> CC: Chasel Chiu <chasel.chiu@intel.com>
> CC: Jordan Justen <jordan.l.justen@intel.com>
> CC: Laszlo Ersek <lersek@redhat.com>
> CC: Leif Lindholm <leif@nuviainc.com>
> CC: Liming Gao <liming.gao@intel.com>
> CC: Marvin Häuser <mhaeuser@outlook.de>
> CC: Mike Kinney <michael.d.kinney@intel.com>
> CC: Vincent Zimmer <vincent.zimmer@intel.com>
> CC: Zhichao Gao <zhichao.gao@intel.com>
> Signed-off-by: Vitaly Cheptsov <vit9696@protonmail.com>
> ---
> MdePkg/Include/Library/BaseLib.h | 111 -------------------
> MdePkg/Library/BaseLib/SafeString.c | 112 --------------------
> 2 files changed, 223 deletions(-)
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
next prev parent reply other threads:[~2020-05-15 11:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-14 17:31 [PATCH V7 0/1] Disable safe string constraint assertions Vitaly Cheptsov
2020-05-14 17:31 ` [PATCH V7 1/1] MdePkg: Fix SafeString performing assertions on runtime checks Vitaly Cheptsov
2020-05-15 11:30 ` Laszlo Ersek [this message]
2020-05-18 17:04 ` [edk2-devel] " Michael D Kinney
2020-05-18 18:07 ` Vitaly Cheptsov
2020-05-20 2:48 ` Michael D Kinney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ec925339-a4bc-39ae-7cc2-a0ab61420f11@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox