From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.120]) by mx.groups.io with SMTP id smtpd.web11.11333.1589542237476286530 for ; Fri, 15 May 2020 04:30:38 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=BBMn65NR; spf=pass (domain: redhat.com, ip: 205.139.110.120, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1589542236; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=j7kqiw0jyG456fuzX+RhN5ar38wKDdsJuXbRVQwLqvk=; b=BBMn65NR2/RDHm2T97CNKNgFj9FNuKXtKB57OxNPOU7EXrAirEtBhOtEJ9NAvBzZXtqY1r OGFRZzDpq5HUvPxl1CDZh4sS6/xonlGCtUfcgfHeyLS+Dw0uGKtB8DJ9g3RIiqBXO2kKUo lZyPoxpvSQwqaYpj5T1Zew84QlodWzU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-246-_rNjxvdRMU28ut0FDw_YuA-1; Fri, 15 May 2020 07:30:31 -0400 X-MC-Unique: _rNjxvdRMU28ut0FDw_YuA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A76411005510; Fri, 15 May 2020 11:30:28 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-113-220.ams2.redhat.com [10.36.113.220]) by smtp.corp.redhat.com (Postfix) with ESMTP id 355F710013BD; Fri, 15 May 2020 11:30:22 +0000 (UTC) Subject: Re: [PATCH V7 1/1] MdePkg: Fix SafeString performing assertions on runtime checks To: Vitaly Cheptsov , devel@edk2.groups.io Cc: Andrew Fish , Ard Biesheuvel , Bret Barkelew , "Brian J . Johnson" , Chasel Chiu , Jordan Justen , Leif Lindholm , Liming Gao , =?UTF-8?Q?Marvin_H=c3=a4user?= , Mike Kinney , Vincent Zimmer , Zhichao Gao References: <20200514173131.38072-1-cheptsov@ispras.ru> <20200514173131.38072-2-cheptsov@ispras.ru> From: "Laszlo Ersek" Message-ID: Date: Fri, 15 May 2020 13:30:21 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200514173131.38072-2-cheptsov@ispras.ru> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit On 05/14/20 19:31, Vitaly Cheptsov wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 > > Runtime checks returned via status return code should not work as > assertions to permit parsing not trusted data with SafeString > interfaces. > > CC: Andrew Fish > CC: Ard Biesheuvel > CC: Bret Barkelew > CC: Brian J. Johnson > CC: Chasel Chiu > CC: Jordan Justen > CC: Laszlo Ersek > CC: Leif Lindholm > CC: Liming Gao > CC: Marvin Häuser > CC: Mike Kinney > CC: Vincent Zimmer > CC: Zhichao Gao > Signed-off-by: Vitaly Cheptsov > --- > MdePkg/Include/Library/BaseLib.h | 111 ------------------- > MdePkg/Library/BaseLib/SafeString.c | 112 -------------------- > 2 files changed, 223 deletions(-) Reviewed-by: Laszlo Ersek