From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id EA0477803E4 for ; Tue, 19 Sep 2023 15:19:47 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=fQmkWIkIzoqpmKebBHE5eIXESlXEpos2ktqCLk7h7dc=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:CC:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1695136786; v=1; b=ZJjczFH93dVuyPACls9L93dmI1svSNZyGu6qu7+uz8epPWPjdqAmWodHd0jIRQlyqHrlIFC8 pT0frchAxHZQU0PyY6qB+Dsbtxhj8SaXZaJvH6teIdoQBc3+PZjYNvrvlrpRTiW4w3R+Us929xx JREzo45c7y20+ax1pgVCBfEk= X-Received: by 127.0.0.2 with SMTP id V5gDYY7687511xbjYgUuEXRC; Tue, 19 Sep 2023 08:19:46 -0700 X-Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by mx.groups.io with SMTP id smtpd.web11.12325.1695136785741131616 for ; Tue, 19 Sep 2023 08:19:45 -0700 X-Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 38JBnEcT031463; Tue, 19 Sep 2023 15:19:42 GMT X-Received: from nasanppmta04.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3t72ngsaus-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 19 Sep 2023 15:19:42 +0000 X-Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA04.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 38JFJfU5024690 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 19 Sep 2023 15:19:41 GMT X-Received: from [10.111.128.147] (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.36; Tue, 19 Sep 2023 08:19:40 -0700 Message-ID: Date: Tue, 19 Sep 2023 16:19:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH 0/2] ArmPkg/ArmVirtPkg: handle FEAT_VHE NS-EL2 virtual timer To: Peter Maydell CC: , Ard Biesheuvel , Sami Mujawar References: <20230919112015.229479-1-quic_llindhol@quicinc.com> From: "Leif Lindholm" In-Reply-To: X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-GUID: xiqnNWkSnZf8CzfwaRHd42FZCRhACgak X-Proofpoint-ORIG-GUID: xiqnNWkSnZf8CzfwaRHd42FZCRhACgak Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,quic_llindhol@quicinc.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: AXL2sPNcok7eCxbG5RtZcXyax7686176AA= Content-Language: en-GB Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=ZJjczFH9; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=quicinc.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 2023-09-19 14:18, Peter Maydell wrote: > On Tue, 19 Sept 2023 at 12:20, Leif Lindholm = wrote: >> >> An ASSERT trips when we try to add the NS-EL2 virtual timer to qemu >> mach-virt. >> >> Add a new Pcd for the new private peripheral interrupt id, >> PcdArmArchTimerHypVirtIntrNum. >> >> Update ArmVirtTimerFdtClientLib to: >> - Only assert on receiving less information that required through DT. >> - Set PcdArmArchTimerHypVirtIntrNum if provided through DT. >> >> Reported-by: Peter Maydell >> Cc: Ard Biesheuvel >> Cc: Sami Mujawar >=20 > Thanks for writing and sending out these patches. I've tested, and > they are sufficient to get EDK2 to not assert and successfully > boot a guest OS when using my QEMU RFC patchset that reports the > new interrupt ID via the dtb: > https://patchew.org/QEMU/20230919101240.2569334-1-peter.maydell@linaro.or= g/ Are you happy for me to interpret that as Tested-by for 2/2? (1/2 just=20 being internal plumbing not related to preventing the ASSERT) / Leif -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108849): https://edk2.groups.io/g/devel/message/108849 Mute This Topic: https://groups.io/mt/101453745/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-