From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f196.google.com (mail-pf1-f196.google.com [209.85.210.196]) by mx.groups.io with SMTP id smtpd.web09.14090.1605131815980067123 for ; Wed, 11 Nov 2020 13:56:56 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=f2mBFKfA; spf=pass (domain: nuviainc.com, ip: 209.85.210.196, mailfrom: rebecca@nuviainc.com) Received: by mail-pf1-f196.google.com with SMTP id z3so2532963pfb.10 for ; Wed, 11 Nov 2020 13:56:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=/7xWW39JM2ePxucqTEix57B6TpoF0idJ6MnTMGBli/M=; b=f2mBFKfAn8L+KFSoRD6vsM6rhKZ9+/WkCweDjA52jhDnDGdX3sjdx/cjDSV/HZLK/u EE9DnsGeZA16e0cc6fvcnnassj2LIXqX6Dp2G+m1EIv7zJgm/1dUD2CD84R8rBuZXWMR uVI0Rq+znMD3jrU8g7fE+54Xagh25nPCepzIWb/ufvPbaTMuzrJkk70LzVBc2s0IWJ0z 4rn5ILDHhi0AMhwdF2hLlvUCRTALxW/uda9w+cciQTxOUQzT8fDJaRpm0n+CNLHCsQCm 0XKdziM6yjdLYLoTZeXSlnN6VETYV5sj3JZW/B+HAVsCPZc7UqK3tM+piAGnCH1baJ6c nJ7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=/7xWW39JM2ePxucqTEix57B6TpoF0idJ6MnTMGBli/M=; b=uDGCaj3a9x9x0T4D8BEw1a08740X37xL/5irYVul7d8jL6NtjyORjNWsQyUoy5DhcF nt+5PUafdshZAwBOYd+Y3GfvoLkFwV3qSAUSvGVXT7Ix8vYm648X6a1DWzfs1fio3EXX GBRqi0oNZX7Um5eGAlsh3L2evg62fjGzQH7SqVw80/yqdknyUephXzqtJZppgtGyV5t2 7av7Pc3q9WTJCHwJxYU0I1mGwJtbRABcYsOdB8jXFuftn5ATXGMyHW1WgcJVREtakl0Y PgcBTyYFmNaTuxNDVbzkdwtlr5d2LBpPVEZBquh1dBNaV+WkDdyEPaRbSM/pBTEW5cjK wFQA== X-Gm-Message-State: AOAM532oiGm0ZHAspIimEs+0wgpJZtKrfBwAaLV/ZFpP3lZL2YPMa/lu tYMdMbZ2tzOwrUu2UtDTi2KQIQ== X-Google-Smtp-Source: ABdhPJw7lLDDGuzqv4mw3LBgfQx6UYntdK4O3UCr2u8SdpMnuzUES9Zt/XexH3IX8NPDqTsiu1JZug== X-Received: by 2002:a63:fc5f:: with SMTP id r31mr23255606pgk.90.1605131815473; Wed, 11 Nov 2020 13:56:55 -0800 (PST) Return-Path: Received: from [10.0.10.142] (c-174-52-16-57.hsd1.ut.comcast.net. [174.52.16.57]) by smtp.gmail.com with ESMTPSA id s18sm3777866pfc.5.2020.11.11.13.56.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Nov 2020 13:56:54 -0800 (PST) Subject: Re: [edk2-test] [PATCH 1/3] uefi-sct/SctPkg: Fix build.sh when specifying GCC5 toolchain To: Samer El-Haj-Mahmoud , "devel@edk2.groups.io" Cc: Eric Jin , G Edhaya Chandran References: <20200924213742.25278-1-rebecca@nuviainc.com> <20200924213742.25278-2-rebecca@nuviainc.com> From: "Rebecca Cran" Message-ID: Date: Wed, 11 Nov 2020 14:56:52 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Samer, That doesn't fix it: the script as written expects you to run it with "GCC" and have your path configured for GCC4, GCC5 etc. However, "./build.sh --help" says: [build type (RELEASE OR DEBUG, DEFAULT: DEBUG)]" I interpreted "GCC*" as meaning you could pass "GCC5" and have it work like edk2 in that it would build for gcc 5 and newer. My patch at least allows "GCC5" to work the same as just "GCC". -- Rebecca Cran On 11/11/20 2:01 PM, Samer El-Haj-Mahmoud wrote: > Rebecca, > > First, apologies for the delayed review! And thanks for contributing these fixes to SCT. > > Did you happen to check if https://github.com/tianocore/edk2-test/commit/323883de08ec30072c683d7e0602158e6e3e66fe already fixed this gcc5 build issue? > > > >> -----Original Message----- >> From: Rebecca Cran >> Sent: Thursday, September 24, 2020 5:38 PM >> To: devel@edk2.groups.io >> Cc: Eric Jin ; G Edhaya Chandran >> ; Samer El-Haj-Mahmoud > Mahmoud@arm.com>; Rebecca Cran >> Subject: [edk2-test] [PATCH 1/3] uefi-sct/SctPkg: Fix build.sh when >> specifying GCC5 toolchain >> >> build.sh usage indicates that "GCC5" can be specified, but it's currently >> rejected due to a case statement only matching "GCC" or "gcc". >> Fix this by adding a wildcard match. >> >> Signed-off-by: Rebecca Cran >> --- >> uefi-sct/SctPkg/build.sh | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/uefi-sct/SctPkg/build.sh b/uefi-sct/SctPkg/build.sh index >> cad17ccdedc7..be610debcf3c 100755 >> --- a/uefi-sct/SctPkg/build.sh >> +++ b/uefi-sct/SctPkg/build.sh >> @@ -151,7 +151,7 @@ case `uname` in >> TARGET_TOOLS=ARMGCC >> ;; >> >> -GCC | gcc) >> +GCC* | gcc*) >> set_cross_compile >> CROSS_COMPILE="$TEMP_CROSS_COMPILE" >> export TARGET_TOOLS=`get_gcc_version "$CROSS_COMPILE"gcc` >> -- >> 2.26.2 > IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.