Re: [PATCH] SourceLevelDebugPkg DebugAgentLib: Rename IsBsp to DebugAgentIsBsp

["Ni, Ruiyu" <ruiyu.ni@Intel.com>]

On 2/6/2018 8:20 PM, Star Zeng wrote:
> For avoiding function name confliction,
> rename IsBsp to DebugAgentIsBsp.
> 
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Hao Wu <hao.a.wu@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Star Zeng <star.zeng@intel.com>
> ---
>   SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgent.c | 4 ++--
>   SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.c    | 4 ++--
>   SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.h    | 2 +-
>   3 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgent.c b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgent.c
> index 36b1ef924cd2..7c05ce2f2806 100644
> --- a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgent.c
> +++ b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgent.c
> @@ -2485,7 +2485,7 @@ InterruptProcess (
>       AcquireMpSpinLock (&mDebugMpContext.DebugPortSpinLock);
>   
>       if (MultiProcessorDebugSupport()) {
> -      if (IsBsp (ProcessorIndex)) {
> +      if (DebugAgentIsBsp (ProcessorIndex)) {
>           //
>           // If current processor is BSP, check Apic timer's init count if changed,
>           // it may be re-written when switching BSP.
> @@ -2498,7 +2498,7 @@ InterruptProcess (
>           }
>         }
>   
> -      if (!IsBsp (ProcessorIndex) || mDebugMpContext.IpiSentByAp) {
> +      if (!DebugAgentIsBsp (ProcessorIndex) || mDebugMpContext.IpiSentByAp) {
>           ReleaseMpSpinLock (&mDebugMpContext.DebugPortSpinLock);
>           //
>           // If current processor is not BSP or this is one IPI sent by AP
> diff --git a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.c b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.c
> index d49d4ee32347..51f40cb56b77 100644
> --- a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.c
> +++ b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.c
> @@ -75,7 +75,7 @@ HaltOtherProcessors (
>     )
>   {
>     DebugAgentMsgPrint (DEBUG_AGENT_INFO, "processor[%x]:Try to halt other processors.\n", CurrentProcessorIndex);
> -  if (!IsBsp (CurrentProcessorIndex)) {
> +  if (!DebugAgentIsBsp (CurrentProcessorIndex)) {
>       SetIpiSentByApFlag (TRUE);;
>     }
>   
> @@ -137,7 +137,7 @@ GetProcessorIndex (
>   
>   **/
>   BOOLEAN
> -IsBsp (
> +DebugAgentIsBsp (
>     IN UINT32  ProcessorIndex
>     )
>   {
> diff --git a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.h b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.h
> index 5bb50960ca72..d9c21efdaad1 100644
> --- a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.h
> +++ b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.h
> @@ -96,7 +96,7 @@ ReleaseMpSpinLock (
>   
>   **/
>   BOOLEAN
> -IsBsp (
> +DebugAgentIsBsp (
>     IN UINT32             ProcessorIndex
>     );
>   
> 
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>

-- 
Thanks,
Ray