From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.93; helo=mga11.intel.com; envelope-from=ruiyu.ni@intel.com; receiver=edk2-devel@lists.01.org Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1BAD821F0DA6F for ; Tue, 6 Feb 2018 19:24:22 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Feb 2018 19:30:05 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,471,1511856000"; d="scan'208";a="29468579" Received: from ray-dev.ccr.corp.intel.com (HELO [10.239.9.19]) ([10.239.9.19]) by orsmga001.jf.intel.com with ESMTP; 06 Feb 2018 19:30:04 -0800 To: Star Zeng , edk2-devel@lists.01.org Cc: Hao Wu References: <1517919657-9016-1-git-send-email-star.zeng@intel.com> From: "Ni, Ruiyu" Message-ID: Date: Wed, 7 Feb 2018 11:30:03 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <1517919657-9016-1-git-send-email-star.zeng@intel.com> Subject: Re: [PATCH] SourceLevelDebugPkg DebugAgentLib: Rename IsBsp to DebugAgentIsBsp X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Feb 2018 03:24:22 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 2/6/2018 8:20 PM, Star Zeng wrote: > For avoiding function name confliction, > rename IsBsp to DebugAgentIsBsp. > > Cc: Ruiyu Ni > Cc: Hao Wu > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Star Zeng > --- > SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgent.c | 4 ++-- > SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.c | 4 ++-- > SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.h | 2 +- > 3 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgent.c b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgent.c > index 36b1ef924cd2..7c05ce2f2806 100644 > --- a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgent.c > +++ b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgent.c > @@ -2485,7 +2485,7 @@ InterruptProcess ( > AcquireMpSpinLock (&mDebugMpContext.DebugPortSpinLock); > > if (MultiProcessorDebugSupport()) { > - if (IsBsp (ProcessorIndex)) { > + if (DebugAgentIsBsp (ProcessorIndex)) { > // > // If current processor is BSP, check Apic timer's init count if changed, > // it may be re-written when switching BSP. > @@ -2498,7 +2498,7 @@ InterruptProcess ( > } > } > > - if (!IsBsp (ProcessorIndex) || mDebugMpContext.IpiSentByAp) { > + if (!DebugAgentIsBsp (ProcessorIndex) || mDebugMpContext.IpiSentByAp) { > ReleaseMpSpinLock (&mDebugMpContext.DebugPortSpinLock); > // > // If current processor is not BSP or this is one IPI sent by AP > diff --git a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.c b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.c > index d49d4ee32347..51f40cb56b77 100644 > --- a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.c > +++ b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.c > @@ -75,7 +75,7 @@ HaltOtherProcessors ( > ) > { > DebugAgentMsgPrint (DEBUG_AGENT_INFO, "processor[%x]:Try to halt other processors.\n", CurrentProcessorIndex); > - if (!IsBsp (CurrentProcessorIndex)) { > + if (!DebugAgentIsBsp (CurrentProcessorIndex)) { > SetIpiSentByApFlag (TRUE);; > } > > @@ -137,7 +137,7 @@ GetProcessorIndex ( > > **/ > BOOLEAN > -IsBsp ( > +DebugAgentIsBsp ( > IN UINT32 ProcessorIndex > ) > { > diff --git a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.h b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.h > index 5bb50960ca72..d9c21efdaad1 100644 > --- a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.h > +++ b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.h > @@ -96,7 +96,7 @@ ReleaseMpSpinLock ( > > **/ > BOOLEAN > -IsBsp ( > +DebugAgentIsBsp ( > IN UINT32 ProcessorIndex > ); > > Reviewed-by: Ruiyu Ni -- Thanks, Ray