* [PATCH] SourceLevelDebugPkg DebugAgentLib: Rename IsBsp to DebugAgentIsBsp
@ 2018-02-06 12:20 Star Zeng
2018-02-06 12:51 ` Wu, Hao A
2018-02-07 3:30 ` Ni, Ruiyu
0 siblings, 2 replies; 4+ messages in thread
From: Star Zeng @ 2018-02-06 12:20 UTC (permalink / raw)
To: edk2-devel; +Cc: Star Zeng, Ruiyu Ni, Hao Wu
For avoiding function name confliction,
rename IsBsp to DebugAgentIsBsp.
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Cc: Hao Wu <hao.a.wu@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Star Zeng <star.zeng@intel.com>
---
SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgent.c | 4 ++--
SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.c | 4 ++--
SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.h | 2 +-
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgent.c b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgent.c
index 36b1ef924cd2..7c05ce2f2806 100644
--- a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgent.c
+++ b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgent.c
@@ -2485,7 +2485,7 @@ InterruptProcess (
AcquireMpSpinLock (&mDebugMpContext.DebugPortSpinLock);
if (MultiProcessorDebugSupport()) {
- if (IsBsp (ProcessorIndex)) {
+ if (DebugAgentIsBsp (ProcessorIndex)) {
//
// If current processor is BSP, check Apic timer's init count if changed,
// it may be re-written when switching BSP.
@@ -2498,7 +2498,7 @@ InterruptProcess (
}
}
- if (!IsBsp (ProcessorIndex) || mDebugMpContext.IpiSentByAp) {
+ if (!DebugAgentIsBsp (ProcessorIndex) || mDebugMpContext.IpiSentByAp) {
ReleaseMpSpinLock (&mDebugMpContext.DebugPortSpinLock);
//
// If current processor is not BSP or this is one IPI sent by AP
diff --git a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.c b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.c
index d49d4ee32347..51f40cb56b77 100644
--- a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.c
+++ b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.c
@@ -75,7 +75,7 @@ HaltOtherProcessors (
)
{
DebugAgentMsgPrint (DEBUG_AGENT_INFO, "processor[%x]:Try to halt other processors.\n", CurrentProcessorIndex);
- if (!IsBsp (CurrentProcessorIndex)) {
+ if (!DebugAgentIsBsp (CurrentProcessorIndex)) {
SetIpiSentByApFlag (TRUE);;
}
@@ -137,7 +137,7 @@ GetProcessorIndex (
**/
BOOLEAN
-IsBsp (
+DebugAgentIsBsp (
IN UINT32 ProcessorIndex
)
{
diff --git a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.h b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.h
index 5bb50960ca72..d9c21efdaad1 100644
--- a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.h
+++ b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.h
@@ -96,7 +96,7 @@ ReleaseMpSpinLock (
**/
BOOLEAN
-IsBsp (
+DebugAgentIsBsp (
IN UINT32 ProcessorIndex
);
--
2.7.0.windows.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] SourceLevelDebugPkg DebugAgentLib: Rename IsBsp to DebugAgentIsBsp
2018-02-06 12:20 [PATCH] SourceLevelDebugPkg DebugAgentLib: Rename IsBsp to DebugAgentIsBsp Star Zeng
@ 2018-02-06 12:51 ` Wu, Hao A
2018-02-07 3:30 ` Ni, Ruiyu
1 sibling, 0 replies; 4+ messages in thread
From: Wu, Hao A @ 2018-02-06 12:51 UTC (permalink / raw)
To: Zeng, Star, edk2-devel@lists.01.org; +Cc: Ni, Ruiyu
Reviewed-by: Hao Wu <hao.a.wu@intel.com>
Best Regards,
Hao Wu
> -----Original Message-----
> From: Zeng, Star
> Sent: Tuesday, February 06, 2018 8:21 PM
> To: edk2-devel@lists.01.org
> Cc: Zeng, Star; Ni, Ruiyu; Wu, Hao A
> Subject: [PATCH] SourceLevelDebugPkg DebugAgentLib: Rename IsBsp to
> DebugAgentIsBsp
>
> For avoiding function name confliction,
> rename IsBsp to DebugAgentIsBsp.
>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Hao Wu <hao.a.wu@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Star Zeng <star.zeng@intel.com>
> ---
>
> SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgent.c
> | 4 ++--
> SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.c
> | 4 ++--
> SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.h
> | 2 +-
> 3 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git
> a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgen
> t.c
> b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgen
> t.c
> index 36b1ef924cd2..7c05ce2f2806 100644
> ---
> a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgen
> t.c
> +++
> b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgen
> t.c
> @@ -2485,7 +2485,7 @@ InterruptProcess (
> AcquireMpSpinLock (&mDebugMpContext.DebugPortSpinLock);
>
> if (MultiProcessorDebugSupport()) {
> - if (IsBsp (ProcessorIndex)) {
> + if (DebugAgentIsBsp (ProcessorIndex)) {
> //
> // If current processor is BSP, check Apic timer's init count if changed,
> // it may be re-written when switching BSP.
> @@ -2498,7 +2498,7 @@ InterruptProcess (
> }
> }
>
> - if (!IsBsp (ProcessorIndex) || mDebugMpContext.IpiSentByAp) {
> + if (!DebugAgentIsBsp (ProcessorIndex) || mDebugMpContext.IpiSentByAp)
> {
> ReleaseMpSpinLock (&mDebugMpContext.DebugPortSpinLock);
> //
> // If current processor is not BSP or this is one IPI sent by AP
> diff --git
> a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.c
> b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.c
> index d49d4ee32347..51f40cb56b77 100644
> ---
> a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.c
> +++
> b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.c
> @@ -75,7 +75,7 @@ HaltOtherProcessors (
> )
> {
> DebugAgentMsgPrint (DEBUG_AGENT_INFO, "processor[%x]:Try to halt other
> processors.\n", CurrentProcessorIndex);
> - if (!IsBsp (CurrentProcessorIndex)) {
> + if (!DebugAgentIsBsp (CurrentProcessorIndex)) {
> SetIpiSentByApFlag (TRUE);;
> }
>
> @@ -137,7 +137,7 @@ GetProcessorIndex (
>
> **/
> BOOLEAN
> -IsBsp (
> +DebugAgentIsBsp (
> IN UINT32 ProcessorIndex
> )
> {
> diff --git
> a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.h
> b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.h
> index 5bb50960ca72..d9c21efdaad1 100644
> ---
> a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.h
> +++
> b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.h
> @@ -96,7 +96,7 @@ ReleaseMpSpinLock (
>
> **/
> BOOLEAN
> -IsBsp (
> +DebugAgentIsBsp (
> IN UINT32 ProcessorIndex
> );
>
> --
> 2.7.0.windows.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] SourceLevelDebugPkg DebugAgentLib: Rename IsBsp to DebugAgentIsBsp
2018-02-06 12:20 [PATCH] SourceLevelDebugPkg DebugAgentLib: Rename IsBsp to DebugAgentIsBsp Star Zeng
2018-02-06 12:51 ` Wu, Hao A
@ 2018-02-07 3:30 ` Ni, Ruiyu
2018-02-08 7:18 ` Ni, Ruiyu
1 sibling, 1 reply; 4+ messages in thread
From: Ni, Ruiyu @ 2018-02-07 3:30 UTC (permalink / raw)
To: Star Zeng, edk2-devel; +Cc: Hao Wu
On 2/6/2018 8:20 PM, Star Zeng wrote:
> For avoiding function name confliction,
> rename IsBsp to DebugAgentIsBsp.
>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Hao Wu <hao.a.wu@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Star Zeng <star.zeng@intel.com>
> ---
> SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgent.c | 4 ++--
> SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.c | 4 ++--
> SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.h | 2 +-
> 3 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgent.c b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgent.c
> index 36b1ef924cd2..7c05ce2f2806 100644
> --- a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgent.c
> +++ b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAgent.c
> @@ -2485,7 +2485,7 @@ InterruptProcess (
> AcquireMpSpinLock (&mDebugMpContext.DebugPortSpinLock);
>
> if (MultiProcessorDebugSupport()) {
> - if (IsBsp (ProcessorIndex)) {
> + if (DebugAgentIsBsp (ProcessorIndex)) {
> //
> // If current processor is BSP, check Apic timer's init count if changed,
> // it may be re-written when switching BSP.
> @@ -2498,7 +2498,7 @@ InterruptProcess (
> }
> }
>
> - if (!IsBsp (ProcessorIndex) || mDebugMpContext.IpiSentByAp) {
> + if (!DebugAgentIsBsp (ProcessorIndex) || mDebugMpContext.IpiSentByAp) {
> ReleaseMpSpinLock (&mDebugMpContext.DebugPortSpinLock);
> //
> // If current processor is not BSP or this is one IPI sent by AP
> diff --git a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.c b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.c
> index d49d4ee32347..51f40cb56b77 100644
> --- a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.c
> +++ b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.c
> @@ -75,7 +75,7 @@ HaltOtherProcessors (
> )
> {
> DebugAgentMsgPrint (DEBUG_AGENT_INFO, "processor[%x]:Try to halt other processors.\n", CurrentProcessorIndex);
> - if (!IsBsp (CurrentProcessorIndex)) {
> + if (!DebugAgentIsBsp (CurrentProcessorIndex)) {
> SetIpiSentByApFlag (TRUE);;
> }
>
> @@ -137,7 +137,7 @@ GetProcessorIndex (
>
> **/
> BOOLEAN
> -IsBsp (
> +DebugAgentIsBsp (
> IN UINT32 ProcessorIndex
> )
> {
> diff --git a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.h b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.h
> index 5bb50960ca72..d9c21efdaad1 100644
> --- a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.h
> +++ b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugMp.h
> @@ -96,7 +96,7 @@ ReleaseMpSpinLock (
>
> **/
> BOOLEAN
> -IsBsp (
> +DebugAgentIsBsp (
> IN UINT32 ProcessorIndex
> );
>
>
Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
--
Thanks,
Ray
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] SourceLevelDebugPkg DebugAgentLib: Rename IsBsp to DebugAgentIsBsp
2018-02-07 3:30 ` Ni, Ruiyu
@ 2018-02-08 7:18 ` Ni, Ruiyu
0 siblings, 0 replies; 4+ messages in thread
From: Ni, Ruiyu @ 2018-02-08 7:18 UTC (permalink / raw)
To: Ni, Ruiyu, Zeng, Star, edk2-devel@lists.01.org; +Cc: Wu, Hao A
Remember to update the copyright year when committing the patch.
Thanks/Ray
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ni,
> Ruiyu
> Sent: Wednesday, February 7, 2018 11:30 AM
> To: Zeng, Star <star.zeng@intel.com>; edk2-devel@lists.01.org
> Cc: Wu, Hao A <hao.a.wu@intel.com>
> Subject: Re: [edk2] [PATCH] SourceLevelDebugPkg DebugAgentLib: Rename
> IsBsp to DebugAgentIsBsp
>
> On 2/6/2018 8:20 PM, Star Zeng wrote:
> > For avoiding function name confliction, rename IsBsp to
> > DebugAgentIsBsp.
> >
> > Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> > Cc: Hao Wu <hao.a.wu@intel.com>
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Star Zeng <star.zeng@intel.com>
> > ---
> >
> SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugAg
> ent.c | 4 ++--
> >
> SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugM
> p.c | 4 ++--
> >
> SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/DebugM
> p.h | 2 +-
> > 3 files changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git
> >
> a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Debug
> Agent.c
> >
> b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Debug
> Agent.c
> > index 36b1ef924cd2..7c05ce2f2806 100644
> > ---
> >
> a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Debug
> Agent.c
> > +++
> b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Debug
> Age
> > +++ nt.c
> > @@ -2485,7 +2485,7 @@ InterruptProcess (
> > AcquireMpSpinLock (&mDebugMpContext.DebugPortSpinLock);
> >
> > if (MultiProcessorDebugSupport()) {
> > - if (IsBsp (ProcessorIndex)) {
> > + if (DebugAgentIsBsp (ProcessorIndex)) {
> > //
> > // If current processor is BSP, check Apic timer's init count if changed,
> > // it may be re-written when switching BSP.
> > @@ -2498,7 +2498,7 @@ InterruptProcess (
> > }
> > }
> >
> > - if (!IsBsp (ProcessorIndex) || mDebugMpContext.IpiSentByAp) {
> > + if (!DebugAgentIsBsp (ProcessorIndex) ||
> > + mDebugMpContext.IpiSentByAp) {
> > ReleaseMpSpinLock (&mDebugMpContext.DebugPortSpinLock);
> > //
> > // If current processor is not BSP or this is one IPI sent
> > by AP diff --git
> >
> a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Debug
> Mp.c
> >
> b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Debug
> Mp.c
> > index d49d4ee32347..51f40cb56b77 100644
> > ---
> >
> a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Debug
> Mp.c
> > +++
> b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Debug
> Mp.
> > +++ c
> > @@ -75,7 +75,7 @@ HaltOtherProcessors (
> > )
> > {
> > DebugAgentMsgPrint (DEBUG_AGENT_INFO, "processor[%x]:Try to halt
> > other processors.\n", CurrentProcessorIndex);
> > - if (!IsBsp (CurrentProcessorIndex)) {
> > + if (!DebugAgentIsBsp (CurrentProcessorIndex)) {
> > SetIpiSentByApFlag (TRUE);;
> > }
> >
> > @@ -137,7 +137,7 @@ GetProcessorIndex (
> >
> > **/
> > BOOLEAN
> > -IsBsp (
> > +DebugAgentIsBsp (
> > IN UINT32 ProcessorIndex
> > )
> > {
> > diff --git
> >
> a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Debug
> Mp.h
> >
> b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Debug
> Mp.h
> > index 5bb50960ca72..d9c21efdaad1 100644
> > ---
> >
> a/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Debug
> Mp.h
> > +++
> b/SourceLevelDebugPkg/Library/DebugAgent/DebugAgentCommon/Debug
> Mp.
> > +++ h
> > @@ -96,7 +96,7 @@ ReleaseMpSpinLock (
> >
> > **/
> > BOOLEAN
> > -IsBsp (
> > +DebugAgentIsBsp (
> > IN UINT32 ProcessorIndex
> > );
> >
> >
> Reviewed-by: Ruiyu Ni <ruiyu.ni@intel.com>
>
> --
> Thanks,
> Ray
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-02-08 7:14 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-06 12:20 [PATCH] SourceLevelDebugPkg DebugAgentLib: Rename IsBsp to DebugAgentIsBsp Star Zeng
2018-02-06 12:51 ` Wu, Hao A
2018-02-07 3:30 ` Ni, Ruiyu
2018-02-08 7:18 ` Ni, Ruiyu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox