From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) by mx.groups.io with SMTP id smtpd.web10.150.1612804155597659000 for ; Mon, 08 Feb 2021 09:09:15 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@akeo-ie.20150623.gappssmtp.com header.s=20150623 header.b=Q9zaHTBQ; spf=pass (domain: akeo.ie, ip: 209.85.221.47, mailfrom: pete@akeo.ie) Received: by mail-wr1-f47.google.com with SMTP id u14so18131388wri.3 for ; Mon, 08 Feb 2021 09:09:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akeo-ie.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=7/XUmHbf1d39wxC+ITD3O/JaFSLqWCH7DCY+f0EcS0Q=; b=Q9zaHTBQjfRui+7hqGF85gVRtnh+LelRS7nP1YBkmI/jyQDJKeS0NiXeDb65QLywIa 1hqkq3hf3+CdFmKaZxg7bJeO6HaRq8oYS2lYw9p3tN15oyMpIuryMvsTR0033waYGEat XtxHzvgGHvjXBjphlZmMouEYbZA2RTG/ljkbTGbz5kBS14t1TYYWfKmtYLAa1cUGXw+3 1NlGhwRaIgtGJ64Q+5Iq9cZRV1Cey1Fs/TMtyUO/YeIWvQZpWoBJNjC8MrlPh3IEf5Dp tbcnlnHSS/lR6egEvBJmjf1HkIz6Mrl9IJmj4e2Ek15zhRmTBUJB788fNNPmdc5k62uS Aelg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=7/XUmHbf1d39wxC+ITD3O/JaFSLqWCH7DCY+f0EcS0Q=; b=jwI/2LUSUa87yH8d2o9HmXXxNyv4QtEO/xYKh2izqCxmrH36i8uH9nPAgo7aIszd3D 52fk/3YY9rjdZ7FAXFg0T9OXdSEtZc9zdofyIgSBod2/a8Z3YxcIxrSmxhEyS4yOE0D1 l8N5BzjCYAeCpkfWZ0hXc+Z9EFV/IwZP7QAcaKJtWXLoOD7lvubWT/e9+TKVokQTL3Wc ilTjAEhByF59fsfdhHFE/FPfhdicAZoBLls1FLFYjZUh9P8IEWgxxMc0e/XNk9wj00oN knXHXciHn7dy+wy2AuBsEUbNBgDTWIAPhv2WNy0h48zq3sZjy/iGKYNKGzLJ9qixWz+a N92g== X-Gm-Message-State: AOAM530gOpbA+rzhd5LXXVwrDC6FbTq+KrQak3Tljwi3M+D/PER1PgsJ 2niYZl5qXg6qk/lLDLg4O6UqAQ== X-Google-Smtp-Source: ABdhPJzX0+JtMuiqu/p6lVz3yYbjwEB92SrmRGA/LX9G6URlYN3i+04v7aMpx/uK0XpTMtYfdDsxWw== X-Received: by 2002:adf:a501:: with SMTP id i1mr7854143wrb.149.1612804153895; Mon, 08 Feb 2021 09:09:13 -0800 (PST) Return-Path: Received: from [10.0.0.122] ([84.203.77.31]) by smtp.googlemail.com with ESMTPSA id m18sm577643wmq.1.2021.02.08.09.09.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 Feb 2021 09:09:13 -0800 (PST) Subject: Re: [PATCH v2 4/4] Platform/RaspberryPi: Invert default Arasan, Emmc2 routing To: Jeremy Linton , devel@edk2.groups.io Cc: awarkentin@vmware.com, samer.el-haj-mahmoud@arm.com, leif@nuviainc.com, ardb+tianocore@kernel.org References: <20210201225343.2001835-1-jeremy.linton@arm.com> <20210201225343.2001835-5-jeremy.linton@arm.com> From: "Pete Batard" Message-ID: Date: Mon, 8 Feb 2021 17:09:12 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0 MIME-Version: 1.0 In-Reply-To: <20210201225343.2001835-5-jeremy.linton@arm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit On 2021.02.01 22:53, Jeremy Linton wrote: > In order for the wifi to work, and the SD to run at full > speed we need to bind the sd slot to the eMMC2 controller. For consistency, you might want to capitalize SD here, since it's capitalized before and after. > Since we now have a driver for the eMMC2 controller > there isn't any reason to leave the SD card bound > to the older Arasan controller. > > Signed-off-by: Jeremy Linton > --- > Platform/RaspberryPi/RPi4/RPi4.dsc | 2 +- > Platform/RaspberryPi/RPi4/Readme.md | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc b/Platform/RaspberryPi/RPi4/RPi4.dsc > index 9962df0076..e0fad6f744 100644 > --- a/Platform/RaspberryPi/RPi4/RPi4.dsc > +++ b/Platform/RaspberryPi/RPi4/RPi4.dsc > @@ -475,7 +475,7 @@ > # SD-related. > > # > > > > - gRaspberryPiTokenSpaceGuid.PcdSdIsArasan|L"SdIsArasan"|gConfigDxeFormSetGuid|0x0|1 > > + gRaspberryPiTokenSpaceGuid.PcdSdIsArasan|L"SdIsArasan"|gConfigDxeFormSetGuid|0x0|0 > > gRaspberryPiTokenSpaceGuid.PcdMmcForce1Bit|L"MmcForce1Bit"|gConfigDxeFormSetGuid|0x0|0 > > gRaspberryPiTokenSpaceGuid.PcdMmcForceDefaultSpeed|L"MmcForceDefaultSpeed"|gConfigDxeFormSetGuid|0x0|0 > > gRaspberryPiTokenSpaceGuid.PcdMmcSdDefaultSpeedMHz|L"MmcSdDefaultSpeedMHz"|gConfigDxeFormSetGuid|0x0|25 > > diff --git a/Platform/RaspberryPi/RPi4/Readme.md b/Platform/RaspberryPi/RPi4/Readme.md > index 3b2ed44e3c..80899f4ca4 100644 > --- a/Platform/RaspberryPi/RPi4/Readme.md > +++ b/Platform/RaspberryPi/RPi4/Readme.md > @@ -181,7 +181,7 @@ Limit RAM to 3 GB | `RamLimitTo3GB` | Disable = `0x00000000`
Ena > System Table Selection | `SystemTableMode`| ACPI = `0x00000000` (default)
ACPI + Devicetree = `0x00000001`
Devicetree = `0x00000002` > > Asset Tag | `AssetTag` | String, 32 characters or less (e.g. `L"ABCD123"`)
(default `L""`) > > **SD/MMC Configuration** | > > -uSD/eMMC Routing | `SdIsArasan` | Arasan SDHC = `0x00000001` (default)
eMMC2 SDHCI = `0x00000000` > > +uSD/eMMC Routing | `SdIsArasan` | Arasan SDHC = `0x00000001`
eMMC2 SDHCI = `0x00000000` (default) > > Multi-Block Support | `MmcDisableMulti` | Multi-block transfers = `0x00000000` (default)
Single block transfers = `0x00000001` > > uSD Max Bus Width | `MmcForce1Bit` | 4-bit Mode = `0x00000000` (default)
1-bit Mode = `0x00000001` > > uSD Force Default Speed | `MmcForceDefaultSpeed` | Allow High Speed = `0x00000000` (default)
Force Default Speed = `0x00000001` > Reviewed-by: Pete Batard