From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Mon, 08 Jul 2019 07:34:49 -0700 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 76B36883BA; Mon, 8 Jul 2019 14:34:33 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-117-3.ams2.redhat.com [10.36.117.3]) by smtp.corp.redhat.com (Postfix) with ESMTP id 14A285C46B; Mon, 8 Jul 2019 14:34:28 +0000 (UTC) Subject: Re: [PATCH v3 13/35] OvmfPkg/Library/XenPlatformLib: New library To: Anthony PERARD , devel@edk2.groups.io Cc: xen-devel@lists.xenproject.org, Ard Biesheuvel , Jordan Justen , Julien Grall References: <20190704144233.27968-1-anthony.perard@citrix.com> <20190704144233.27968-14-anthony.perard@citrix.com> From: "Laszlo Ersek" Message-ID: Date: Mon, 8 Jul 2019 16:34:28 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190704144233.27968-14-anthony.perard@citrix.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Mon, 08 Jul 2019 14:34:41 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 07/04/19 16:42, Anthony PERARD wrote: > The purpose of XenPlatformLib is to regroup the few functions that are > used in several places to detect if Xen is detected, and to get the > XenInfo HOB. > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1689 > Signed-off-by: Anthony PERARD > --- > > Notes: > v3: > - use SPDX > - add XenPlatformLib.h to [LibraryClasses] in OvmfPkg.dec > - fix typos > [snip] > diff --git a/OvmfPkg/Include/Library/XenPlatformLib.h b/OvmfPkg/Include/Library/XenPlatformLib.h > new file mode 100644 > index 0000000000..a8347602b7 > --- /dev/null > +++ b/OvmfPkg/Include/Library/XenPlatformLib.h > @@ -0,0 +1,53 @@ > +/** @file > +* Get information about Xen > +* > +* This library simply allow to find out if OVMF is running under Xen and > +* allow to get more information when it is the case. > +* > +* Copyright (c) 2019, Citrix Systems, Inc. > +* > +* SPDX-License-Identifier: BSD-2-Clause-Patent > +* > +**/ [snip] > diff --git a/OvmfPkg/Library/XenPlatformLib/XenPlatformLib.c b/OvmfPkg/Library/XenPlatformLib/XenPlatformLib.c > new file mode 100644 > index 0000000000..6f27cbffa8 > --- /dev/null > +++ b/OvmfPkg/Library/XenPlatformLib/XenPlatformLib.c > @@ -0,0 +1,69 @@ > +/** @file > +* Get information about Xen > +* > +* This library simply allow to find out if OVMF is running under Xen and > +* allow to get more information when it is the case. > +* > +* Copyright (c) 2019, Citrix Systems, Inc. > +* > +* SPDX-License-Identifier: BSD-2-Clause-Patent > +* > +**/ These comment blocks should not have a column of "*" to the left. With that fixed: Reviewed-by: Laszlo Ersek Thanks Laszlo