From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web10.15091.1672931449075715399 for ; Thu, 05 Jan 2023 07:10:49 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=e6wOJi+h; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1672931448; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uA7uhp85HTZ2Aekoob99guBmOUalZ16nuoW93Fnh47I=; b=e6wOJi+hbNCgnlsXKK5Kt/NJhYuyUev+SF6k6VabMk0QrOXBPkVZSdu+h4tDC0J2rawCYl MJgr59JEl3OP6YV4mHgLH1JnlGrmCzY0UQSr3/boyh1HlK0Gndl/WaERmIpcvrF1C4oFLd bt/GHYqhYpo+uaLUButk0FPieqyklBA= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-170-1T2Q-zTwNLuckcaxzn-ZKA-1; Thu, 05 Jan 2023 10:10:42 -0500 X-MC-Unique: 1T2Q-zTwNLuckcaxzn-ZKA-1 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 95CC280D0E7; Thu, 5 Jan 2023 15:10:41 +0000 (UTC) Received: from [10.39.192.44] (unknown [10.39.192.44]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 343581121314; Thu, 5 Jan 2023 15:10:39 +0000 (UTC) Message-ID: Date: Thu, 5 Jan 2023 16:10:38 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH V1 1/1] OvmfPkg/AcpiPlatformDxe: Add back log and fix code cohesion To: Gerd Hoffmann , devel@edk2.groups.io, min.m.xu@intel.com Cc: Erdem Aktas , James Bottomley , Jiewen Yao , Tom Lendacky , Sebastien Boeuf References: <20230104141309.1426-1-min.m.xu@intel.com> <20230105131555.vkjy64tvaxzwouky@sirius.home.kraxel.org> From: "Laszlo Ersek" In-Reply-To: <20230105131555.vkjy64tvaxzwouky@sirius.home.kraxel.org> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.3 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 1/5/23 14:15, Gerd Hoffmann wrote: > On Wed, Jan 04, 2023 at 10:13:09PM +0800, Min Xu wrote: >> From: Min M Xu >> >> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4237 >> >> Commit 9fdc70af6ba8 breaks log analysis and code cohesion in >> AcpiPlatformDxe. See the detailed information in BZ#4237. >> >> There are below changes in this patch: >> 1) Add back debug log >> 2) Add error checking and handling if InstallProtocolInterface failed. >> 3) Delete the QemuAcpiTableNotify.h because it is superfluous. >> 4) Delete the global variable "mQemuAcpiHandle" instead of a local >> variable. >> 5) Install the QEMU_ACPI_TABLE_NOTIFY_PROTOCOL with a NULL associated >> interface. > > Five changes in a single patch. Can this be splitted up please? Right, I've requested 6 patches :) Laszlo