From: "Laszlo Ersek" <lersek@redhat.com>
To: Anthony PERARD <anthony.perard@citrix.com>, devel@edk2.groups.io
Cc: Michael D Kinney <michael.d.kinney@intel.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>,
xen-devel@lists.xenproject.org, Liming Gao <liming.gao@intel.com>,
Jordan Justen <jordan.l.justen@intel.com>,
Julien Grall <julien@xen.org>
Subject: Re: [PATCH 3/5] OvmfPkg/IndustryStandard/Xen: Apply EDK2 coding style to XEN_VCPU_TIME_INFO
Date: Wed, 29 Jan 2020 17:14:35 +0100 [thread overview]
Message-ID: <edaa36a9-e4a0-8255-67b5-ebe51fae87ce@redhat.com> (raw)
In-Reply-To: <20200129121235.1814563-4-anthony.perard@citrix.com>
On 01/29/20 13:12, Anthony PERARD wrote:
> We are going to use new fields from the Xen headers. Apply the EDK2
> coding style so that the code that is going to use it doesn't look out
> of place.
>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2490
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
> ---
> OvmfPkg/Include/IndustryStandard/Xen/xen.h | 17 +++++++++--------
> 1 file changed, 9 insertions(+), 8 deletions(-)
This is highly appreciated. Comments below:
>
> diff --git a/OvmfPkg/Include/IndustryStandard/Xen/xen.h b/OvmfPkg/Include/IndustryStandard/Xen/xen.h
> index e55d93263285..ac9155089902 100644
> --- a/OvmfPkg/Include/IndustryStandard/Xen/xen.h
> +++ b/OvmfPkg/Include/IndustryStandard/Xen/xen.h
> @@ -183,10 +183,10 @@ struct vcpu_time_info {
> * The correct way to interact with the version number is similar to
> * Linux's seqlock: see the implementations of read_seqbegin/read_seqretry.
> */
> - UINT32 version;
> + UINT32 Version;
> UINT32 pad0;
> - UINT64 tsc_timestamp; /* TSC at last update of time vals. */
> - UINT64 system_time; /* Time, in nanosecs, since boot. */
> + UINT64 TSCTimestamp; /* TSC at last update of time vals. */
(1) Should be "TscTimestamp". Acronyms are de-capitalized when composed
into longer identifiers, to maintain a consistent CamelCase.
> + UINT64 SystemTime; /* Time, in nanosecs, since boot. */
> /*
> * Current system time:
> * system_time +
> @@ -194,11 +194,11 @@ struct vcpu_time_info {
> * CPU frequency (Hz):
> * ((10^9 << 32) / tsc_to_system_mul) >> tsc_shift
> */
> - UINT32 tsc_to_system_mul;
> - INT8 tsc_shift;
> + UINT32 TSCToSystemMultiplier;
> + INT8 TSCShift;
(2) Ditto (both fields).
> INT8 pad1[3];
> }; /* 32 bytes */
> -typedef struct vcpu_time_info vcpu_time_info_t;
> +typedef struct vcpu_time_info XEN_VCPU_TIME_INFO;
>
> struct vcpu_info {
> /*
> @@ -234,7 +234,7 @@ struct vcpu_info {
> #endif /* XEN_HAVE_PV_UPCALL_MASK */
> xen_ulong_t evtchn_pending_sel;
> struct arch_vcpu_info arch;
> - struct vcpu_time_info time;
> + struct vcpu_time_info Time;
> }; /* 64 bytes (x86) */
> #ifndef __XEN__
> typedef struct vcpu_info vcpu_info_t;
> @@ -250,7 +250,7 @@ typedef struct vcpu_info vcpu_info_t;
> * of this structure remaining constant.
> */
> struct shared_info {
> - struct vcpu_info vcpu_info[XEN_LEGACY_MAX_VCPUS];
> + struct vcpu_info VcpuInfo[XEN_LEGACY_MAX_VCPUS];
Yes, this is a good example. "Vcpu" and not "VCPU" or "VCpu".
>
> /*
> * A domain can create "event channels" on which it can send and receive
> @@ -299,6 +299,7 @@ struct shared_info {
> };
> #ifndef __XEN__
> typedef struct shared_info shared_info_t;
> +typedef struct shared_info XEN_SHARED_INFO;
> #endif
>
> /* Turn a plain number into a C UINTN constant. */
>
Assuming the OVMF platforms continue to build at this stage into the
series, and provided that (1) and (2) are fixed:
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
next prev parent reply other threads:[~2020-01-29 16:14 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-29 12:12 [PATCH 0/5] OvmfXen: Set PcdFSBClock at runtime Anthony PERARD
2020-01-29 12:12 ` [PATCH 1/5] OvmfPkg/XenResetVector: Silent a warning from nasm Anthony PERARD
2020-01-29 16:08 ` Laszlo Ersek
2020-01-29 12:12 ` [PATCH 2/5] MdePkg: Allow PcdFSBClock to by Dynamic Anthony PERARD
2020-01-29 16:10 ` Laszlo Ersek
2020-02-03 1:34 ` Liming Gao
2020-02-03 15:34 ` Anthony PERARD
2020-02-03 17:26 ` Anthony PERARD
2020-02-04 6:49 ` [edk2-devel] " Liming Gao
2020-01-29 12:12 ` [PATCH 3/5] OvmfPkg/IndustryStandard/Xen: Apply EDK2 coding style to XEN_VCPU_TIME_INFO Anthony PERARD
2020-01-29 16:14 ` Laszlo Ersek [this message]
2020-01-30 10:31 ` Anthony PERARD
2020-01-29 12:12 ` [PATCH 4/5] OvmfPkg/XenPlatformPei: Calibrate APIC timer frequency Anthony PERARD
2020-01-29 16:29 ` Laszlo Ersek
2020-01-30 9:12 ` Roger Pau Monné
2020-01-30 12:44 ` Anthony PERARD
2020-01-30 13:10 ` [Xen-devel] " Andrew Cooper
2020-01-29 12:12 ` [PATCH 5/5] OvmfPkg/OvmfXen: Set PcdFSBClock Anthony PERARD
2020-01-29 16:36 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=edaa36a9-e4a0-8255-67b5-ebe51fae87ce@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox