From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.85.221.65, mailfrom: philmd@redhat.com) Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by groups.io with SMTP; Thu, 25 Jul 2019 04:12:26 -0700 Received: by mail-wr1-f65.google.com with SMTP id r1so50310456wrl.7 for ; Thu, 25 Jul 2019 04:12:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=aVKQCcTSgT/FYbJZVZYsY3bhq8rGxctmc41NhtdPsgY=; b=qITSG7+L+NU7axob3+dSPrPouHmEY3xFfyApbXdjUDD0zCCQH3VFH18+NqFuqYGwgt PvNn+/MyV9VQfbR4pFGvvHcqCOgNvau1VVeQAg5XxOGeXabF27WvVXPdUXxgsQFOqc14 FZvH1CKkCeXtt8fqtCXTKyJGkTO5YU4fqpHC0xZ40fak2b2xhISEIKwTaEq3G/zANPzw 1KFWBXxwac+NV0KwVI2edi8uznHyrgBOOKm0J4vM+xgaZPnFjMrf1AV5tl0NLTy5OnZt nOJeNmAtL4oeXZ8MAsH4tnUXfI1U6ELlWTIRKrg699mGQeRthSWaqg1a5LeYms/aroPL WDQg== X-Gm-Message-State: APjAAAWKUJH4inx/deB0z0wVk5cOL4CS/fgCaDeK0NZnhuY0n3fmr1Eq xxy7lm4U9sOLu0VtrKKbAzNn4w== X-Google-Smtp-Source: APXvYqyqomNKqfUMZH4Z6JC8ERHu8GWvw+Xuh2mo1aivx1OAr/6I5b2SEaBvj1eTo8z2uYwwB5ms2w== X-Received: by 2002:adf:e843:: with SMTP id d3mr46203628wrn.249.1564053145108; Thu, 25 Jul 2019 04:12:25 -0700 (PDT) Return-Path: Received: from [192.168.1.37] (190.red-81-40-121.staticip.rima-tde.net. [81.40.121.190]) by smtp.gmail.com with ESMTPSA id f10sm38005383wrs.22.2019.07.25.04.12.24 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Thu, 25 Jul 2019 04:12:24 -0700 (PDT) Subject: Re: [edk2-devel] [PATCH V2] BaseTools: replace the chinese quotation mark with unicode " To: devel@edk2.groups.io, zhijux.fan@intel.com Cc: Sean Brogan , Bob Feng , Liming Gao References: <20190725030044.17280-1-zhijux.fan@intel.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Openpgp: id=89C1E78F601EE86C867495CBA2A3FD6EDEADC0DE; url=http://pgp.mit.edu/pks/lookup?op=get&search=0xA2A3FD6EDEADC0DE Message-ID: Date: Thu, 25 Jul 2019 13:12:23 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190725030044.17280-1-zhijux.fan@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 7/25/19 5:00 AM, Fan, ZhijuX wrote: > From: Sean Brogan > > BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=2013 > > chinese quotation mark are used in the file > This patch is going to fix that issue. > > Cc: Bob Feng > Cc: Liming Gao > Signed-off-by: Zhiju.Fan > --- > BaseTools/Source/Python/Pkcs7Sign/Readme.md | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/BaseTools/Source/Python/Pkcs7Sign/Readme.md b/BaseTools/Source/Python/Pkcs7Sign/Readme.md > index 5315b7fca4..a7b9caf52c 100644 > --- a/BaseTools/Source/Python/Pkcs7Sign/Readme.md > +++ b/BaseTools/Source/Python/Pkcs7Sign/Readme.md > @@ -10,7 +10,7 @@ NOTE: Below steps are required for Windows. Linux may already have the OPENSSL e > set OPENSSL_HOME=c:\home\openssl\openssl-[version] > set OPENSSL_CONF=%OPENSSL_HOME%\apps\openssl.cnf > > -When a user uses OpenSSL (req or ca command) to generate the certificates, OpenSSL will use the openssl.cnf file as the configuration data (can use “-config path/to/openssl.cnf” to describe the specific config file). > +When a user uses OpenSSL (req or ca command) to generate the certificates, OpenSSL will use the openssl.cnf file as the configuration data (can use "-config path/to/openssl.cnf" to describe the specific config file). > > The user need check the openssl.cnf file, to find your CA path setting, e.g. check if the path exists in [ CA_default ] section. > I wonder, we could add a BaseTool script as pre-commit hook to check this kind of easy typos... Reviewed-by: Philippe Mathieu-Daude