From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 99271740055 for ; Thu, 2 Nov 2023 10:20:34 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=+FpwMq2XKLZPRroybuZs3pxw0qN5Z3Sz6hoJKXQBwsI=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1698920433; v=1; b=MmI4tR5rWqyKL7j1xpy0WwfUaNmqCgVC9JX8MyifyMpw5z+18bfeD9OkN8ZJrd1IsQ15tWtU N4l+WIRyjgzRIrU+Lc6hbkrSFqE3ro9V3pAgBZ9TLImthg4HlVkNJ2qB7J/DTYTqMBWCeY+JU2w 1qhtMa8LfkJx8PkwGXQaYYXo= X-Received: by 127.0.0.2 with SMTP id YC6QYY7687511xWi8c0qCRFC; Thu, 02 Nov 2023 03:20:33 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web11.27402.1698920431171832135 for ; Thu, 02 Nov 2023 03:20:32 -0700 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-510-32uCh1bvOayX7daQfhBglw-1; Thu, 02 Nov 2023 06:20:22 -0400 X-MC-Unique: 32uCh1bvOayX7daQfhBglw-1 X-Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id A804888718E; Thu, 2 Nov 2023 10:20:21 +0000 (UTC) X-Received: from [10.39.195.76] (unknown [10.39.195.76]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6B3F6492BE0; Thu, 2 Nov 2023 10:20:20 +0000 (UTC) Message-ID: Date: Thu, 2 Nov 2023 11:20:19 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH v2] MdeModulePkg/UefiBootManagerLib: Signal ReadyToBoot on platform recovery To: Neal Gompa , devel@edk2.groups.io Cc: Pete Batard , =?UTF-8?Q?Daniel_P_=2e_Berrang=c3=a9?= , Gerd Hoffmann , Samer El-Haj-Mahmoud References: <20231031173700.647004-1-ngompa@fedoraproject.org> From: "Laszlo Ersek" In-Reply-To: <20231031173700.647004-1-ngompa@fedoraproject.org> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.9 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: fUbG7GvKxrT35Gmh4UYurWcBx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=MmI4tR5r; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 10/31/23 18:37, Neal Gompa wrote: > From: Neal Gompa > > Currently, the ReadyToBoot event is only signaled when a formal Boot > Manager option is executed (in BmBoot.c -> EfiBootManagerBoot ()). > > However, the introduction of Platform Recovery in UEFI 2.5 makes it > necessary to signal ReadyToBoot when a Platform Recovery boot loader > runs because otherwise it may lead to the execution of a boot loader > that has similar requirements to a regular one that is not launched > as a Boot Manager option. > > This is especially critical to ensuring that the graphical console > is actually usable during platform recovery, as some platforms do > rely on the ConsolePrefDxe driver, which only performs console > initialization after ReadyToBoot is triggered. > > This patch fixes that behavior by calling EfiSignalEventReadyToBoot () > in EfiBootManagerProcessLoadOption () when invoking platform recovery, > which is the function that sets up the platform recovery boot process. > > The expected behavior has been clarified in the UEFI 2.10 specification > to explicitly indicate this behavior is required for correct operation. > > This is a rebased version of the patch originally written by Pete Batard. > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2831 > > Cc: Pete Batard > Cc: Daniel P. Berrangé > Cc: Gerd Hoffmann > Cc: Samer El-Haj-Mahmoud > Cc: Laszlo Ersek > > Co-authored-by: Pete Batard > Signed-off-by: Neal Gompa > --- > .../Library/UefiBootManagerLib/BmLoadOption.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/MdeModulePkg/Library/UefiBootManagerLib/BmLoadOption.c b/MdeModulePkg/Library/UefiBootManagerLib/BmLoadOption.c > index 2087f0b91d..83a2f893e4 100644 > --- a/MdeModulePkg/Library/UefiBootManagerLib/BmLoadOption.c > +++ b/MdeModulePkg/Library/UefiBootManagerLib/BmLoadOption.c > @@ -1416,6 +1416,17 @@ EfiBootManagerProcessLoadOption ( > return EFI_SUCCESS; > } > > + if (LoadOption->OptionType == LoadOptionTypePlatformRecovery) { > + // > + // Signal the EVT_SIGNAL_READY_TO_BOOT event when we are about to load and execute the boot option. > + // > + EfiSignalEventReadyToBoot (); > + // > + // Report Status Code to indicate ReadyToBoot was signaled > + // > + REPORT_STATUS_CODE (EFI_PROGRESS_CODE, (EFI_SOFTWARE_DXE_BS_DRIVER | EFI_SW_DXE_BS_PC_READY_TO_BOOT_EVENT)); > + } > + > // > // Load and start the load option. > // Reviewed-by: Laszlo Ersek -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110518): https://edk2.groups.io/g/devel/message/110518 Mute This Topic: https://groups.io/mt/102302654/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-