From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id D035D7803CE for ; Mon, 26 Feb 2024 16:47:04 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=6LG5Qof9+6b4IrcyAq21CmvIzqU3jXjrvDh4mpgQ/EU=; c=relaxed/simple; d=groups.io; h=DKIM-Filter:Message-ID:Date:MIME-Version:User-Agent:Subject:From:To:Cc:Reply-To:References:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1708966023; v=1; b=tztxPEyfLiw4JP6OiOFOLKhn6gmsyt8H+tewnRNWFOT3ORlbZWb5Izoplt1wJPvk3/L+j9Bu bOX6jgQMh8xWprbRJkGBB6ofpze9hCaH4t1uXIQgtKHlT10UjisWEwEnXpz+Qc+Lpx5khGp1ogJ /oPN4mX0kMsMsmRSuriZyPRw= X-Received: by 127.0.0.2 with SMTP id x0fVYY7687511xjVF7oSlcRu; Mon, 26 Feb 2024 08:47:03 -0800 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web10.29981.1708966023030550324 for ; Mon, 26 Feb 2024 08:47:03 -0800 X-Received: from [10.137.194.171] (unknown [131.107.160.171]) by linux.microsoft.com (Postfix) with ESMTPSA id 7D74A20B74C0; Mon, 26 Feb 2024 08:47:02 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 7D74A20B74C0 Message-ID: Date: Mon, 26 Feb 2024 08:47:02 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel][PATCH v2 1/1] MdeModulePkg: Remove ArmPkg Dependency From: "Oliver Smith-Denny" To: devel@edk2.groups.io, Liming Gao Cc: Leif Lindholm , Ard Biesheuvel , Sami Mujawar , Liming Gao , Sean Brogan , Ard Biesheuvel Reply-To: devel@edk2.groups.io,osde@linux.microsoft.com References: <17B3DE09466BEB48.21218@groups.io> In-Reply-To: <17B3DE09466BEB48.21218@groups.io> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: RCFaQuiVWIvr9tJd4SXdUpZrx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=tztxPEyf; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=linux.microsoft.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Hi Liming, Now that the stable tag is completed, can you review this MdeModulePkg patch? Thanks, Oliver On 2/14/2024 3:20 PM, Oliver Smith-Denny wrote: > With commita21a994f55e53325d3e060c435ca3a87fd7c2c79 > MdeModulePkg no longer has a hard dependency on ArmMmuLib and therefore > ArmLib. This is the final dependency on ArmPkg, so remove the > unused libs and drop the allowed dependency on ArmPkg as > MdeModulePkg should not depend on it as this is a circular > dependency. >=20 > Github PR: https://github.com/tianocore/edk2/pull/5361 > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3651 >=20 > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Cc: Sami Mujawar > Cc: Liming Gao >=20 > Signed-off-by: Oliver Smith-Denny > Reviewed-by: Sean Brogan > Acked-by: Ard Biesheuvel > --- >=20 > Notes: > v2: > - Add bugzilla link to commit message > - Add Sean's RB and Ard's ack >=20 > MdeModulePkg/MdeModulePkg.dsc | 2 -- > MdeModulePkg/MdeModulePkg.ci.yaml | 3 +-- > 2 files changed, 1 insertion(+), 4 deletions(-) >=20 > diff --git a/MdeModulePkg/MdeModulePkg.dsc b/MdeModulePkg/MdeModulePkg.ds= c > index 6b3052ff4614..c0f1df3bfbca 100644 > --- a/MdeModulePkg/MdeModulePkg.dsc > +++ b/MdeModulePkg/MdeModulePkg.dsc > @@ -179,8 +179,6 @@ [LibraryClasses.common.MM_STANDALONE] > MemLib|StandaloneMmPkg/Library/StandaloneMmMemLib/StandaloneMmMemLib.= inf > =20 > [LibraryClasses.ARM, LibraryClasses.AARCH64] > - ArmLib|ArmPkg/Library/ArmLib/ArmBaseLib.inf > - ArmMmuLib|ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf > LockBoxLib|MdeModulePkg/Library/LockBoxNullLib/LockBoxNullLib.inf > =20 > # > diff --git a/MdeModulePkg/MdeModulePkg.ci.yaml b/MdeModulePkg/MdeModulePk= g.ci.yaml > index 669f54e33c0d..a3de60a12c9e 100644 > --- a/MdeModulePkg/MdeModulePkg.ci.yaml > +++ b/MdeModulePkg/MdeModulePkg.ci.yaml > @@ -53,8 +53,7 @@ > "AcceptableDependencies": [ > "MdePkg/MdePkg.dec", > "MdeModulePkg/MdeModulePkg.dec", > - "StandaloneMmPkg/StandaloneMmPkg.dec", > - "ArmPkg/ArmPkg.dec" # this should be fixed by promoting an = abstraction > + "StandaloneMmPkg/StandaloneMmPkg.dec" > ], > # For host based unit tests > "AcceptableDependencies-HOST_APPLICATION":[ -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115976): https://edk2.groups.io/g/devel/message/115976 Mute This Topic: https://groups.io/mt/104363773/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-