public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Kun Qin" <kuqin12@gmail.com>
To: devel@edk2.groups.io, Abner Chang <abner.chang@hpe.com>,
	Daniel Schaefer <daniel.schaefer@hpe.com>,
	Gilbert Chen <gilbert.chen@hpe.com>
Subject: Re: [edk2-devel] [edk2-platforms][PATCH v4 2/6] U5SeriesPkg: Platform Build: Resolving newly introduced dependency
Date: Wed, 10 Aug 2022 15:52:10 -0700	[thread overview]
Message-ID: <ede73db3-ef2e-40b4-ab6b-b4219b156501@gmail.com> (raw)
In-Reply-To: <17084BB84B411F73.26297@groups.io>

Hi U5SeriesPkg maintainers,

Can you please review the patch below and let me know if any feedback?
Platform build could be broken without this change.

Any input is appreciated.

Regards,
Kun

On 8/4/2022 5:35 PM, Kun Qin via groups.io wrote:
> The new changes in SecureBootVariableLib brought in a new dependency
> of PlatformPKProtectionLib.
>
> This change added the new library instance from SecurityPkg to resolve
> U5SeriesPkg platforms build.
>
> Cc: Abner Chang <abner.chang@hpe.com>
> Cc: Gilbert Chen <gilbert.chen@hpe.com>
> Cc: Daniel Schaefer <daniel.schaefer@hpe.com>
>
> Signed-off-by: Kun Qin <kuqin12@gmail.com>
> ---
>
> Notes:
>      v2:
>      - No review, no change
>      
>      v4:
>      - Updated commit title.
>
>   Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc           | 1 +
>   Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc | 1 +
>   2 files changed, 2 insertions(+)
>
> diff --git a/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc b/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc
> index 7b36b2c885e0..fc1ed012a541 100644
> --- a/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc
> +++ b/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc
> @@ -127,6 +127,7 @@ [LibraryClasses]
>     AuthVariableLib|SecurityPkg/Library/AuthVariableLib/AuthVariableLib.inf
>
>     SecureBootVariableLib|SecurityPkg/Library/SecureBootVariableLib/SecureBootVariableLib.inf
>
>     SecureBootVariableProvisionLib|SecurityPkg/Library/SecureBootVariableProvisionLib/SecureBootVariableProvisionLib.inf
>
> +  PlatformPKProtectionLib|SecurityPkg/Library/PlatformPKProtectionLibVarPolicy/PlatformPKProtectionLibVarPolicy.inf
>
>   !else
>
>     TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf
>
>     AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf
>
> diff --git a/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc b/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc
> index 26895a75ec2f..e59955d09452 100644
> --- a/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc
> +++ b/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc
> @@ -127,6 +127,7 @@ [LibraryClasses]
>     AuthVariableLib|SecurityPkg/Library/AuthVariableLib/AuthVariableLib.inf
>
>     SecureBootVariableLib|SecurityPkg/Library/SecureBootVariableLib/SecureBootVariableLib.inf
>
>     SecureBootVariableProvisionLib|SecurityPkg/Library/SecureBootVariableProvisionLib/SecureBootVariableProvisionLib.inf
>
> +  PlatformPKProtectionLib|SecurityPkg/Library/PlatformPKProtectionLibVarPolicy/PlatformPKProtectionLibVarPolicy.inf
>
>   !else
>
>     TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf
>
>     AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf
>

  parent reply	other threads:[~2022-08-10 22:52 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-05  0:35 [edk2-platforms][PATCH v4 0/6] Resolving SecureBootVariableLib dependency Kun Qin
2022-08-05  0:35 ` [edk2-platforms][PATCH v4 1/6] RaspberryPi: Platform Build: Resolving newly introduced dependency Kun Qin
2022-08-05  0:35 ` [edk2-platforms][PATCH v4 2/6] U5SeriesPkg: " Kun Qin
2022-08-05  0:35 ` [edk2-platforms][PATCH v4 3/6] VExpressPkg: " Kun Qin
2022-08-05  0:35 ` [edk2-platforms][PATCH v4 4/6] Socionext: " Kun Qin
2022-08-05  0:35 ` [edk2-platforms][PATCH v4 5/6] AmpereAltraPkg: " Kun Qin
2022-08-05  0:35 ` [edk2-platforms][PATCH v4 6/6] PhytiumCommonPkg: " Kun Qin
     [not found] ` <17084BB84B411F73.26297@groups.io>
2022-08-10 22:52   ` Kun Qin [this message]
2022-08-11  3:02     ` [edk2-devel] [edk2-platforms][PATCH v4 2/6] U5SeriesPkg: " Daniel Schaefer
2022-08-11  4:02       ` Kun Qin
     [not found] ` <17084BB893E9A081.26236@groups.io>
2022-08-10 22:54   ` [edk2-devel] [edk2-platforms][PATCH v4 4/6] Socionext: " Kun Qin
2022-08-15 14:18     ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ede73db3-ef2e-40b4-ab6b-b4219b156501@gmail.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox