From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by mx.groups.io with SMTP id smtpd.web09.157.1660171931991231343 for ; Wed, 10 Aug 2022 15:52:12 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmail.com header.s=20210112 header.b=T1uWJx8N; spf=pass (domain: gmail.com, ip: 209.85.214.173, mailfrom: kuqin12@gmail.com) Received: by mail-pl1-f173.google.com with SMTP id d16so15483805pll.11 for ; Wed, 10 Aug 2022 15:52:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=uANpzez7vHtxi2rWgv/+TnH9wbLJenog+Hi8jpPCQOE=; b=T1uWJx8N3lZ9c99XqrhIH1K8F9i3TaxNhAsVSHzjMTEfmtQitFHTPtM+0iAch0m+5f 5Fowiy2Ckg6Sp4bbAPFc754YqpJDGtbspXic1PT7g2y0ln4+XmYb3FWnpda04mid8A5z 8UAWsmroYrn+cqMp5qlHN7u43bWpFmFR/aLiqWSHKZGTyTe2SZlZm9uElIiB0txJ73NS K78oImTs/FDmO2gXlmqhe+v3BzIkS+ljlrtLbbLCjEbeQ8hWlPz4PZQk7nMZVCR9gT6x y5Wo9qP4WB+2zDM19bfhMLWBMRkSguVCaEVlStyWm1OIgzvMmVAo5B71TwmIlPP20mWF SWKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=uANpzez7vHtxi2rWgv/+TnH9wbLJenog+Hi8jpPCQOE=; b=N3HGT2EKVTeBi3ESGEcS9m/h+FapoSGqezfJIoEcAHcIb8Qx3D5OPlZsuM08vC8he6 xcomI7dEbNyPYqQkTrpr0cnjvpmpn7PLJBfXaHXNgpRmwdS+ik6vPmlEDU+BoJx7iiso nQB9g7qKfSSOzjUM6JitQFgRU66NagVq0oPFfDZpwcHmMRMygKxfxWd5o3AfzE2dLxfh ABTk/xqP1krPTFWWfTTEzuKRYgGr8QEcxya5+6Z2v+GvVtnHnH4Q9P4bsb0Zd6YP6u/n ZnF60mwu+Yzv+ZaA3AeLg5SiizkNRJxezwGs6xp6W2wBuH4Ud9l1viBgZoXNo/xZeh5U WwqA== X-Gm-Message-State: ACgBeo1pduA+pf3lnWZWq0FoFtcg/HNmDVlo6xiQc1QIyhH2yVNi5dCN sBWQPAg5HQC8aAofGZJFuAanimw5z/E= X-Google-Smtp-Source: AA6agR7rWBmeSLWv87D0HN9pcHUup5N78zJo6+a55Mm70FHRE6bA+ZpgHmqh1tvKcQkE8yZgB3dzSQ== X-Received: by 2002:a17:90a:e2cc:b0:1f3:1151:e0ff with SMTP id fr12-20020a17090ae2cc00b001f31151e0ffmr5977288pjb.50.1660171931296; Wed, 10 Aug 2022 15:52:11 -0700 (PDT) Return-Path: Received: from ?IPV6:2001:4898:d8:33:352e:f1a8:aef2:7dc4? ([2001:4898:80e8:38:b518:f1a8:aef2:7dc4]) by smtp.gmail.com with ESMTPSA id j13-20020a170902da8d00b001709aea1516sm8615804plx.276.2022.08.10.15.52.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Aug 2022 15:52:11 -0700 (PDT) Message-ID: Date: Wed, 10 Aug 2022 15:52:10 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [edk2-devel] [edk2-platforms][PATCH v4 2/6] U5SeriesPkg: Platform Build: Resolving newly introduced dependency To: devel@edk2.groups.io, Abner Chang , Daniel Schaefer , Gilbert Chen References: <20220805003512.1478-1-kuqin12@gmail.com> <17084BB84B411F73.26297@groups.io> From: "Kun Qin" In-Reply-To: <17084BB84B411F73.26297@groups.io> Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi U5SeriesPkg maintainers, Can you please review the patch below and let me know if any feedback? Platform build could be broken without this change. Any input is appreciated. Regards, Kun On 8/4/2022 5:35 PM, Kun Qin via groups.io wrote: > The new changes in SecureBootVariableLib brought in a new dependency > of PlatformPKProtectionLib. > > This change added the new library instance from SecurityPkg to resolve > U5SeriesPkg platforms build. > > Cc: Abner Chang > Cc: Gilbert Chen > Cc: Daniel Schaefer > > Signed-off-by: Kun Qin > --- > > Notes: > v2: > - No review, no change > > v4: > - Updated commit title. > > Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc | 1 + > Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc b/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc > index 7b36b2c885e0..fc1ed012a541 100644 > --- a/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc > +++ b/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc > @@ -127,6 +127,7 @@ [LibraryClasses] > AuthVariableLib|SecurityPkg/Library/AuthVariableLib/AuthVariableLib.inf > > SecureBootVariableLib|SecurityPkg/Library/SecureBootVariableLib/SecureBootVariableLib.inf > > SecureBootVariableProvisionLib|SecurityPkg/Library/SecureBootVariableProvisionLib/SecureBootVariableProvisionLib.inf > > + PlatformPKProtectionLib|SecurityPkg/Library/PlatformPKProtectionLibVarPolicy/PlatformPKProtectionLibVarPolicy.inf > > !else > > TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf > > AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf > > diff --git a/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc b/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc > index 26895a75ec2f..e59955d09452 100644 > --- a/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc > +++ b/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc > @@ -127,6 +127,7 @@ [LibraryClasses] > AuthVariableLib|SecurityPkg/Library/AuthVariableLib/AuthVariableLib.inf > > SecureBootVariableLib|SecurityPkg/Library/SecureBootVariableLib/SecureBootVariableLib.inf > > SecureBootVariableProvisionLib|SecurityPkg/Library/SecureBootVariableProvisionLib/SecureBootVariableProvisionLib.inf > > + PlatformPKProtectionLib|SecurityPkg/Library/PlatformPKProtectionLibVarPolicy/PlatformPKProtectionLibVarPolicy.inf > > !else > > TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf > > AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf >