From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by mx.groups.io with SMTP id smtpd.web11.2576.1607393501871514917 for ; Mon, 07 Dec 2020 18:11:42 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@ibm.com header.s=pp1 header.b=RojLcweL; spf=pass (domain: linux.ibm.com, ip: 148.163.156.1, mailfrom: jejb@linux.ibm.com) Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 0B822Bul020992; Mon, 7 Dec 2020 21:11:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : subject : from : reply-to : to : cc : date : in-reply-to : references : content-type : mime-version : content-transfer-encoding; s=pp1; bh=av/m/J+o0+fix/R0LtEwL9sIH5iAc5nfnBUJhGVKm6Y=; b=RojLcweLzYn/sQLEu1oXlK/1jlTJEQO1xx2GZGuhHDHLy7puHTCgALCrdmz96wgzm9Ho dWwmmm5scQwpzMVp+NfWSGGnd/cpmDWbdZ07CjNcXoXn7W/sDBluNy6dgcfO6lQGeyCm kvTgIVJAuJl6jvl9Ry02D/UUwsZMtV4IZHbouKVx65jDns5UKWdTpt4ZUBAUsFjOakTG /8gjxG0JfvXI+QkWg+ZFnwlQmSzHjWydG49WgjXI9jODPGE3iyK6ZCIBL7rjs9BCqEqP yK3EJYnJ60u342pLW0lHSzXEjNmaPwR1XtD0C5Ltf0w1yMWyNxHOpuw0/Pkm4rbwFUrl dA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 359s42vdhe-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 07 Dec 2020 21:11:32 -0500 Received: from m0098399.ppops.net (m0098399.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 0B823F8N023893; Mon, 7 Dec 2020 21:11:32 -0500 Received: from ppma01wdc.us.ibm.com (fd.55.37a9.ip4.static.sl-reverse.com [169.55.85.253]) by mx0a-001b2d01.pphosted.com with ESMTP id 359s42vdgt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 07 Dec 2020 21:11:32 -0500 Received: from pps.filterd (ppma01wdc.us.ibm.com [127.0.0.1]) by ppma01wdc.us.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 0B82A25p031531; Tue, 8 Dec 2020 02:11:31 GMT Received: from b03cxnp07029.gho.boulder.ibm.com (b03cxnp07029.gho.boulder.ibm.com [9.17.130.16]) by ppma01wdc.us.ibm.com with ESMTP id 3581u8yuah-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 08 Dec 2020 02:11:31 +0000 Received: from b03ledav004.gho.boulder.ibm.com (b03ledav004.gho.boulder.ibm.com [9.17.130.235]) by b03cxnp07029.gho.boulder.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 0B82AFJf25297228 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 8 Dec 2020 02:10:15 GMT Received: from b03ledav004.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1189E78063; Tue, 8 Dec 2020 02:10:15 +0000 (GMT) Received: from b03ledav004.gho.boulder.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9A5F67805F; Tue, 8 Dec 2020 02:10:13 +0000 (GMT) Received: from jarvis.int.hansenpartnership.com (unknown [9.85.183.17]) by b03ledav004.gho.boulder.ibm.com (Postfix) with ESMTP; Tue, 8 Dec 2020 02:10:13 +0000 (GMT) Message-ID: Subject: Re: [edk2-devel] [PATCH 1/2] OvmfPkg: start using the ECC plugin exception list From: "James Bottomley" Reply-To: jejb@linux.ibm.com To: Laszlo Ersek , Ard Biesheuvel , Sean Brogan , devel@edk2.groups.io Cc: Jordan Justen , Philippe =?ISO-8859-1?Q?Mathieu-Daud=E9?= , Tom Lendacky , "Leif Lindholm (Nuvia address)" Date: Mon, 07 Dec 2020 18:10:12 -0800 In-Reply-To: <3b931320-5afb-0dae-e8d2-f2e56be88177@redhat.com> References: <20201204032116.31321-1-lersek@redhat.com> <20201204032116.31321-2-lersek@redhat.com> <7c57b6dc-de1a-8f2b-9b40-c1faf9b46bfe@redhat.com> <6989494d-4dca-6a92-d748-9c413206e781@arm.com> <3b931320-5afb-0dae-e8d2-f2e56be88177@redhat.com> User-Agent: Evolution 3.34.4 MIME-Version: 1.0 X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.343,18.0.737 definitions=2020-12-07_19:2020-12-04,2020-12-07 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 malwarescore=0 impostorscore=0 mlxlogscore=999 lowpriorityscore=0 phishscore=0 priorityscore=1501 adultscore=0 mlxscore=0 bulkscore=0 suspectscore=0 clxscore=1011 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2012080006 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit On Tue, 2020-12-08 at 02:56 +0100, Laszlo Ersek wrote: > On 12/04/20 17:05, Ard Biesheuvel wrote: [...] > > Could we perhaps use a special tag? Or simply overrule ECC if the > > patch in question has a Reviewed-by from the maintainer (*not* from > > a reviewer) of the package in question? > > > > As for the 'risky' - I agree that it is likely to misunderstood, so > > better find a different word to describe this. > > > > Yeah, let me drop this one patch and see if we can disable ECC > globally, or implement a github label to disable it. > > James, is it OK if we delay merging of your v3 series a bit? Sure, there's nothing tremendously urgent. I'm about to post the qemu enabling patch, but as long as the GUIDs don't change (or the format of the reset block) a delay shouldn't matter. James