From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.81]) by mx.groups.io with SMTP id smtpd.web12.5288.1574421905572035943 for ; Fri, 22 Nov 2019 03:25:06 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=K0+1dDbh; spf=pass (domain: redhat.com, ip: 207.211.31.81, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574421904; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jLKxixEIV9w8umclHhXPIKyhKzR71TFgpvcc+r8ucWc=; b=K0+1dDbhCNpaCSbqvO/4c6NAyYB/ga6YdF7W4kxKcpy3wMO8nOe1NctrGF1lcSZ1d+LLdQ PYhygIRxVy/W0f61MSpKqFV8Wa4IRsWZUe05lczx3rjYnDUxPMVSK+S/2EZHLkMrCg5gGX npQRNQ9H47LLyMrxJ13s/8eGb+U6yZ0= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-29-6dj52wXPNIeLI9eSXfqV5g-1; Fri, 22 Nov 2019 06:25:03 -0500 Received: by mail-wr1-f72.google.com with SMTP id k15so3690717wrp.22 for ; Fri, 22 Nov 2019 03:25:02 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=UooRaOtgohDMWG2SLq3XnbeIbUruX4J/r65N3JkAZUE=; b=MzSaB7p7OV6L+dS6lb3L+b4b8pAa0Oz1KMg5Ma72VqZeDwS0IJIW7HUJSkq2ibCLXV 6W9RbpFCh9jOHV8/m0REYQdRWLzgVvI8z6xwj7yuoxeZ4qHofD8yURdFVoOZRTsT93X+ DdTqrRmgpaBxb4xEtigdUu69wtvDSfbdTFT9O1W55ZbK3DGM56+WI8NDxTdPK3Kqz8+o gzcmHt5Gk4+6MP5Ro9YufWqM+fuw2LSA2b+P/bfcJ3BlOjtlOS+KYSLjo+x2sQdT1FrC 1ZFV3kuhXn+vsLzZQtWF8CjZgleDhLRdtbpKIE7qCmLEtX8RrqrTlHvp39AIA7e4Q2pO mGCA== X-Gm-Message-State: APjAAAX8YIH4mUhFLc8THEDqm6YPw949MQdB7X0hnCk9T2X9QaBpI3Bh 5xoT6xCJjAXk8N7yWET//J8A8nOAzPXpJNFH1U4BUZdp3PukKwe39/NMaQV8ToIwloOyq7lnUng LgUa13kPQVk4uGg== X-Received: by 2002:adf:eecc:: with SMTP id a12mr6395458wrp.363.1574421902143; Fri, 22 Nov 2019 03:25:02 -0800 (PST) X-Google-Smtp-Source: APXvYqxJx8j7ANc7vx7mzslVyfyv2nYECCw6vfHzlsVX0FFnrMx2WsyOwD88Hg7Q8Pl0JW1F5uMrtw== X-Received: by 2002:adf:eecc:: with SMTP id a12mr6395440wrp.363.1574421901982; Fri, 22 Nov 2019 03:25:01 -0800 (PST) Return-Path: Received: from [192.168.1.35] (131.red-88-21-102.staticip.rima-tde.net. [88.21.102.131]) by smtp.gmail.com with ESMTPSA id d9sm6970873wrj.10.2019.11.22.03.25.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Nov 2019 03:25:01 -0800 (PST) Subject: Re: [edk2-devel] [PATCH V2 2/2] MdeModulePkg/Variable: Initialize local variable "RtPtrTrack" To: devel@edk2.groups.io, michael.a.kubacki@intel.com Cc: Liming Gao , Michael D Kinney , Jian J Wang , Hao A Wu References: <20191121230236.29668-1-michael.a.kubacki@intel.com> <20191121230236.29668-3-michael.a.kubacki@intel.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: Date: Fri, 22 Nov 2019 12:24:59 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <20191121230236.29668-3-michael.a.kubacki@intel.com> X-MC-Unique: 6dj52wXPNIeLI9eSXfqV5g-1 X-Mimecast-Spam-Score: 0 Content-Language: en-US Content-Type: text/plain; charset=WINDOWS-1252; format=flowed Content-Transfer-Encoding: quoted-printable On 11/22/19 12:02 AM, Kubacki, Michael A wrote: > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D2364 >=20 > Fixes a new build warning in VS2012 introduced in f8ff4cca7c. >=20 > This patch initializes the local variable "RtPtrTrack" in > FindVariableInRuntimeCache (). >=20 > This ensures the pointers in the structure are initialized > in the case no variable stores exist in the list of variable > stores. >=20 > Cc: Liming Gao > Cc: Michael D Kinney > Cc: Jian J Wang > Cc: Hao A Wu > Signed-off-by: Michael Kubacki > Reviewed-by: Liming Gao > Reviewed-by: Jian J Wang > --- > MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDxe.c | 2 = ++ > 1 file changed, 2 insertions(+) >=20 > diff --git a/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntim= eDxe.c b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDxe.c > index d525998ae3..2cf0ed32ae 100644 > --- a/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDxe.c > +++ b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariableSmmRuntimeDxe.c > @@ -590,6 +590,8 @@ FindVariableInRuntimeCache ( > return EFI_INVALID_PARAMETER; > } > =20 > + ZeroMem (&RtPtrTrack, sizeof (RtPtrTrack)); > + > // > // The UEFI specification restricts Runtime Services callers from inv= oking the same or certain other Runtime Service > // functions prior to completion and return from a previous Runtime S= ervice call. These restrictions prevent >=20 Reviewed-by: Philippe Mathieu-Daude