From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by mx.groups.io with SMTP id smtpd.web10.8898.1657812626202988303
 for <devel@edk2.groups.io>;
 Thu, 14 Jul 2022 08:30:26 -0700
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: jeremy.linton@arm.com)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
	by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 051E01D13;
	Thu, 14 Jul 2022 08:30:26 -0700 (PDT)
Received: from [192.168.122.164] (U203867.austin.arm.com [10.118.30.29])
	by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 78B353F70D;
	Thu, 14 Jul 2022 08:30:25 -0700 (PDT)
Message-ID: <ee5f5455-0aad-ce0c-d5da-86fbdd3b8fec@arm.com>
Date: Thu, 14 Jul 2022 10:30:23 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [edk2-platforms][PATCH v1 1/7] RaspberryPi: Pipeline: Resolving newly introduced dependency
To: Kun Qin <kuqin12@gmail.com>, devel@edk2.groups.io
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>,
 Leif Lindholm <quic_llindhol@quicinc.com>
References: <20220708210258.1250-1-kuqin12@gmail.com>
 <20220708210258.1250-2-kuqin12@gmail.com>
From: "Jeremy Linton" <jeremy.linton@arm.com>
In-Reply-To: <20220708210258.1250-2-kuqin12@gmail.com>
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi,

On 7/8/22 16:02, Kun Qin wrote:
> The new changes in SecureBootVariableLib brought in a new dependency
> of PlatformPKProtectionLib.
> 
> This change added the new library instance from SecurityPkg to resolve
> RaspberryPi platforms build.

This applies cleanly, and fixes the build break when the rpis are built 
against the latest edk2 branch.

Thanks,

Reviewed-by: Jeremy Linton <jeremy.linton@arm.com>


> 
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Jeremy Linton <jeremy.linton@arm.com>
> 
> Signed-off-by: Kun Qin <kuqin12@gmail.com>
> ---
>   Platform/RaspberryPi/RPi3/RPi3.dsc | 1 +
>   Platform/RaspberryPi/RPi4/RPi4.dsc | 1 +
>   2 files changed, 2 insertions(+)
> 
> diff --git a/Platform/RaspberryPi/RPi3/RPi3.dsc b/Platform/RaspberryPi/RPi3/RPi3.dsc
> index 0eed03c097f8..4e7377a00036 100644
> --- a/Platform/RaspberryPi/RPi3/RPi3.dsc
> +++ b/Platform/RaspberryPi/RPi3/RPi3.dsc
> @@ -169,6 +169,7 @@ [LibraryClasses.common]
>     PlatformSecureLib|OvmfPkg/Library/PlatformSecureLib/PlatformSecureLib.inf
>     SecureBootVariableLib|SecurityPkg/Library/SecureBootVariableLib/SecureBootVariableLib.inf
>     SecureBootVariableProvisionLib|SecurityPkg/Library/SecureBootVariableProvisionLib/SecureBootVariableProvisionLib.inf
> +  PlatformPKProtectionLib|SecurityPkg/Library/PlatformPKProtectionLibVarPolicy/PlatformPKProtectionLibVarPolicy.inf
>   !else
>     TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf
>     AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf
> diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc b/Platform/RaspberryPi/RPi4/RPi4.dsc
> index eabddd7382cf..8ba0ca61851e 100644
> --- a/Platform/RaspberryPi/RPi4/RPi4.dsc
> +++ b/Platform/RaspberryPi/RPi4/RPi4.dsc
> @@ -166,6 +166,7 @@ [LibraryClasses.common]
>     AuthVariableLib|SecurityPkg/Library/AuthVariableLib/AuthVariableLib.inf
>     SecureBootVariableLib|SecurityPkg/Library/SecureBootVariableLib/SecureBootVariableLib.inf
>     SecureBootVariableProvisionLib|SecurityPkg/Library/SecureBootVariableProvisionLib/SecureBootVariableProvisionLib.inf
> +  PlatformPKProtectionLib|SecurityPkg/Library/PlatformPKProtectionLibVarPolicy/PlatformPKProtectionLibVarPolicy.inf
>   
>     # re-use the UserPhysicalPresent() dummy implementation from the ovmf tree
>     PlatformSecureLib|OvmfPkg/Library/PlatformSecureLib/PlatformSecureLib.inf