Re: [edk2-devel] [PATCH edk2-platforms v4 4/4] SbsaQemu: disable XHCI in DSDT if not present

["Marcin Juszkiewicz" <marcin.juszkiewicz@linaro.org>]

W dniu 18.10.2023 o 13:23, Pedro Falcato pisze:
> On Wed, Oct 18, 2023 at 12:16 PM Marcin Juszkiewicz
> <marcin.juszkiewicz@linaro.org> wrote:
>>
>> W dniu 18.10.2023 o 12:32, Nhi Pham pisze:
>>> Acked-by: Nhi Pham <nhi@os.amperecomputing.com>
>>>
>>> Nit: I think you want to run uncrustify for Patch 3 as well :)
>>
>> Done, will check other changes too.
>>
>> I have a strong feeling that Qemu part of EDK2 needs a bit
>> bigger patch when it comes to formatting:
>>
>>    Platform/Qemu/QemuOpenBoardPkg/Include/Library/QemuOpenFwCfgLib.h                 |   7 +-
>>    Platform/Qemu/QemuOpenBoardPkg/Library/PeiReportFvLib/PeiReportFvLib.c            |  33 +-
>>    Platform/Qemu/QemuOpenBoardPkg/Library/PlatformSecLib/Ia32/SecEntry.nasm          |  99 ++-
>>    Platform/Qemu/QemuOpenBoardPkg/PlatformInitPei/Memory.c                           | 108 +--
>>    Platform/Qemu/QemuOpenBoardPkg/PlatformInitPei/Pcie.c                             |  30 +-
>>    Platform/Qemu/QemuOpenBoardPkg/README.md                                          |  43 +-
> 
> Something must be wrong with your config because QemuOpenBoardPkg is
> and was, AFAIK, all formatted using uncrustify. And if I run it
> locally, it seems to agree with me.

EDK2 expects some random version of uncrustify.

It is not part of BaseTools so I use upstream version. And it looks like 
they format in different way using the same config file.




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109731): https://edk2.groups.io/g/devel/message/109731
Mute This Topic: https://groups.io/mt/102035954/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-