From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 364367803CE for ; Wed, 18 Oct 2023 11:28:53 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=cjMHup6cHNUDYQ0tenOpUcjX7UIe2LHAp9BeCoiFW+E=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:Organization:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1697628531; v=1; b=HpVRofWYONnq+Dky+kCMMdGQmgx23hxYFhV0lzif27LEvJGv3t9xtzCwaMpJLdQoxZjshVvD nsVVCk+UTrGf2vsBhdeiAWe5m53FP6gB9zm7bQEX4BhPUXSP7bBVEUeNbtr2dIy/EWY2dInkyZJ Yj3bHIwJrjzKLm2M5z+7Yqo4= X-Received: by 127.0.0.2 with SMTP id M0ELYY7687511x5Tq3eg34vV; Wed, 18 Oct 2023 04:28:51 -0700 X-Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) by mx.groups.io with SMTP id smtpd.web11.278858.1697628530958936746 for ; Wed, 18 Oct 2023 04:28:51 -0700 X-Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-53e2308198eso10615690a12.1 for ; Wed, 18 Oct 2023 04:28:50 -0700 (PDT) X-Gm-Message-State: SCDpHa7j8EdVxrVuLXPyJlDLx7686176AA= X-Google-Smtp-Source: AGHT+IFhl69bnzkSNtPxc7ykiQ+bXzGdYBLDV787PadhaLmrHFcM803aNjDQTHIour0+VpG8aSKS0Q== X-Received: by 2002:a50:d481:0:b0:531:a63:cf25 with SMTP id s1-20020a50d481000000b005310a63cf25mr3906291edi.33.1697628529449; Wed, 18 Oct 2023 04:28:49 -0700 (PDT) X-Received: from [192.168.200.206] (83.11.27.172.ipv4.supernova.orange.pl. [83.11.27.172]) by smtp.gmail.com with ESMTPSA id s26-20020a056402037a00b00532eba07773sm2641742edw.25.2023.10.18.04.28.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Oct 2023 04:28:49 -0700 (PDT) Message-ID: Date: Wed, 18 Oct 2023 13:28:47 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH edk2-platforms v4 4/4] SbsaQemu: disable XHCI in DSDT if not present To: Pedro Falcato , devel@edk2.groups.io Cc: Nhi Pham , Leif Lindholm , Ard Biesheuvel , Jeremy Linton , Chuong Tran , Rebecca Cran References: <20231018-ehci-xhci-fix-v4-0-aa53138997a5@linaro.org> <20231018-ehci-xhci-fix-v4-4-aa53138997a5@linaro.org> <75b23ede-8f50-4d44-a786-fb04cd4abd00@os.amperecomputing.com> <2d881cf4-d12b-4ddb-8a5c-deb5f070c1cc@linaro.org> From: "Marcin Juszkiewicz" Organization: Linaro In-Reply-To: Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,marcin.juszkiewicz@linaro.org List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Language: pl-PL, en-GB, en-HK Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=HpVRofWY; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=linaro.org (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io W dniu 18.10.2023 o 13:23, Pedro Falcato pisze: > On Wed, Oct 18, 2023 at 12:16 PM Marcin Juszkiewicz > wrote: >> >> W dniu 18.10.2023 o 12:32, Nhi Pham pisze: >>> Acked-by: Nhi Pham >>> >>> Nit: I think you want to run uncrustify for Patch 3 as well :) >> >> Done, will check other changes too. >> >> I have a strong feeling that Qemu part of EDK2 needs a bit >> bigger patch when it comes to formatting: >> >> Platform/Qemu/QemuOpenBoardPkg/Include/Library/QemuOpenFwCfgLib.h | 7 +- >> Platform/Qemu/QemuOpenBoardPkg/Library/PeiReportFvLib/PeiReportFvLib.c | 33 +- >> Platform/Qemu/QemuOpenBoardPkg/Library/PlatformSecLib/Ia32/SecEntry.nasm | 99 ++- >> Platform/Qemu/QemuOpenBoardPkg/PlatformInitPei/Memory.c | 108 +-- >> Platform/Qemu/QemuOpenBoardPkg/PlatformInitPei/Pcie.c | 30 +- >> Platform/Qemu/QemuOpenBoardPkg/README.md | 43 +- > > Something must be wrong with your config because QemuOpenBoardPkg is > and was, AFAIK, all formatted using uncrustify. And if I run it > locally, it seems to agree with me. EDK2 expects some random version of uncrustify. It is not part of BaseTools so I use upstream version. And it looks like they format in different way using the same config file. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109731): https://edk2.groups.io/g/devel/message/109731 Mute This Topic: https://groups.io/mt/102035954/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-