* [PATCH v4 1/6] Platform/Intel/MinPlatformPkg: Fix build error
2020-07-20 8:54 [PATCH v4 0/6] *** SUBJECT HERE *** IanX Kuo
@ 2020-07-20 5:17 ` IanX Kuo
2020-07-20 5:18 ` [PATCH v4 2/6] Platform/Intel/CometlakeOpenBoardPkg: Add ReportCpuHobLib IanX Kuo
` (5 subsequent siblings)
6 siblings, 0 replies; 10+ messages in thread
From: IanX Kuo @ 2020-07-20 5:17 UTC (permalink / raw)
To: devel; +Cc: IanX Kuo
Fix ReportCpuHobLib build error
Create an Library instance of ReportCpuHobLib from PlatformInitPei driver.
PA bits reported can be overriden using Library instance in Platform.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2674
Change-Id: I0cd6ba4eb7231a3a84f080fdce85bbe74eb29eeb
Signed-off-by: IanX Kuo <ianx.kuo@intel.com>
---
.../PlatformInit/Library/ReportCpuHobLib/ReportCpuHobLib.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/Platform/Intel/MinPlatformPkg/PlatformInit/Library/ReportCpuHobLib/ReportCpuHobLib.c b/Platform/Intel/MinPlatformPkg/PlatformInit/Library/ReportCpuHobLib/ReportCpuHobLib.c
index aa256534..83fc5249 100644
--- a/Platform/Intel/MinPlatformPkg/PlatformInit/Library/ReportCpuHobLib/ReportCpuHobLib.c
+++ b/Platform/Intel/MinPlatformPkg/PlatformInit/Library/ReportCpuHobLib/ReportCpuHobLib.c
@@ -6,7 +6,10 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
**/
-#include <Base.h>
+#include <Uefi.h>
+#include <Pi/PiBootMode.h>
+#include <Pi/PiHob.h>
+#include <Library/BaseLib.h>
#include <Library/HobLib.h>
VOID
--
2.26.2.windows.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH v4 2/6] Platform/Intel/CometlakeOpenBoardPkg: Add ReportCpuHobLib.
2020-07-20 8:54 [PATCH v4 0/6] *** SUBJECT HERE *** IanX Kuo
2020-07-20 5:17 ` [PATCH v4 1/6] Platform/Intel/MinPlatformPkg: Fix build error IanX Kuo
@ 2020-07-20 5:18 ` IanX Kuo
2020-07-20 5:18 ` [PATCH v4 3/6] Platform/Intel/KabylakeOpenBoardPkg: " IanX Kuo
` (4 subsequent siblings)
6 siblings, 0 replies; 10+ messages in thread
From: IanX Kuo @ 2020-07-20 5:18 UTC (permalink / raw)
To: devel; +Cc: IanX Kuo
Create an Library instance of ReportCpuHobLib from PlatformInitPei driver.
PA bits reported can be overriden using Library instance in Platform.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2674
Change-Id: I1097057046aa021dc2ff193fea335790513c10c4
Signed-off-by: IanX Kuo <ianx.kuo@intel.com>
---
.../CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc
index 136e5309..74943352 100644
--- a/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc
+++ b/Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc
@@ -39,7 +39,8 @@
#
# Include PCD configuration for this board.
#
- !include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc
+ !include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc
+
!include OpenBoardPkgPcd.dsc
!include AdvancedFeaturePkg/Include/AdvancedFeatures.dsc
@@ -121,6 +122,7 @@
PeiLib|$(PLATFORM_PACKAGE)/Library/PeiLib/PeiLib.inf
PlatformBootManagerLib|$(PLATFORM_PACKAGE)/Bds/Library/DxePlatformBootManagerLib/DxePlatformBootManagerLib.inf
ReportFvLib|$(PLATFORM_PACKAGE)/PlatformInit/Library/PeiReportFvLib/PeiReportFvLib.inf
+ ReportCpuHobLib|$(PLATFORM_PACKAGE)/PlatformInit/Library/ReportCpuHobLib/ReportCpuHobLib.inf
TestPointCheckLib|$(PLATFORM_PACKAGE)/Test/Library/TestPointCheckLibNull/TestPointCheckLibNull.inf
#######################################
--
2.26.2.windows.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH v4 3/6] Platform/Intel/KabylakeOpenBoardPkg: Add ReportCpuHobLib.
2020-07-20 8:54 [PATCH v4 0/6] *** SUBJECT HERE *** IanX Kuo
2020-07-20 5:17 ` [PATCH v4 1/6] Platform/Intel/MinPlatformPkg: Fix build error IanX Kuo
2020-07-20 5:18 ` [PATCH v4 2/6] Platform/Intel/CometlakeOpenBoardPkg: Add ReportCpuHobLib IanX Kuo
@ 2020-07-20 5:18 ` IanX Kuo
2020-07-20 5:19 ` [PATCH v4 4/6] Platform/Intel/SimicsOpenBoardPkg: " IanX Kuo
` (3 subsequent siblings)
6 siblings, 0 replies; 10+ messages in thread
From: IanX Kuo @ 2020-07-20 5:18 UTC (permalink / raw)
To: devel; +Cc: IanX Kuo
Create an Library instance of ReportCpuHobLib from PlatformInitPei driver.
PA bits reported can be overriden using Library instance in Platform.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2674
Change-Id: Ic312ec307b3bcd84051e48505038d9ca47d467e2
Signed-off-by: IanX Kuo <ianx.kuo@intel.com>
---
.../Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc | 6 ++++--
.../KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc | 6 ++++--
2 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc
index 6e35495a..55ff33ec 100644
--- a/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc
+++ b/Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc
@@ -1,7 +1,7 @@
## @file
# The main build description file for the GalagoPro3 board.
#
-# Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2019 - 2020, Intel Corporation. All rights reserved.<BR>
#
# SPDX-License-Identifier: BSD-2-Clause-Patent
#
@@ -38,7 +38,8 @@
#
# Include PCD configuration for this board.
#
- !include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc
+ !include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc
+
!include OpenBoardPkgPcd.dsc
!include AdvancedFeaturePkg/Include/AdvancedFeatures.dsc
@@ -119,6 +120,7 @@
PeiLib|$(PLATFORM_PACKAGE)/Library/PeiLib/PeiLib.inf
PlatformBootManagerLib|$(PLATFORM_PACKAGE)/Bds/Library/DxePlatformBootManagerLib/DxePlatformBootManagerLib.inf
ReportFvLib|$(PLATFORM_PACKAGE)/PlatformInit/Library/PeiReportFvLib/PeiReportFvLib.inf
+ ReportCpuHobLib|$(PLATFORM_PACKAGE)/PlatformInit/Library/ReportCpuHobLib/ReportCpuHobLib.inf
TestPointCheckLib|$(PLATFORM_PACKAGE)/Test/Library/TestPointCheckLibNull/TestPointCheckLibNull.inf
#######################################
diff --git a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc
index 2a086cd9..0d6d5f21 100644
--- a/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc
+++ b/Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/OpenBoardPkg.dsc
@@ -1,7 +1,7 @@
## @file
# The main build description file for the KabylakeRvp3 board.
#
-# Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2017 - 2020, Intel Corporation. All rights reserved.<BR>
#
# SPDX-License-Identifier: BSD-2-Clause-Patent
#
@@ -37,7 +37,8 @@
#
# Include PCD configuration for this board.
#
- !include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc
+ !include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc
+
!include OpenBoardPkgPcd.dsc
!include AdvancedFeaturePkg/Include/AdvancedFeatures.dsc
@@ -161,6 +162,7 @@
PeiLib|$(PLATFORM_PACKAGE)/Library/PeiLib/PeiLib.inf
PlatformBootManagerLib|$(PLATFORM_PACKAGE)/Bds/Library/DxePlatformBootManagerLib/DxePlatformBootManagerLib.inf
ReportFvLib|$(PLATFORM_PACKAGE)/PlatformInit/Library/PeiReportFvLib/PeiReportFvLib.inf
+ ReportCpuHobLib|$(PLATFORM_PACKAGE)/PlatformInit/Library/ReportCpuHobLib/ReportCpuHobLib.inf
TestPointCheckLib|$(PLATFORM_PACKAGE)/Test/Library/TestPointCheckLibNull/TestPointCheckLibNull.inf
#######################################
--
2.26.2.windows.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH v4 4/6] Platform/Intel/SimicsOpenBoardPkg: Add ReportCpuHobLib.
2020-07-20 8:54 [PATCH v4 0/6] *** SUBJECT HERE *** IanX Kuo
` (2 preceding siblings ...)
2020-07-20 5:18 ` [PATCH v4 3/6] Platform/Intel/KabylakeOpenBoardPkg: " IanX Kuo
@ 2020-07-20 5:19 ` IanX Kuo
2020-07-20 5:19 ` [PATCH v4 5/6] Platform/Intel/WhiskeylakeOpenBoardPkg: " IanX Kuo
` (2 subsequent siblings)
6 siblings, 0 replies; 10+ messages in thread
From: IanX Kuo @ 2020-07-20 5:19 UTC (permalink / raw)
To: devel; +Cc: IanX Kuo
Create an Library instance of ReportCpuHobLib from PlatformInitPei driver.
PA bits reported can be overriden using Library instance in Platform.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2674
Change-Id: I673f8fcd2d97bbd60229a60f53875e92826a7179
Signed-off-by: IanX Kuo <ianx.kuo@intel.com>
---
.../Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc
index 8a826009..68a8f844 100644
--- a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc
+++ b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.dsc
@@ -1,7 +1,7 @@
## @file
# The main build description file for the X58Ich10 board.
#
-# Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2019 - 2020, Intel Corporation. All rights reserved.<BR>
#
# SPDX-License-Identifier: BSD-2-Clause-Patent
#
@@ -42,7 +42,8 @@
DEFINE NETWORK_ISCSI_ENABLE = FALSE
DEFINE NETWORK_ALLOW_HTTP_CONNECTIONS = TRUE
- !include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc
+ !include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc
+
!include $(PROJECT)/OpenBoardPkgPcd.dsc
!include AdvancedFeaturePkg/Include/AdvancedFeatures.dsc
@@ -117,6 +118,7 @@
LogoLib|$(BOARD_PKG)/Library/DxeLogoLib/DxeLogoLib.inf
NvVarsFileLib|$(BOARD_PKG)/Library/NvVarsFileLib/NvVarsFileLib.inf
ReportFvLib|$(BOARD_PKG)/Library/PeiReportFvLib/PeiReportFvLib.inf
+ ReportCpuHobLib|$(PLATFORM_PACKAGE)/PlatformInit/Library/ReportCpuHobLib/ReportCpuHobLib.inf
SerializeVariablesLib|$(BOARD_PKG)/Library/SerializeVariablesLib/SerializeVariablesLib.inf
SiliconPolicyInitLib|$(BOARD_PKG)/Policy/Library/SiliconPolicyInitLib/SiliconPolicyInitLib.inf
SiliconPolicyUpdateLib|$(BOARD_PKG)/Policy/Library/SiliconPolicyUpdateLib/SiliconPolicyUpdateLib.inf
--
2.26.2.windows.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH v4 5/6] Platform/Intel/WhiskeylakeOpenBoardPkg: Add ReportCpuHobLib.
2020-07-20 8:54 [PATCH v4 0/6] *** SUBJECT HERE *** IanX Kuo
` (3 preceding siblings ...)
2020-07-20 5:19 ` [PATCH v4 4/6] Platform/Intel/SimicsOpenBoardPkg: " IanX Kuo
@ 2020-07-20 5:19 ` IanX Kuo
2020-07-20 5:19 ` [PATCH v4 6/6] Platform/Intel/MinPlatformPkg: " IanX Kuo
2020-07-21 0:14 ` [edk2-devel] [PATCH v4 0/6] *** SUBJECT HERE *** Liming Gao
6 siblings, 0 replies; 10+ messages in thread
From: IanX Kuo @ 2020-07-20 5:19 UTC (permalink / raw)
To: devel; +Cc: IanX Kuo
Create an Library instance of ReportCpuHobLib from PlatformInitPei driver.
PA bits reported can be overriden using Library instance in Platform.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2674
Change-Id: I999b29c30993c397f918a1f7b4ea19c61c0a460d
Signed-off-by: IanX Kuo <ianx.kuo@intel.com>
---
.../Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc | 4 +++-
.../WhiskeylakeURvp/OpenBoardPkg.dsc | 6 ++++--
2 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc
index fdf85b43..f78dba87 100644
--- a/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc
+++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc
@@ -39,7 +39,8 @@
#
# Include PCD configuration for this board.
#
- !include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc
+ !include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc
+
!include OpenBoardPkgPcd.dsc
!include AdvancedFeaturePkg/Include/AdvancedFeatures.dsc
@@ -121,6 +122,7 @@
PeiLib|$(PLATFORM_PACKAGE)/Library/PeiLib/PeiLib.inf
PlatformBootManagerLib|$(PLATFORM_PACKAGE)/Bds/Library/DxePlatformBootManagerLib/DxePlatformBootManagerLib.inf
ReportFvLib|$(PLATFORM_PACKAGE)/PlatformInit/Library/PeiReportFvLib/PeiReportFvLib.inf
+ ReportCpuHobLib|$(PLATFORM_PACKAGE)/PlatformInit/Library/ReportCpuHobLib/ReportCpuHobLib.inf
TestPointCheckLib|$(PLATFORM_PACKAGE)/Test/Library/TestPointCheckLibNull/TestPointCheckLibNull.inf
#######################################
diff --git a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg.dsc b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg.dsc
index 11dffb08..9ee4030a 100644
--- a/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg.dsc
+++ b/Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg.dsc
@@ -1,7 +1,7 @@
## @file
# The main build description file for the WhiskeylakeURvp board.
#
-# Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2019 - 2020, Intel Corporation. All rights reserved.<BR>
#
# SPDX-License-Identifier: BSD-2-Clause-Patent
#
@@ -39,7 +39,8 @@
#
# Include PCD configuration for this board.
#
- !include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc
+ !include AdvancedFeaturePkg/Include/AdvancedFeaturesPcd.dsc
+
!include OpenBoardPkgPcd.dsc
!include AdvancedFeaturePkg/Include/AdvancedFeatures.dsc
@@ -121,6 +122,7 @@
PeiLib|$(PLATFORM_PACKAGE)/Library/PeiLib/PeiLib.inf
PlatformBootManagerLib|$(PLATFORM_PACKAGE)/Bds/Library/DxePlatformBootManagerLib/DxePlatformBootManagerLib.inf
ReportFvLib|$(PLATFORM_PACKAGE)/PlatformInit/Library/PeiReportFvLib/PeiReportFvLib.inf
+ ReportCpuHobLib|$(PLATFORM_PACKAGE)/PlatformInit/Library/ReportCpuHobLib/ReportCpuHobLib.inf
TestPointCheckLib|$(PLATFORM_PACKAGE)/Test/Library/TestPointCheckLibNull/TestPointCheckLibNull.inf
#######################################
--
2.26.2.windows.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* [PATCH v4 6/6] Platform/Intel/MinPlatformPkg: Add ReportCpuHobLib.
2020-07-20 8:54 [PATCH v4 0/6] *** SUBJECT HERE *** IanX Kuo
` (4 preceding siblings ...)
2020-07-20 5:19 ` [PATCH v4 5/6] Platform/Intel/WhiskeylakeOpenBoardPkg: " IanX Kuo
@ 2020-07-20 5:19 ` IanX Kuo
2020-07-21 0:14 ` [edk2-devel] [PATCH v4 0/6] *** SUBJECT HERE *** Liming Gao
6 siblings, 0 replies; 10+ messages in thread
From: IanX Kuo @ 2020-07-20 5:19 UTC (permalink / raw)
To: devel; +Cc: IanX Kuo
Create an Library instance of ReportCpuHobLib from PlatformInitPei driver.
PA bits reported can be overriden using Library instance in Platform.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2674
Change-Id: I1c14aece3b229c194960e91dc9505dd8120bbe30
Signed-off-by: IanX Kuo <ianx.kuo@intel.com>
---
.../Intel/MinPlatformPkg/MinPlatformPkg.dsc | 3 ++-
.../PlatformInitPei/PlatformInitPreMem.c | 25 ++-----------------
.../PlatformInitPei/PlatformInitPreMem.inf | 3 ++-
3 files changed, 6 insertions(+), 25 deletions(-)
diff --git a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc
index 13a0fda2..b62351da 100644
--- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc
+++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc
@@ -1,7 +1,7 @@
## @file
# Platform description.
#
-# Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2017 - 2020, Intel Corporation. All rights reserved.<BR>
#
# SPDX-License-Identifier: BSD-2-Clause-Patent
#
@@ -92,6 +92,7 @@
#
FspWrapperPlatformLib|MinPlatformPkg/FspWrapper/Library/PeiFspWrapperPlatformLib/PeiFspWrapperPlatformLib.inf
ReportFvLib|MinPlatformPkg/PlatformInit/Library/PeiReportFvLib/PeiReportFvLib.inf
+ ReportCpuHobLib|MinPlatformPkg/PlatformInit/Library/ReportCpuHobLib/ReportCpuHobLib.inf
TestPointCheckLib|MinPlatformPkg/Test/Library/TestPointCheckLib/PeiTestPointCheckLib.inf
TestPointLib|MinPlatformPkg/Test/Library/TestPointLib/PeiTestPointLib.inf
SetCacheMtrrLib|MinPlatformPkg/Library/SetCacheMtrrLib/SetCacheMtrrLibNull.inf
diff --git a/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.c b/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.c
index efdeb6a9..48cbe0df 100644
--- a/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.c
+++ b/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.c
@@ -1,7 +1,7 @@
/** @file
Source code file for Platform Init Pre-Memory PEI module
-Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.<BR>
+Copyright (c) 2017 - 2020, Intel Corporation. All rights reserved.<BR>
SPDX-License-Identifier: BSD-2-Clause-Patent
**/
@@ -26,6 +26,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
#include <Library/BoardInitLib.h>
#include <Library/TestPointCheckLib.h>
#include <Library/SetCacheMtrrLib.h>
+#include <Library/ReportCpuHobLib.h>
#include <Guid/MemoryTypeInformation.h>
#include <Ppi/PlatformMemorySize.h>
#include <Ppi/BaseMemoryTest.h>
@@ -355,28 +356,6 @@ Done:
return EFI_SUCCESS;
}
-VOID
-ReportCpuHob (
- VOID
- )
-{
- UINT8 PhysicalAddressBits;
- UINT32 RegEax;
-
- AsmCpuid (0x80000000, &RegEax, NULL, NULL, NULL);
- if (RegEax >= 0x80000008) {
- AsmCpuid (0x80000008, &RegEax, NULL, NULL, NULL);
- PhysicalAddressBits = (UINT8) RegEax;
- } else {
- PhysicalAddressBits = 36;
- }
-
- ///
- /// Create a CPU hand-off information
- ///
- BuildCpuHob (PhysicalAddressBits, 16);
-}
-
/**
Install Firmware Volume Hob's once there is main memory
diff --git a/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.inf b/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.inf
index 7ee18eb6..8e828ff2 100644
--- a/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.inf
+++ b/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.inf
@@ -1,7 +1,7 @@
### @file
# Component information file for the Platform Init Pre-Memory PEI module.
#
-# Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2017 - 2020, Intel Corporation. All rights reserved.<BR>
#
# SPDX-License-Identifier: BSD-2-Clause-Patent
#
@@ -28,6 +28,7 @@
TestPointCheckLib
TimerLib
SetCacheMtrrLib
+ ReportCpuHobLib
[Packages]
MinPlatformPkg/MinPlatformPkg.dec
--
2.26.2.windows.1
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [edk2-devel] [PATCH v4 0/6] *** SUBJECT HERE ***
2020-07-20 8:54 [PATCH v4 0/6] *** SUBJECT HERE *** IanX Kuo
` (5 preceding siblings ...)
2020-07-20 5:19 ` [PATCH v4 6/6] Platform/Intel/MinPlatformPkg: " IanX Kuo
@ 2020-07-21 0:14 ` Liming Gao
2020-07-21 0:18 ` 回覆: " IanX Kuo
6 siblings, 1 reply; 10+ messages in thread
From: Liming Gao @ 2020-07-21 0:14 UTC (permalink / raw)
To: devel@edk2.groups.io, Kuo, IanX
Ian:
You send the patch v2, v3, v4, v5. Do we only need to review v5 version patch?
Thanks
Liming
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of IanX Kuo
Sent: 2020年7月20日 16:55
To: devel@edk2.groups.io
Cc: Kuo, IanX <ianx.kuo@intel.com>
Subject: [edk2-devel] [PATCH v4 0/6] *** SUBJECT HERE ***
*** BLURB HERE ***
IanX Kuo (6):
Platform/Intel/MinPlatformPkg: Fix build error
Platform/Intel/CometlakeOpenBoardPkg: Add ReportCpuHobLib.
Platform/Intel/KabylakeOpenBoardPkg: Add ReportCpuHobLib.
Platform/Intel/SimicsOpenBoardPkg: Add ReportCpuHobLib.
Platform/Intel/WhiskeylakeOpenBoardPkg: Add ReportCpuHobLib.
Platform/Intel/MinPlatformPkg: Add ReportCpuHobLib.
.../CometlakeURvp/OpenBoardPkg.dsc | 4 ++-
.../GalagoPro3/OpenBoardPkg.dsc | 6 +++--
.../KabylakeRvp3/OpenBoardPkg.dsc | 6 +++--
.../Intel/MinPlatformPkg/MinPlatformPkg.dsc | 3 ++-
.../Library/ReportCpuHobLib/ReportCpuHobLib.c | 5 +++-
.../PlatformInitPei/PlatformInitPreMem.c | 25 ++-----------------
.../PlatformInitPei/PlatformInitPreMem.inf | 3 ++-
.../BoardX58Ich10/OpenBoardPkg.dsc | 6 +++--
.../UpXtreme/OpenBoardPkg.dsc | 4 ++-
.../WhiskeylakeURvp/OpenBoardPkg.dsc | 6 +++--
10 files changed, 32 insertions(+), 36 deletions(-)
--
2.26.2.windows.1
^ permalink raw reply [flat|nested] 10+ messages in thread* 回覆: [edk2-devel] [PATCH v4 0/6] *** SUBJECT HERE ***
2020-07-21 0:14 ` [edk2-devel] [PATCH v4 0/6] *** SUBJECT HERE *** Liming Gao
@ 2020-07-21 0:18 ` IanX Kuo
0 siblings, 0 replies; 10+ messages in thread
From: IanX Kuo @ 2020-07-21 0:18 UTC (permalink / raw)
To: Gao, Liming, devel@edk2.groups.io
[-- Attachment #1: Type: text/plain, Size: 1963 bytes --]
Hi Liming
I thought devel@edk2.groups.io not to receive my path, so send many times.
I will send v6 version patch soon to fix spelling error. We can review v6 version patch directly.
Thanks,
Ian Kuo
________________________________
寄件者: Gao, Liming <liming.gao@intel.com>
寄件日期: 2020年7月21日 上午 08:14
收件者: devel@edk2.groups.io <devel@edk2.groups.io>; Kuo, IanX <ianx.kuo@intel.com>
主旨: RE: [edk2-devel] [PATCH v4 0/6] *** SUBJECT HERE ***
Ian:
You send the patch v2, v3, v4, v5. Do we only need to review v5 version patch?
Thanks
Liming
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of IanX Kuo
Sent: 2020年7月20日 16:55
To: devel@edk2.groups.io
Cc: Kuo, IanX <ianx.kuo@intel.com>
Subject: [edk2-devel] [PATCH v4 0/6] *** SUBJECT HERE ***
*** BLURB HERE ***
IanX Kuo (6):
Platform/Intel/MinPlatformPkg: Fix build error
Platform/Intel/CometlakeOpenBoardPkg: Add ReportCpuHobLib.
Platform/Intel/KabylakeOpenBoardPkg: Add ReportCpuHobLib.
Platform/Intel/SimicsOpenBoardPkg: Add ReportCpuHobLib.
Platform/Intel/WhiskeylakeOpenBoardPkg: Add ReportCpuHobLib.
Platform/Intel/MinPlatformPkg: Add ReportCpuHobLib.
.../CometlakeURvp/OpenBoardPkg.dsc | 4 ++-
.../GalagoPro3/OpenBoardPkg.dsc | 6 +++--
.../KabylakeRvp3/OpenBoardPkg.dsc | 6 +++--
.../Intel/MinPlatformPkg/MinPlatformPkg.dsc | 3 ++-
.../Library/ReportCpuHobLib/ReportCpuHobLib.c | 5 +++-
.../PlatformInitPei/PlatformInitPreMem.c | 25 ++-----------------
.../PlatformInitPei/PlatformInitPreMem.inf | 3 ++-
.../BoardX58Ich10/OpenBoardPkg.dsc | 6 +++--
.../UpXtreme/OpenBoardPkg.dsc | 4 ++-
.../WhiskeylakeURvp/OpenBoardPkg.dsc | 6 +++--
10 files changed, 32 insertions(+), 36 deletions(-)
--
2.26.2.windows.1
[-- Attachment #2: Type: text/html, Size: 3430 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v4 6/6] Platform/Intel/MinPlatformPkg: Add ReportCpuHobLib.
[not found] <cover.1595235415.git.ianx.kuo@intel.com>
@ 2020-07-20 8:59 ` IanX Kuo
0 siblings, 0 replies; 10+ messages in thread
From: IanX Kuo @ 2020-07-20 8:59 UTC (permalink / raw)
To: devel; +Cc: IanX Kuo
Create an Library instance of ReportCpuHobLib from PlatformInitPei driver.
PA bits reported can be overriden using Library instance in Platform.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2674
Change-Id: I1c14aece3b229c194960e91dc9505dd8120bbe30
Signed-off-by: IanX Kuo <ianx.kuo@intel.com>
---
.../Intel/MinPlatformPkg/MinPlatformPkg.dsc | 3 ++-
.../PlatformInitPei/PlatformInitPreMem.c | 25 ++-----------------
.../PlatformInitPei/PlatformInitPreMem.inf | 3 ++-
3 files changed, 6 insertions(+), 25 deletions(-)
diff --git a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc
index 13a0fda2..b62351da 100644
--- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc
+++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc
@@ -1,7 +1,7 @@
## @file
# Platform description.
#
-# Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2017 - 2020, Intel Corporation. All rights reserved.<BR>
#
# SPDX-License-Identifier: BSD-2-Clause-Patent
#
@@ -92,6 +92,7 @@
#
FspWrapperPlatformLib|MinPlatformPkg/FspWrapper/Library/PeiFspWrapperPlatformLib/PeiFspWrapperPlatformLib.inf
ReportFvLib|MinPlatformPkg/PlatformInit/Library/PeiReportFvLib/PeiReportFvLib.inf
+ ReportCpuHobLib|MinPlatformPkg/PlatformInit/Library/ReportCpuHobLib/ReportCpuHobLib.inf
TestPointCheckLib|MinPlatformPkg/Test/Library/TestPointCheckLib/PeiTestPointCheckLib.inf
TestPointLib|MinPlatformPkg/Test/Library/TestPointLib/PeiTestPointLib.inf
SetCacheMtrrLib|MinPlatformPkg/Library/SetCacheMtrrLib/SetCacheMtrrLibNull.inf
diff --git a/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.c b/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.c
index efdeb6a9..48cbe0df 100644
--- a/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.c
+++ b/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.c
@@ -1,7 +1,7 @@
/** @file
Source code file for Platform Init Pre-Memory PEI module
-Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.<BR>
+Copyright (c) 2017 - 2020, Intel Corporation. All rights reserved.<BR>
SPDX-License-Identifier: BSD-2-Clause-Patent
**/
@@ -26,6 +26,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
#include <Library/BoardInitLib.h>
#include <Library/TestPointCheckLib.h>
#include <Library/SetCacheMtrrLib.h>
+#include <Library/ReportCpuHobLib.h>
#include <Guid/MemoryTypeInformation.h>
#include <Ppi/PlatformMemorySize.h>
#include <Ppi/BaseMemoryTest.h>
@@ -355,28 +356,6 @@ Done:
return EFI_SUCCESS;
}
-VOID
-ReportCpuHob (
- VOID
- )
-{
- UINT8 PhysicalAddressBits;
- UINT32 RegEax;
-
- AsmCpuid (0x80000000, &RegEax, NULL, NULL, NULL);
- if (RegEax >= 0x80000008) {
- AsmCpuid (0x80000008, &RegEax, NULL, NULL, NULL);
- PhysicalAddressBits = (UINT8) RegEax;
- } else {
- PhysicalAddressBits = 36;
- }
-
- ///
- /// Create a CPU hand-off information
- ///
- BuildCpuHob (PhysicalAddressBits, 16);
-}
-
/**
Install Firmware Volume Hob's once there is main memory
diff --git a/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.inf b/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.inf
index 7ee18eb6..8e828ff2 100644
--- a/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.inf
+++ b/Platform/Intel/MinPlatformPkg/PlatformInit/PlatformInitPei/PlatformInitPreMem.inf
@@ -1,7 +1,7 @@
### @file
# Component information file for the Platform Init Pre-Memory PEI module.
#
-# Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2017 - 2020, Intel Corporation. All rights reserved.<BR>
#
# SPDX-License-Identifier: BSD-2-Clause-Patent
#
@@ -28,6 +28,7 @@
TestPointCheckLib
TimerLib
SetCacheMtrrLib
+ ReportCpuHobLib
[Packages]
MinPlatformPkg/MinPlatformPkg.dec
--
2.26.2.windows.1
^ permalink raw reply related [flat|nested] 10+ messages in thread