From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com)
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by groups.io with SMTP; Wed, 10 Jul 2019 02:20:44 -0700
Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id 2CF2D3082126;
	Wed, 10 Jul 2019 09:20:44 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-117-153.ams2.redhat.com [10.36.117.153])
	by smtp.corp.redhat.com (Postfix) with ESMTP id 51CBC92FA9;
	Wed, 10 Jul 2019 09:20:38 +0000 (UTC)
Subject: Re: [edk2-devel] [PATCH 0/3] MdePkg, OvmfPkg: rewrite Base64Decode(), clean up call site
From: "Laszlo Ersek" <lersek@redhat.com>
To: edk2-devel-groups-io <devel@edk2.groups.io>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>,
 Jordan Justen <jordan.l.justen@intel.com>, Liming Gao
 <liming.gao@intel.com>, =?UTF-8?Q?Marvin_H=c3=a4user?=
 <mhaeuser@outlook.de>, Michael D Kinney <michael.d.kinney@intel.com>,
 =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= <philmd@redhat.com>,
 Zhichao Gao <zhichao.gao@intel.com>
Reply-To: devel@edk2.groups.io, lersek@redhat.com
References: <20190702102836.27589-1-lersek@redhat.com>
Message-ID: <eef88d13-a678-d25f-a70f-6719553c4c71@redhat.com>
Date: Wed, 10 Jul 2019 11:20:37 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20190702102836.27589-1-lersek@redhat.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.42]); Wed, 10 Jul 2019 09:20:44 +0000 (UTC)
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable

On 07/02/19 12:28, Laszlo Ersek wrote:
> Repo:   https://github.com/lersek/edk2.git
> Branch: base64_decode_bz1891
>=20
> Base64Decode() has a number of issues; see
>=20
> - <https://bugzilla.tianocore.org/show_bug.cgi?id=3D1891>
>=20
> - and the mailing list discussion linked from
>   <https://bugzilla.tianocore.org/show_bug.cgi?id=3D1891#c6>.
>=20
> In my opinion, rewriting Base64Decode() from scratch, using a different
> (state machine-based) approach is safer / more robust than attempting t=
o
> identify and patch up individual problems in the current implementation=
.
> The emphasis of the proposed implementation is to reject invalid input;
> decoding valid input is kind of secondary. (This is the safe approach
> for all parsers that process untrusted input, in my opinion.)
>=20
> My understanding is that unit tests for Base64Decode() already exist in
> some repository. While I tested the new implementation through OvmfPkg'=
s
> EnrollDefaultKeys application -- which makes the sole calls to
> Base64Decode() in the open source edk2 tree -- I didn't run a unit test
> suite. Help with that (pointers to the test suite, or actual unit
> testing) would be highly appreciated.
>=20
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Marvin H=C3=A4user <mhaeuser@outlook.de>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Philippe Mathieu-Daud=C3=A9 <philmd@redhat.com>
> Cc: Zhichao Gao <zhichao.gao@intel.com>
>=20
> Thanks
> Laszlo
>=20
> Laszlo Ersek (3):
>   MdePkg/BaseLib: re-specify Base64Decode(), and add temporary stub imp=
l
>   MdePkg/BaseLib: rewrite Base64Decode()
>   OvmfPkg/EnrollDefaultKeys: clean up Base64Decode() retval handling
>=20
>  MdePkg/Include/Library/BaseLib.h              |  99 ++++-
>  MdePkg/Library/BaseLib/String.c               | 448 +++++++++++++-----=
--
>  OvmfPkg/EnrollDefaultKeys/EnrollDefaultKeys.c |  10 +-
>  3 files changed, 374 insertions(+), 183 deletions(-)
>=20

Ping.