Re: [PATCH v5 01/15] PcAtChipsetPkg: Add MMIO Support to RTC driver

["Ard Biesheuvel" <ard.biesheuvel@arm.com>]

On 10/6/20 12:16 PM, Laszlo Ersek wrote:
> Hi Ard,
> 
> On 10/05/20 12:58, Ard Biesheuvel wrote:
>> On 10/2/20 11:13 PM, Sami Mujawar wrote:
>>> Some virtual machine managers like Kvmtool emulate the MC146818
>>> RTC controller in the MMIO space so that architectures that do
>>> not support I/O Mapped I/O can use the RTC. This patch adds MMIO
>>> support to the RTC controller driver.
>>>
>>> The PCD PcdRtcUseMmio has been added to select I/O or MMIO support.
>>>     If PcdRtcUseMmio is:
>>>       TRUE  - Indicates the RTC port registers are in MMIO space.
>>>       FALSE - Indicates the RTC port registers are in I/O space.
>>>               Default is I/O space.
>>>
>>> Additionally two new PCDs PcdRtcIndexRegister64 and
>>> PcdRtcTargetRegister64 have been introduced to provide the base
>>> address for the RTC registers in the MMIO space.
>>>
>>> When MMIO support is selected (PcdRtcUseMmio == TRUE) the driver
>>> converts the pointers to the RTC MMIO registers so that the
>>> RTC registers are accessible post ExitBootServices.
>>>
>>> Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
>>> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@arm.com>
>>
>> Thanks for the resend.
>>
>> Ray, do you have any concerns regarding this patch? The series looks
>> otherwise ok, and I would like to get this merged this week.
> 
> Thank you very much for handling this. I've skimmed the series quickly
> and it mostly adds new files. I think the risk of regressions is really
> low. Please feel free to merge this from my side.
> 
> For wherever it applies in the series:
> 
> Acked-by: Laszlo Ersek <lersek@redhat.com>
> 

Thank you Laszlo.

Note to all: I have given ample time to anyone involved to respond to 
this series, and to this patch in particular. Therefore, I am going to 
assume there are no objections, and I intend to merge this entire series 
tomorrow.

Thanks,
Ard.