From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web12.13696.1602772538166965721 for ; Thu, 15 Oct 2020 07:35:38 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: ard.biesheuvel@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0F01513D5; Thu, 15 Oct 2020 07:35:37 -0700 (PDT) Received: from [192.168.1.81] (unknown [10.37.8.32]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 137703F719; Thu, 15 Oct 2020 07:35:33 -0700 (PDT) Subject: Re: [PATCH v5 01/15] PcAtChipsetPkg: Add MMIO Support to RTC driver To: Laszlo Ersek , Sami Mujawar , devel@edk2.groups.io, ray.ni@intel.com, Guomin Jiang Cc: leif@nuviainc.com, Alexandru.Elisei@arm.com, Andre.Przywara@arm.com, Matteo.Carlini@arm.com, Ben.Adderson@arm.com, nd@arm.com, Andrew Fish , "Kinney, Michael D" References: <20201002211409.43888-1-sami.mujawar@arm.com> <20201002211409.43888-2-sami.mujawar@arm.com> <6186f413-8ec9-ded5-6290-82397e19904b@arm.com> <03c60daf-1a51-e66f-a7cf-6e8667cf4760@redhat.com> From: "Ard Biesheuvel" Message-ID: Date: Thu, 15 Oct 2020 16:35:31 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <03c60daf-1a51-e66f-a7cf-6e8667cf4760@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 10/6/20 12:16 PM, Laszlo Ersek wrote: > Hi Ard, >=20 > On 10/05/20 12:58, Ard Biesheuvel wrote: >> On 10/2/20 11:13 PM, Sami Mujawar wrote: >>> Some virtual machine managers like Kvmtool emulate the MC146818 >>> RTC controller in the MMIO space so that architectures that do >>> not support I/O Mapped I/O can use the RTC. This patch adds MMIO >>> support to the RTC controller driver. >>> >>> The PCD PcdRtcUseMmio has been added to select I/O or MMIO support. >>> =C2=A0=C2=A0 If PcdRtcUseMmio is: >>> =C2=A0=C2=A0=C2=A0=C2=A0 TRUE=C2=A0 - Indicates the RTC port registe= rs are in MMIO space. >>> =C2=A0=C2=A0=C2=A0=C2=A0 FALSE - Indicates the RTC port registers ar= e in I/O space. >>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0 Default is I/O space. >>> >>> Additionally two new PCDs PcdRtcIndexRegister64 and >>> PcdRtcTargetRegister64 have been introduced to provide the base >>> address for the RTC registers in the MMIO space. >>> >>> When MMIO support is selected (PcdRtcUseMmio =3D=3D TRUE) the driver >>> converts the pointers to the RTC MMIO registers so that the >>> RTC registers are accessible post ExitBootServices. >>> >>> Signed-off-by: Sami Mujawar >>> Reviewed-by: Ard Biesheuvel >> >> Thanks for the resend. >> >> Ray, do you have any concerns regarding this patch? The series looks >> otherwise ok, and I would like to get this merged this week. >=20 > Thank you very much for handling this. I've skimmed the series quickly > and it mostly adds new files. I think the risk of regressions is really > low. Please feel free to merge this from my side. >=20 > For wherever it applies in the series: >=20 > Acked-by: Laszlo Ersek >=20 Thank you Laszlo. Note to all: I have given ample time to anyone involved to respond to=20 this series, and to this patch in particular. Therefore, I am going to=20 assume there are no objections, and I intend to merge this entire series=20 tomorrow. Thanks, Ard.