From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5EC672095DC92 for ; Thu, 24 May 2018 13:51:15 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8E9A580401A8; Thu, 24 May 2018 20:51:14 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-121-84.rdu2.redhat.com [10.10.121.84]) by smtp.corp.redhat.com (Postfix) with ESMTP id B9A6F2026DEF; Thu, 24 May 2018 20:51:13 +0000 (UTC) To: Jordan Justen , "edk2-devel@lists.01.org" , =?UTF-8?Q?Marvin_H=c3=a4user?= Cc: "afish@apple.com" References: <152719419292.1535.16346737535215645719@jljusten-skl> From: Laszlo Ersek Message-ID: Date: Thu, 24 May 2018 22:51:12 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <152719419292.1535.16346737535215645719@jljusten-skl> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Thu, 24 May 2018 20:51:14 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Thu, 24 May 2018 20:51:14 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:'' Subject: Re: [PATCH v2] EmulatorPkg/SmbiosLib: Declare the correct library class. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 May 2018 20:51:15 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 05/24/18 22:36, Jordan Justen wrote: > Reviewed-by: Jordan Justen > > Pushed as 7dc7c7435e. > > On 2018-05-17 05:43:30, Marvin Häuser wrote: >> Currently, SmbiosLib declares the PcdLib library class. Update the >> declaration to declare SmbiosLib. >> >> V2: >> - Do not change the copyright date as requested. >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Marvin Haeuser >> --- >> EmulatorPkg/Library/SmbiosLib/SmbiosLib.inf | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/EmulatorPkg/Library/SmbiosLib/SmbiosLib.inf b/EmulatorPkg/Library/SmbiosLib/SmbiosLib.inf >> index adcd7ef08e20..36d5c350f51a 100644 >> --- a/EmulatorPkg/Library/SmbiosLib/SmbiosLib.inf >> +++ b/EmulatorPkg/Library/SmbiosLib/SmbiosLib.inf >> @@ -20,7 +20,7 @@ [Defines] >> FILE_GUID = 881863A2-09FD-3E44-8D62-7AE038D03747 >> MODULE_TYPE = DXE_DRIVER >> VERSION_STRING = 1.0 >> - LIBRARY_CLASS = PcdLib|DXE_CORE DXE_DRIVER DXE_RUNTIME_DRIVER DXE_SAL_DRIVER DXE_SMM_DRIVER SMM_CORE UEFI_APPLICATION UEFI_DRIVER >> + LIBRARY_CLASS = SmbiosLib|DXE_CORE DXE_DRIVER DXE_RUNTIME_DRIVER DXE_SAL_DRIVER DXE_SMM_DRIVER SMM_CORE UEFI_APPLICATION UEFI_DRIVER >> >> CONSTRUCTOR = SmbiosLibConstructor (Just because I pondered the question a few days ago, independently, I'll voice it here:) Should BaseTools catch this? "EmulatorPkg/EmulatorPkg.dsc" contains the following library resolution: SmbiosLib|EmulatorPkg/Library/SmbiosLib/SmbiosLib.inf I think it should be possible to flag that the class of the lib instance doesn't match the lib class that the platform DSC is resolving. (Or is Marvin's patch the result of such an error message already?) Thanks! Laszlo