From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.120]) by mx.groups.io with SMTP id smtpd.web09.10281.1581704456765660822 for ; Fri, 14 Feb 2020 10:20:56 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=UeTNoERQ; spf=pass (domain: redhat.com, ip: 207.211.31.120, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581704455; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vuQ0POaB41/4oBzUkco8Ez57ksXaRBMuLXH8Lvo+HxE=; b=UeTNoERQVToSokjZNmXn21mah223gG5tc0e0XB8raK0yydfdp/vQO7s8j4TVfGDuaWnAar ja6FmUxufd9yg1iyczi9/3Us/yEO68OGJfezYN7P1hw4S3iOLssT1sQZwAtddDB2XVR9Uu giqAv8GU26kHL9pSKKEggsLIEImBP5g= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-111-HRIoLQAAPP-2cF3smFFkdQ-1; Fri, 14 Feb 2020 13:20:53 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7EFA2800D50; Fri, 14 Feb 2020 18:20:52 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-153.ams2.redhat.com [10.36.116.153]) by smtp.corp.redhat.com (Postfix) with ESMTP id C33EA60BF1; Fri, 14 Feb 2020 18:20:47 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v2 1/3] Ovmf: rename TPM2 config prefix to TPM To: devel@edk2.groups.io, marcandre.lureau@redhat.com, edk2-devel@lists.01.org Cc: stefanb@linux.ibm.com, simon.hardy@itdev.co.uk References: <20200213131222.157700-1-marcandre.lureau@redhat.com> <20200213131222.157700-2-marcandre.lureau@redhat.com> From: "Laszlo Ersek" Message-ID: Date: Fri, 14 Feb 2020 19:20:46 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200213131222.157700-2-marcandre.lureau@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-MC-Unique: HRIoLQAAPP-2cF3smFFkdQ-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 02/13/20 14:12, marcandre.lureau@redhat.com wrote: > From: Marc-Andr=C3=A9 Lureau >=20 > A following patch is going to use the same configuration for TPM1.2 > and TPM2.0, and it's simpler to support both than variable > configurations. >=20 > Signed-off-by: Marc-Andr=C3=A9 Lureau > --- > OvmfPkg/OvmfPkgIa32.dsc | 24 ++++++++++++------------ > OvmfPkg/OvmfPkgIa32.fdf | 8 ++++---- > OvmfPkg/OvmfPkgIa32X64.dsc | 24 ++++++++++++------------ > OvmfPkg/OvmfPkgIa32X64.fdf | 8 ++++---- > OvmfPkg/OvmfPkgX64.dsc | 24 ++++++++++++------------ > OvmfPkg/OvmfPkgX64.fdf | 8 ++++---- > 6 files changed, 48 insertions(+), 48 deletions(-) Hm..., OK. I can live with this. I'd prefer keeping them separate, but you have a valid point that, *if* someone decides to enable at least one TPM version, they might as well enable both. So, Reviewed-by: Laszlo Ersek Thanks! Laszlo