From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.24; helo=mga09.intel.com; envelope-from=ruiyu.ni@intel.com; receiver=edk2-devel@lists.01.org Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 226342117D28B for ; Tue, 23 Oct 2018 01:52:55 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Oct 2018 01:52:55 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,415,1534834800"; d="scan'208";a="83699156" Received: from ray-dev.ccr.corp.intel.com (HELO [10.239.9.11]) ([10.239.9.11]) by orsmga008.jf.intel.com with ESMTP; 23 Oct 2018 01:52:53 -0700 To: Hao Wu , edk2-devel@lists.01.org Cc: Liangcheng Tang , Star Zeng References: <20181018064200.2068-1-hao.a.wu@intel.com> <20181018064200.2068-3-hao.a.wu@intel.com> From: "Ni, Ruiyu" Message-ID: Date: Tue, 23 Oct 2018 16:54:09 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20181018064200.2068-3-hao.a.wu@intel.com> Subject: Re: [PATCH v1 2/3] MdeModulePkg/NvmExpressDxe: Always copy CQ entry to PassThru packet X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 23 Oct 2018 08:52:55 -0000 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 10/18/2018 2:41 PM, Hao Wu wrote: > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1259 > > According to the the NVM Express spec Revision 1.1, for some commands, > command-related information will be stored in the Dword 0 of the > completion queue entry. > > One case is for the Get Features Command (Section 5.9.2 of the spec), > Dword 0 of the completion queue entry may contain feature information. > > Hence, this commit will always copy the content of completion queue entry > to the PassThru packet regardless of the execution result of the command. > > Cc: Liangcheng Tang > Cc: Ruiyu Ni > Cc: Star Zeng > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Hao Wu > --- > MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressPassthru.c | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressPassthru.c b/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressPassthru.c > index bfcd349794..c52e960771 100644 > --- a/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressPassthru.c > +++ b/MdeModulePkg/Bus/Pci/NvmExpressDxe/NvmExpressPassthru.c > @@ -781,17 +781,16 @@ NvmExpressPassThru ( > } else { > Status = EFI_DEVICE_ERROR; > // > - // Copy the Respose Queue entry for this command to the callers response buffer > - // > - CopyMem(Packet->NvmeCompletion, Cq, sizeof(EFI_NVM_EXPRESS_COMPLETION)); > - > - // > // Dump every completion entry status for debugging. > // > DEBUG_CODE_BEGIN(); > NvmeDumpStatus(Cq); > DEBUG_CODE_END(); > } > + // > + // Copy the Respose Queue entry for this command to the callers response buffer > + // > + CopyMem(Packet->NvmeCompletion, Cq, sizeof(EFI_NVM_EXPRESS_COMPLETION)); > } else { > // > // Timeout occurs for an NVMe command. Reset the controller to abort the > Reviewed-by: Ruiyu Ni -- Thanks, Ray