From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (NAM11-CO1-obe.outbound.protection.outlook.com [40.107.220.60]) by mx.groups.io with SMTP id smtpd.web11.95.1688079737536921387 for ; Thu, 29 Jun 2023 16:02:17 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nvidia.com header.s=selector2 header.b=deRmzJl0; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: nvidia.com, ip: 40.107.220.60, mailfrom: jbrasen@nvidia.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZdRaw19fqdjsSHWSwDASLuwFZgrcBhMIEVMJyeYi16K49pnCSKhf5s8LI6aCOhMaxcNPSMQAnD96knapAAvqJtRDu5FX+z6lzP9J4AfLDoq+G+OSk+QpTCtwt4O0WZ4IpRPtUr7vwq9Be4WBzk/9M2wHpko2meUoQbSGMmlOUOrfHE9eH4pxUgAIHd9uihr3PfiWOEzHPh3QpAXZ7YVEh/drWAoyzN2uwpKht13WSuSipQ/enUpTtOIxVb2uishp1/XxMzcH/DeLpKhwVBtNTcjqZ5NmqP4PEb2v7bHFiPz3WrtkhVJ/a3xLrS2XgVvIo4wwgvTPm2oH1xLQJ2P64g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=E7i0UmX102mye8GCQ2D//8YI9YIejJl7scmfvyNzuGM=; b=K038u/sB7vrfHNH1ZY57/87BMs/Qh57lTVUS4Axvlm/dXGpzs7jYn3HgeSMavRvVbNQ2oS6B94XC9RQOnyj+gxOOH01YYRhn6zOSUMdAfHjPUgXGO6LOYOoEOeK91HnzlR9svxVU/Yf23UAkOsmZBNDBMtnUMKCs/E5fhvd6wVHE4IdYepWsOf8AmLKG/7m9H6Hl6Z8rR0MompDwD/lSK0+dR7eUdOIN4lNwj30vFts9snl3Weysar6i17/Ae6upqmi9S1w1xIOLalyfErvTk9t5sMzLL9nZeWBZXmGGJsk10ku5F/n6NWNNVp3nfgWn8HCH17o8M9Pe/Nr0Wxir9Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=E7i0UmX102mye8GCQ2D//8YI9YIejJl7scmfvyNzuGM=; b=deRmzJl0IMlxgnX7U9WwRYWTQd24e7RXFstvXUu8R93m2IkQzNeC7hPNaLZPTC4jPgtFK4Ksc8f162V6yBNnhwi/lvpcWaaRoofk8zCEqYM9QyG7qqG18PsYcB8setwKL6b0U7islPUFXEqncsRjbBCA73OrQJ2HnmfAUkJxNjhkl6jmMNy4MF5pj1Dk+B80aR0/hrDrpyX59o0RQ1MJFfMKL46egy6A/3nPkj0IVZhVMSNpwM1XXJ/Yn+rRU3LlIv82jCOCzZGY3l/ixHr1ePSuA+xnlNJTehmgsLDmwyUl8jvB9vWB5KMF3QVkBlMr9Bf2ATWthPYMq3Z/HuvTAg== Received: from BN8PR15CA0010.namprd15.prod.outlook.com (2603:10b6:408:c0::23) by MN0PR12MB6197.namprd12.prod.outlook.com (2603:10b6:208:3c6::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.21; Thu, 29 Jun 2023 23:02:15 +0000 Received: from BN8NAM11FT065.eop-nam11.prod.protection.outlook.com (2603:10b6:408:c0:cafe::88) by BN8PR15CA0010.outlook.office365.com (2603:10b6:408:c0::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.22 via Frontend Transport; Thu, 29 Jun 2023 23:02:15 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BN8NAM11FT065.mail.protection.outlook.com (10.13.177.63) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6500.49 via Frontend Transport; Thu, 29 Jun 2023 23:02:14 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Thu, 29 Jun 2023 16:02:00 -0700 Received: from rnnvmail205.nvidia.com (10.129.68.10) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Thu, 29 Jun 2023 16:02:00 -0700 Received: from 6cd8174ac25c.nvidia.com (10.127.8.9) by mail.nvidia.com (10.129.68.10) with Microsoft SMTP Server id 15.2.986.37 via Frontend Transport; Thu, 29 Jun 2023 16:01:59 -0700 From: "Jeff Brasen" To: CC: , , , Jeff Brasen , "Swatisri Kantamsetti" , Ashish Singhal Subject: [PATCH 4/4] DynamicTablesPkg: Add Aml NameUnicodeString API Date: Thu, 29 Jun 2023 23:01:49 +0000 Message-ID: X-Mailer: git-send-email 2.25.1 In-Reply-To: References: MIME-Version: 1.0 X-NVConfidentiality: public Return-Path: jbrasen@nvidia.com X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT065:EE_|MN0PR12MB6197:EE_ X-MS-Office365-Filtering-Correlation-Id: 9332b2df-2a24-461d-41ce-08db78f4e15e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /+4JcPVH9jBVugCywi38UjxQBcadFsMyOwWaQdtMHV3yP8rvPNRvMj71wsbMokX5BqlwcrZEGiKKc/RB2QQnS7GoG41ECW/9IjqInkOQxq3M1sKHhRBJDpoSarQTr69LaIeYr5/Yu4gIf3WXx7YqY9etIsXRBsLOLES6N18XpELiu87GmokhwEqSTJ1Ht1l6D3WEnYk/UT1RDUAJ+muo6Ha2M6zeDXrlOhWf2MQovA7zSrjLMc8/LEoRxix9pUKMsBjrz/Xr8i7sIRZGwrrsJE50GMfwryuQz5aCmaeEigt42GriBrJVX5n3Ug2JA/vz5rKdic4j36cll7Ysakpi4gyf2rvukcWD3CoT0yODuF5vvoheL8mV8wJtSysTgL0y3cUdloOEOU0eT8GyIjaswJQOwPFTqC0kw15P/Cks6MSD1bZC3JW5bWwCWadRbw9PXMmxHdP9XpEvpt+FtMEXXaVZxOf9ENviUxRt1CzEeag6cqp0OZ2DT9ZOdBMxPMf1pMX6R5dvGUSsyRaz6Ow0SHaimlOT7nQful5wa7dP2263VmOMg8ZeWF70p3yQL9Pb6OuDQWyj+WrEydvgxwWjf/7KfOyGVgcS7byAGlKX2UZwzrpzE1iaY6gvnq9/VnCGnXu5UtqMWRbHc9Y5z4WtGJ1+1qEDpFTuqG5ufptx5bifKKFo+UEdAUPp4WZ+f/TIkrzyqjboqw08bijSCCZBkK41J8NDEGKWksV50XZTnaY82fXrEI7eNF9e151vuv8z X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230028)(4636009)(346002)(396003)(136003)(376002)(39860400002)(451199021)(40470700004)(36840700001)(46966006)(7636003)(356005)(82310400005)(82740400003)(40480700001)(86362001)(107886003)(5660300002)(2616005)(70586007)(186003)(26005)(70206006)(6916009)(478600001)(2906002)(8676002)(4326008)(7696005)(316002)(6666004)(41300700001)(8936002)(47076005)(426003)(336012)(83380400001)(36860700001)(54906003)(36756003)(40460700003);DIR:OUT;SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jun 2023 23:02:14.9430 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9332b2df-2a24-461d-41ce-08db78f4e15e X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT065.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB6197 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain Add API to generate a Name that contains a Unicode string buffer.=0D =0D Change-Id: I0116b2921cbbbecc3420ff7a42a7ab6e01852534=0D Reviewed-by: Swatisri Kantamsetti =0D Reviewed-by: Ashish Singhal =0D ---=0D .../Include/Library/AmlLib/AmlLib.h | 31 +++++++=0D .../Common/AmlLib/CodeGen/AmlCodeGen.c | 86 +++++++++++++++++++=0D 2 files changed, 117 insertions(+)=0D =0D diff --git a/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h b/DynamicTabl= esPkg/Include/Library/AmlLib/AmlLib.h=0D index 043e7ee901..5150aa4870 100644=0D --- a/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h=0D +++ b/DynamicTablesPkg/Include/Library/AmlLib/AmlLib.h=0D @@ -958,6 +958,37 @@ AmlCodeGenNameResourceTemplate (=0D OUT AML_OBJECT_NODE_HANDLE *NewObjectNode OPTIONAL=0D );=0D =0D +/** AML code generation for a Name object node, containing a String.=0D +=0D + AmlCodeGenNameUnicodeString ("_STR", L"String", ParentNode, NewObjectNod= e) is=0D + equivalent of the following ASL code:=0D + Name(_STR, Unicode ("String"))=0D +=0D + @ingroup CodeGenApis=0D +=0D + @param [in] NameString The new variable name.=0D + Must be a NULL-terminated ASL NameString=0D + e.g.: "DEV0", "DV15.DEV0", etc.=0D + The input string is copied.=0D + @param [in] String NULL terminated Unicode String to associate = to the=0D + NameString.=0D + @param [in] ParentNode If provided, set ParentNode as the parent=0D + of the node created.=0D + @param [out] NewObjectNode If success, contains the created node.=0D +=0D + @retval EFI_SUCCESS Success.=0D + @retval EFI_INVALID_PARAMETER Invalid parameter.=0D + @retval EFI_OUT_OF_RESOURCES Failed to allocate memory.=0D +**/=0D +EFI_STATUS=0D +EFIAPI=0D +AmlCodeGenNameUnicodeString (=0D + IN CONST CHAR8 *NameString,=0D + IN CHAR16 *String,=0D + IN AML_NODE_HANDLE ParentNode OPTIONAL,=0D + OUT AML_OBJECT_NODE_HANDLE *NewObjectNode OPTIONAL=0D + );=0D +=0D /** Add a _PRT entry.=0D =0D AmlCodeGenPrtEntry (0x0FFFF, 0, "LNKA", 0, PrtNameNode) is=0D diff --git a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c b/= DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c=0D index a0d01032d5..20ddad031d 100644=0D --- a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c=0D +++ b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c=0D @@ -869,6 +869,92 @@ AmlCodeGenNameResourceTemplate (=0D return Status;=0D }=0D =0D +/** AML code generation for a Name object node, containing a String.=0D +=0D + AmlCodeGenNameUnicodeString ("_STR", L"String", ParentNode, NewObjectNode= ) is=0D + equivalent of the following ASL code:=0D + Name(_STR, Unicode ("String"))=0D +=0D + @ingroup CodeGenApis=0D +=0D + @param [in] NameString The new variable name.=0D + Must be a NULL-terminated ASL NameString=0D + e.g.: "DEV0", "DV15.DEV0", etc.=0D + The input string is copied.=0D + @param [in] String NULL terminated Unicode String to associate t= o the=0D + NameString.=0D + @param [in] ParentNode If provided, set ParentNode as the parent=0D + of the node created.=0D + @param [out] NewObjectNode If success, contains the created node.=0D +=0D + @retval EFI_SUCCESS Success.=0D + @retval EFI_INVALID_PARAMETER Invalid parameter.=0D + @retval EFI_OUT_OF_RESOURCES Failed to allocate memory.=0D +**/=0D +EFI_STATUS=0D +EFIAPI=0D +AmlCodeGenNameUnicodeString (=0D + IN CONST CHAR8 *NameString,=0D + IN CHAR16 *String,=0D + IN AML_NODE_HANDLE ParentNode OPTIONAL,=0D + OUT AML_OBJECT_NODE_HANDLE *NewObjectNode OPTIONAL=0D + )=0D +{=0D + EFI_STATUS Status;=0D + AML_OBJECT_NODE *ObjectNode;=0D + AML_DATA_NODE *DataNode;=0D +=0D + if ((NameString =3D=3D NULL) ||=0D + (String =3D=3D NULL) ||=0D + ((ParentNode =3D=3D NULL) && (NewObjectNode =3D=3D NULL)))=0D + {=0D + ASSERT (0);=0D + return EFI_INVALID_PARAMETER;=0D + }=0D +=0D + Status =3D AmlCodeGenBuffer (NULL, 0, &ObjectNode);=0D + if (EFI_ERROR (Status)) {=0D + ASSERT_EFI_ERROR (Status);=0D + return Status;=0D + }=0D +=0D + Status =3D AmlCreateDataNode (=0D + EAmlNodeDataTypeRaw,=0D + (CONST UINT8 *)String,=0D + StrSize (String),=0D + &DataNode=0D + );=0D + if (EFI_ERROR (Status)) {=0D + ASSERT_EFI_ERROR (Status);=0D + AmlDeleteTree ((AML_NODE_HEADER *)ObjectNode);=0D + return Status;=0D + }=0D +=0D + Status =3D AmlVarListAddTail (=0D + (AML_NODE_HEADER *)ObjectNode,=0D + (AML_NODE_HEADER *)DataNode=0D + );=0D + if (EFI_ERROR (Status)) {=0D + ASSERT_EFI_ERROR (Status);=0D + AmlDeleteTree ((AML_NODE_HEADER *)ObjectNode);=0D + AmlDeleteTree ((AML_NODE_HANDLE)DataNode);=0D + return Status;=0D + }=0D +=0D + Status =3D AmlCodeGenName (=0D + NameString,=0D + ObjectNode,=0D + ParentNode,=0D + NewObjectNode=0D + );=0D + if (EFI_ERROR (Status)) {=0D + ASSERT (0);=0D + AmlDeleteTree ((AML_NODE_HEADER *)ObjectNode);=0D + }=0D +=0D + return Status;=0D +}=0D +=0D /** Add a _PRT entry.=0D =0D AmlCodeGenPrtEntry (0x0FFFF, 0, "LNKA", 0, PrtNameNode) is=0D -- =0D 2.25.1=0D =0D