From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.81]) by mx.groups.io with SMTP id smtpd.web12.9309.1574875051063932626 for ; Wed, 27 Nov 2019 09:17:31 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Kid0Wf/e; spf=pass (domain: redhat.com, ip: 207.211.31.81, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1574875050; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qLhOfd4l5vXYNEHoSJ00IG2WFXnPi94VGGdArIqcu2Y=; b=Kid0Wf/eirOuVW4Tv8NWH+dDvLo1V/PK+5mrrXbuTMJ6fKEmS0VNxxnuzmJGgDisBCvHqT 8/C9yPlW2G08titLKAKpNZTr0iK1fmL39OYC1VvXo+ylv6i+Ed/+snTnatjnZdo/y+z575 ARpcjAypRb0FemALOz9J/YKJYKC6xq4= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-39-xu1hcIw7MfOf4H-NmHmc9Q-1; Wed, 27 Nov 2019 12:17:28 -0500 Received: by mail-wm1-f70.google.com with SMTP id y14so2660002wmj.9 for ; Wed, 27 Nov 2019 09:17:28 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=aSVelAtThaHZiDp38Qaxqt456WfFmSCrxT/hDTbquWo=; b=HV68DkjRID5Bcak8XAR9PTgpSW6QdqmTqVZ8DVHD/qx5SF7dtDEil6rYI0P3ROf4x2 KB6Wp3Y0PiHHJvBFyrC0lq4opq0mXK16B02eXMIa80MaLW5paqMgMle3xSpoUw4fMWjM zu5N5aIi5zTecExaoQJZKtKJ/yw1bNZtE8+bcYDmYOrrCB+WnhblaZwS3SyIwUejrqDP K2/+PhvjVxRgPfNLwSOOiflEoWPsWzuocJYo/iK7rdER9cOMB/w97/sHUMMrkbfmJImm ZSXpuh8qae0iJKsGwW9KVb2cA/2ybRdjpsuFghT2qshlhUQwPOCEAlyB+aqjwd4Ut3DX BSFA== X-Gm-Message-State: APjAAAXoFhdONWh9i2RsS9Le+wI5hQU+HbD5eMrkSuMzsP3Rpu7ZZWJQ d++kzQTH0X1743xd0acdnNErwS1kswIfpynECktc7eyM4wthP7KJ/kUTJ3AKmts5TbBTq2S1JR6 tLLya6RQX+6fKdg== X-Received: by 2002:a1c:7d92:: with SMTP id y140mr5293786wmc.145.1574875047558; Wed, 27 Nov 2019 09:17:27 -0800 (PST) X-Google-Smtp-Source: APXvYqyDKvB9hIhcSin2tond3be/OEC+RnHSsu+3l+K9b9sPW4evWgu46WOCq7ELh4YdBfFye05P0w== X-Received: by 2002:a1c:7d92:: with SMTP id y140mr5293762wmc.145.1574875047269; Wed, 27 Nov 2019 09:17:27 -0800 (PST) Return-Path: Received: from [192.168.1.35] (182.red-88-21-103.staticip.rima-tde.net. [88.21.103.182]) by smtp.gmail.com with ESMTPSA id u26sm7711341wmj.9.2019.11.27.09.17.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 27 Nov 2019 09:17:26 -0800 (PST) Subject: Re: [edk2-platforms][PATCH 5/5] Platform/RPi: Set SD routing according to model To: Leif Lindholm , Pete Batard Cc: devel@edk2.groups.io, ard.biesheuvel@linaro.org, samer.el-haj-mahmoud@arm.com, andrey.warkentin@gmail.com References: <20191127123706.4604-1-pete@akeo.ie> <20191127123706.4604-6-pete@akeo.ie> <672a8fd3-f9db-3d60-ea02-188af6e8a6a5@redhat.com> <514e89d4-d571-b89b-0598-e6a56de93215@akeo.ie> <20191127170431.GM7359@bivouac.eciton.net> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: Date: Wed, 27 Nov 2019 18:17:25 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.1 MIME-Version: 1.0 In-Reply-To: <20191127170431.GM7359@bivouac.eciton.net> X-MC-Unique: xu1hcIw7MfOf4H-NmHmc9Q-1 X-Mimecast-Spam-Score: 0 Content-Language: en-US Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable On 11/27/19 6:04 PM, Leif Lindholm wrote: > On Wed, Nov 27, 2019 at 16:33:28 +0000, Pete Batard wrote: >>>> Signed-off-by: Pete Batard >>>> --- >>>> =C2=A0 Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c | 137 >>>> ++++++++++++++------ >>>> =C2=A0 1 file changed, 96 insertions(+), 41 deletions(-) >>>> >>>> diff --git a/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c >>>> b/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c >>>> index 98e58a560ed4..26bc92f28185 100644 >>>> --- a/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c >>>> +++ b/Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c >>>> @@ -1,6 +1,7 @@ >>>> =C2=A0 /** @file >>>> =C2=A0=C2=A0 * >>>> - *=C2=A0 Copyright (c) 2018, Andrei Warkentin >>>> + *=C2=A0 Copyright (c) 2019, ARM Limited. All rights reserved. >>> >>> "All rights reserved."? >> >> To be honest, that's something that's been bothering me too in this code= base >> (and some other ones too, where you get to see the same), since there ar= e >> only so many rights one can reserve when the code is actually governed b= y >> the Open Source license being used, and therefore asserting that you res= erve >> "all rights" seems to be in direct conflict with that. >> >> However, I am not a lawyer, and this seems to be standard boilerplate be= ing >> imposed by large companies. For instance, you'll find plenty of instance= s of >> it in the existing codebase. E.g. >> https://github.com/tianocore/edk2/blob/master/ArmPkg/Include/AsmMacroIoL= ib.h >> has three separate entities that appear to state that each one holds all= the >> rights to the source, which I can't help by find amusing. >> >> I guess we're supposed to understand that each entity reserves all right= s to >> the code they've actually written (including the right to do something t= hat >> might go against the license, since "All rights" > "Rights to the extent >> being granted by the BSD"), and that it's up to legal departments to sor= t up >> the mess, if mess there is... >=20 > Yeah, that mostly matches my interpretation. >=20 > My understanding is that there are certain paranoid interpretations > under which you *give away* rights to code you contribute to an open > source project - like the right to also publish/contribute the same > code under some other license. >=20 > I don't know if this stems from things like copyright assignment > agreements, which (for similar reasons) may explicitly grant back to > the contributor a bunch of rights to the contributed code, and various > corporate legal departments just blindly require it to be included > everywhere. >=20 > Phil: do a grep in linux, u-boot or qemu. > This is silly, but it's commonplace and non-controversial. Sorry for keeping asking about licensing, I'm trying to understand=20 better the situation / status quo, I also am not a lawyer. Thanks both for your explanations :) >> Then again, while I think I can wrap my head against what copyright enta= ils, >> I'm not sure I completely get what these additional "rights" are suppose= d to >> mean in this context (my current take being that we're supposed to be >> believe that there exists an implicit grandfathered license, which gives= all >> rights to the parent company, and that governs a virtual version of the >> source code containing only the changes that the developer applied, and >> therefore that the BSD licensed version of the source that is then made >> public is meant to be seen as a derivative of this virtual "All rights >> reserved" incomplete source, hence granting a partial "All rights" for s= aid >> source to the company, if that makes any sense), so it may be good for >> someone with better understanding of this to clarify, or point to a plac= e >> where this might be explained. >=20