From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=fail (domain: intel.com, ip: , mailfrom: prince.agyeman@intel.com) Received: from mga05.intel.com (mga05.intel.com []) by groups.io with SMTP; Mon, 09 Sep 2019 16:15:13 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Sep 2019 16:15:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,487,1559545200"; d="scan'208";a="268226388" Received: from paagyema-desk2.amr.corp.intel.com ([10.7.159.148]) by orsmga001.jf.intel.com with ESMTP; 09 Sep 2019 16:15:10 -0700 From: "Agyeman, Prince" To: devel@edk2.groups.io Cc: David Wei , Liming Gao , Ankit Sinha , Agyeman Prince , Kubacki Michael A , Nate DeSimone Subject: [edk2-platforms] [PATCH 2/3] SimicsOpenBoardPkg: Fix GCC build issues Date: Mon, 9 Sep 2019 16:15:08 -0700 Message-Id: X-Mailer: git-send-email 2.19.1.windows.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Cc: David Wei Cc: Liming Gao Cc: Ankit Sinha Cc: Agyeman Prince Cc: Kubacki Michael A Cc: Nate DeSimone Signed-off-by: Prince Agyeman --- .../PlatformBootManagerLib/BdsPlatform.c | 38 ------------------- .../SimicsOpenBoardPkg/SecCore/SecMain.c | 23 ----------- 2 files changed, 61 deletions(-) diff --git a/Platform/Intel/SimicsOpenBoardPkg/Library/PlatformBootManagerLib/BdsPlatform.c b/Platform/Intel/SimicsOpenBoardPkg/Library/PlatformBootManagerLib/BdsPlatform.c index 117c72b35f..953a4a6c15 100644 --- a/Platform/Intel/SimicsOpenBoardPkg/Library/PlatformBootManagerLib/BdsPlatform.c +++ b/Platform/Intel/SimicsOpenBoardPkg/Library/PlatformBootManagerLib/BdsPlatform.c @@ -316,12 +316,6 @@ ConnectRootBridge ( IN VOID *Context ); -STATIC -VOID -SaveS3BootScript ( - VOID - ); - // // BDS Platform Functions // @@ -1296,38 +1290,6 @@ PlatformBdsConnectSequence ( PciAcpiInitialization (); } -/** - Save the S3 boot script. - - Note that DxeSmmReadyToLock must be signaled after this function returns; - otherwise the script wouldn't be saved actually. -**/ -STATIC -VOID -SaveS3BootScript ( - VOID - ) -{ - EFI_STATUS Status; - EFI_S3_SAVE_STATE_PROTOCOL *BootScript; - STATIC CONST UINT8 Info[] = { 0xDE, 0xAD, 0xBE, 0xEF }; - - Status = gBS->LocateProtocol (&gEfiS3SaveStateProtocolGuid, NULL, - (VOID **) &BootScript); - ASSERT_EFI_ERROR (Status); - - // - // Despite the opcode documentation in the PI spec, the protocol - // implementation embeds a deep copy of the info in the boot script, rather - // than storing just a pointer to runtime or NVS storage. - // - Status = BootScript->Write(BootScript, EFI_BOOT_SCRIPT_INFORMATION_OPCODE, - (UINT32) sizeof Info, - (EFI_PHYSICAL_ADDRESS)(UINTN) &Info); - ASSERT_EFI_ERROR (Status); -} - - /** Do the platform specific action after the console is ready diff --git a/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.c b/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.c index 5cbb47687b..4514641b46 100644 --- a/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.c +++ b/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.c @@ -495,29 +495,6 @@ FindPeiCoreImageBaseInFv ( return EFI_SUCCESS; } - -/** - Reads 8-bits of CMOS data. - - Reads the 8-bits of CMOS data at the location specified by Index. - The 8-bit read value is returned. - - @param Index The CMOS location to read. - - @return The value read. - -**/ -STATIC -UINT8 -CmosRead8 ( - IN UINTN Index - ) -{ - IoWrite8 (0x70, (UINT8) Index); - return IoRead8 (0x71); -} - - STATIC BOOLEAN IsS3Resume ( -- 2.19.1.windows.1