From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 4684C9413BA for ; Fri, 22 Sep 2023 07:33:52 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=bzS7FZVj0Z9t4PZugDZ/XJQqkImVKX0OHnJKA886jxw=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20140610; t=1695368031; v=1; b=ikcekkUW52rAwIYvFOOUMXJ+TCKWVbHCv8nAMSrNv8C77HjIAHwad9V02Yv0hlWHowqdYP76 pRUFZO4vQzeJvijFKINBcD9p0dVRErx71NsOzY9cez3FIEc1v0gplFClCtn9CyUxeXkWerZjfCF OaKJ42zI5s6g3KhZLz0HfFX8= X-Received: by 127.0.0.2 with SMTP id KA0CYY7687511x0UQT2QBX3A; Fri, 22 Sep 2023 00:33:51 -0700 X-Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by mx.groups.io with SMTP id smtpd.web10.16126.1695368029357202464 for ; Fri, 22 Sep 2023 00:33:50 -0700 X-Received: from loongson.cn (unknown [10.40.24.149]) by gateway (Coremail) with SMTP id _____8BxXetbQw1l8M0qAA--.11620S3; Fri, 22 Sep 2023 15:33:47 +0800 (CST) X-Received: from [10.40.24.149] (unknown [10.40.24.149]) by localhost.localdomain (Coremail) with SMTP id AQAAf8Dxvi9YQw1lWN0NAA--.28448S3; Fri, 22 Sep 2023 15:33:45 +0800 (CST) Message-ID: Date: Fri, 22 Sep 2023 15:33:44 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [edk2-devel] [PATCH] BaseTools/GenFw: Add support for LOONGARCH64 relax relocation To: devel@edk2.groups.io, qiandongyan@loongson.cn Cc: Rebecca Cran , Liming Gao , Bob Feng , Yuwei Chen References: <20230922072758.1509120-1-qiandongyan@loongson.cn> From: "Chao Li" In-Reply-To: <20230922072758.1509120-1-qiandongyan@loongson.cn> X-CM-TRANSID: AQAAf8Dxvi9YQw1lWN0NAA--.28448S3 X-CM-SenderInfo: xolfxt3r6o00pqjv00gofq/1tbiAQACCGUM+aMGUQACst X-Coremail-Antispam: 1Uk129KBj93XoWxWFyUCrWxGr1kKF4UuFyfGrX_yoW5WrWDpF 1Uur45AF4kuFsru3ZIqF18C3ZxXryvkrW8JrWUAryUWF1DJ34Ikr13X3ZxKFWUGrnYvF1F 9rn3uw18G34DArbCm3ZEXasCq-sJn29KB7ZKAUJUUUU8529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3UbIjqfuFe4nvWSU5nxnvy29KBjDU0xBIdaVrnRJUUUv0b4IE77IF4wAF F20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2IYs7xG6rWj6s0DM7CIcVAFz4kK6r 106r15M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48ve4kI8wA2z4x0Y4vE2Ix0cI8IcVAF wI0_Jr0_JF4l84ACjcxK6xIIjxv20xvEc7CjxVAFwI0_Gr0_Cr1l84ACjcxK6I8E87Iv67 AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVCY1x0267AKxVW8Jr0_Cr1UM2AIxVAIcxkEcVAq 07x20xvEncxIr21l57IF6xkI12xvs2x26I8E6xACxx1lYx0E2Ix0cI8IcVAFwI0_Jr0_Jr 4lYx0Ex4A2jsIE14v26r1j6r4UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvEwIxGrwCj r7xvwVCIw2I0I7xG6c02F41lc7I2V7IY0VAS07AlzVAYIcxG8wCF04k20xvY0x0EwIxGrw CFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14v26r106r1rMI8I3I0E7480Y4vE 14v26r106r1rMI8E67AF67kF1VAFwI0_JF0_Jw1lIxkGc2Ij64vIr41lIxAIcVC0I7IYx2 IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Jr0_Gr1lIxAIcVCF04k26cxK x2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r1j6r4UMIIF0xvEx4A2jsIEc7CjxVAFwI 0_Jr0_GrUvcSsGvfC2KfnxnUUI43ZEXa7IU1Au4UUUUUU== Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lichao@loongson.cn List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 0gAdRASWMiFj1Jv2QlV9nsYEx7686176AA= Content-Type: multipart/alternative; boundary="------------0gI5H0qweSgy9JqyIrjor0Jm" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=ikcekkUW; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io --------------0gI5H0qweSgy9JqyIrjor0Jm Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Reviewed-by: Chao Li Thanks, Chao 在 2023/9/22 15:27, Dongyan Qian 写道: > Correct relax id from 99 to 100 and added relocation support up to 109 > > fix gcc14 adds new relocation, and the generated relocation > causes the build and compilation to fail. > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4559 > > Cc: Rebecca Cran > Cc: Liming Gao > Cc: Bob Feng > Cc: Yuwei Chen > Cc: Chao Li > Signed-off-by: Dongyan Qian > --- > BaseTools/Source/C/GenFw/Elf64Convert.c | 20 ++++++++++++++++++++ > BaseTools/Source/C/GenFw/elf_common.h | 13 ++++++++++++- > 2 files changed, 32 insertions(+), 1 deletion(-) > > diff --git a/BaseTools/Source/C/GenFw/Elf64Convert.c b/BaseTools/Source/C/GenFw/Elf64Convert.c > index d53ecb1767..9911db65af 100644 > --- a/BaseTools/Source/C/GenFw/Elf64Convert.c > +++ b/BaseTools/Source/C/GenFw/Elf64Convert.c > @@ -1778,7 +1778,17 @@ WriteSections64 ( > case R_LARCH_TLS_LD64_HI20: > case R_LARCH_TLS_GD_PC_HI20: > case R_LARCH_TLS_GD64_HI20: > + case R_LARCH_32_PCREL: > case R_LARCH_RELAX: > + case R_LARCH_DELETE: > + case R_LARCH_ALIGN: > + case R_LARCH_PCREL20_S2: > + case R_LARCH_CFA: > + case R_LARCH_ADD6: > + case R_LARCH_SUB6: > + case R_LARCH_ADD_ULEB128: > + case R_LARCH_SUB_ULEB128: > + case R_LARCH_64_PCREL: > // > // These types are not used or do not require fixup. > // > @@ -2185,7 +2195,17 @@ WriteRelocations64 ( > case R_LARCH_TLS_LD64_HI20: > case R_LARCH_TLS_GD_PC_HI20: > case R_LARCH_TLS_GD64_HI20: > + case R_LARCH_32_PCREL: > case R_LARCH_RELAX: > + case R_LARCH_DELETE: > + case R_LARCH_ALIGN: > + case R_LARCH_PCREL20_S2: > + case R_LARCH_CFA: > + case R_LARCH_ADD6: > + case R_LARCH_SUB6: > + case R_LARCH_ADD_ULEB128: > + case R_LARCH_SUB_ULEB128: > + case R_LARCH_64_PCREL: > // > // These types are not used or do not require fixup in PE format files. > // > diff --git a/BaseTools/Source/C/GenFw/elf_common.h b/BaseTools/Source/C/GenFw/elf_common.h > index ccd32804b0..e4d0cdac4f 100644 > --- a/BaseTools/Source/C/GenFw/elf_common.h > +++ b/BaseTools/Source/C/GenFw/elf_common.h > @@ -1144,5 +1144,16 @@ typedef struct { > #define R_LARCH_TLS_LD64_HI20 96 > #define R_LARCH_TLS_GD_PC_HI20 97 > #define R_LARCH_TLS_GD64_HI20 98 > -#define R_LARCH_RELAX 99 > +#define R_LARCH_32_PCREL 99 > +#define R_LARCH_RELAX 100 > +#define R_LARCH_DELETE 101 > +#define R_LARCH_ALIGN 102 > +#define R_LARCH_PCREL20_S2 103 > +#define R_LARCH_CFA 104 > +#define R_LARCH_ADD6 105 > +#define R_LARCH_SUB6 106 > +#define R_LARCH_ADD_ULEB128 107 > +#define R_LARCH_SUB_ULEB128 108 > +#define R_LARCH_64_PCREL 109 > + > #endif /* !_SYS_ELF_COMMON_H_ */ -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108981): https://edk2.groups.io/g/devel/message/108981 Mute This Topic: https://groups.io/mt/101516908/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=- --------------0gI5H0qweSgy9JqyIrjor0Jm Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

Reviewed-by: Chao Li <lichao@loongson.cn>


Thanks,
Chao
在 2023/9/22 15:27, Dongyan Qian 写道:
Correct relax id from 99 to 100 and added relocation support up to 109

fix gcc14 adds new relocation, and the generated relocation
causes the build and compilation to fail.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4559

Cc: Rebecca Cran <rebecca@bsdio.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Bob Feng <bob.c.feng@intel.com>
Cc: Yuwei Chen <yuwei.chen@intel.com>
Cc: Chao Li <lichao@loongson.cn>
Signed-off-by: Dongyan Qian <qiandongyan@loongson.cn>
---
 BaseTools/Source/C/GenFw/Elf64Convert.c | 20 ++++++++++++++++++++
 BaseTools/Source/C/GenFw/elf_common.h   | 13 ++++++++++++-
 2 files changed, 32 insertions(+), 1 deletion(-)

diff --git a/BaseTools/Source/C/GenFw/Elf64Convert.c b/BaseTools/Source/C/GenFw/Elf64Convert.c
index d53ecb1767..9911db65af 100644
--- a/BaseTools/Source/C/GenFw/Elf64Convert.c
+++ b/BaseTools/Source/C/GenFw/Elf64Convert.c
@@ -1778,7 +1778,17 @@ WriteSections64 (
           case R_LARCH_TLS_LD64_HI20:
           case R_LARCH_TLS_GD_PC_HI20:
           case R_LARCH_TLS_GD64_HI20:
+          case R_LARCH_32_PCREL:
           case R_LARCH_RELAX:
+          case R_LARCH_DELETE:
+          case R_LARCH_ALIGN:
+          case R_LARCH_PCREL20_S2:
+          case R_LARCH_CFA:
+          case R_LARCH_ADD6:
+          case R_LARCH_SUB6:
+          case R_LARCH_ADD_ULEB128:
+          case R_LARCH_SUB_ULEB128:
+          case R_LARCH_64_PCREL:
             //
             // These types are not used or do not require fixup.
             //
@@ -2185,7 +2195,17 @@ WriteRelocations64 (
               case R_LARCH_TLS_LD64_HI20:
               case R_LARCH_TLS_GD_PC_HI20:
               case R_LARCH_TLS_GD64_HI20:
+              case R_LARCH_32_PCREL:
               case R_LARCH_RELAX:
+              case R_LARCH_DELETE:
+              case R_LARCH_ALIGN:
+              case R_LARCH_PCREL20_S2:
+              case R_LARCH_CFA:
+              case R_LARCH_ADD6:
+              case R_LARCH_SUB6:
+              case R_LARCH_ADD_ULEB128:
+              case R_LARCH_SUB_ULEB128:
+              case R_LARCH_64_PCREL:
                 //
                 // These types are not used or do not require fixup in PE format files.
                 //
diff --git a/BaseTools/Source/C/GenFw/elf_common.h b/BaseTools/Source/C/GenFw/elf_common.h
index ccd32804b0..e4d0cdac4f 100644
--- a/BaseTools/Source/C/GenFw/elf_common.h
+++ b/BaseTools/Source/C/GenFw/elf_common.h
@@ -1144,5 +1144,16 @@ typedef struct {
 #define R_LARCH_TLS_LD64_HI20              96
 #define R_LARCH_TLS_GD_PC_HI20             97
 #define R_LARCH_TLS_GD64_HI20              98
-#define R_LARCH_RELAX                      99
+#define R_LARCH_32_PCREL                   99
+#define R_LARCH_RELAX                      100
+#define R_LARCH_DELETE                     101
+#define R_LARCH_ALIGN                      102
+#define R_LARCH_PCREL20_S2                 103
+#define R_LARCH_CFA                        104
+#define R_LARCH_ADD6                       105
+#define R_LARCH_SUB6                       106
+#define R_LARCH_ADD_ULEB128                107
+#define R_LARCH_SUB_ULEB128                108
+#define R_LARCH_64_PCREL                   109
+
 #endif /* !_SYS_ELF_COMMON_H_ */
_._,_._,_
Groups.io Links:

You receive all messages sent to this group.

View/Reply Online (#108981) | | Mute This Topic | New Topic
Your Subscription | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--------------0gI5H0qweSgy9JqyIrjor0Jm--