From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (NAM11-CO1-obe.outbound.protection.outlook.com [40.107.220.97]) by mx.groups.io with SMTP id smtpd.web10.71129.1684085078865613206 for ; Sun, 14 May 2023 10:24:39 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="no key for verify" header.i=@amperemail.onmicrosoft.com header.s=selector1-amperemail-onmicrosoft-com header.b=unqm107x; spf=pass (domain: os.amperecomputing.com, ip: 40.107.220.97, mailfrom: tinhnguyen@os.amperecomputing.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GRmnpTm0VLgFcRgqsHf29Xjfp7kMnCmxijZsxviKc/aUc9Kq3HfQHEEQnkVepR/3Bs02Csf6JN8SVpIu0j1iDHk4OZf4MAa3ZkC8Vo/PueKWypciQo874mfEXHQec4QuBoycyM+cAsablAmC8k3PhwXOhP+m6PTLhmUtq7uSY6z17fYS+3+RjHsiloU2xPUDY0+xbDdRIM6ydbr7LCzwFtjZOkFPkW2qAwUB9BjOrqG4YLKc3jITOTV8CPxtdbIhMW1JKAhhDo3/vtBuq3e1vsVkj7DCXVztBgSHbxdfswH6cIPWKQHmyVTng8ZuQ7Ympn7GW+wfYFjJvb+aNQY0ng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=6Gzqlcatodnb5P5gh41DQzq4lwAzaQhU68XWTnioopg=; b=kVKC6OFB/Spopiu6YB85FwVHSZKXsSVkBI5NZDUdrqUrctw5YaVTx6Hn21clszHvIWxAwsUZLESAqZy8xqrCGKF2OUl49ix82gk8GG8rINs3EgCT1mTkP7pCLuqW2HWlBDZpzzg3rfhnbU0DGNwjVguRkGwvL5cWPbY3KpCMWuf7qd5YyPK7KnxkBFGA2qoTYXtnkqmvWFPyj82QLpNDIwMtt5wdoFYFylxGNWjCLnR7RMEwTNIzw6zQWtzu5p1VJypg9Tla5b9UmaiUzew7dlBJVYmQDGDpC4GsYBg93/7+gqroPsYEo7HSOb7yy9ai+FC7Gn5Jy2Ay1XSXhhzcWg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=os.amperecomputing.com; dmarc=pass action=none header.from=amperemail.onmicrosoft.com; dkim=pass header.d=amperemail.onmicrosoft.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amperemail.onmicrosoft.com; s=selector1-amperemail-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6Gzqlcatodnb5P5gh41DQzq4lwAzaQhU68XWTnioopg=; b=unqm107xpVnb4H7O/gQ6MUnx/ufeFWUd+toL+WiZ49yBWmQUpnIgTPRIkZ6TrPtxN7oD4f2IXwAWLWmG2DMTp5yXJ3J8kyBdZXNy+0JwilcwhQbkjf9prwDcViZefL4skPJrgFA08pt8o4IebAaC2jBhD8Ag5wPtZndLiZZQELc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amperemail.onmicrosoft.com; Received: from DM5PR0102MB3336.prod.exchangelabs.com (2603:10b6:4:9f::11) by DM6PR01MB5497.prod.exchangelabs.com (2603:10b6:5:151::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.19; Sun, 14 May 2023 17:24:36 +0000 Received: from DM5PR0102MB3336.prod.exchangelabs.com ([fe80::fefc:e2a9:e823:fe42]) by DM5PR0102MB3336.prod.exchangelabs.com ([fe80::fefc:e2a9:e823:fe42%6]) with mapi id 15.20.6387.020; Sun, 14 May 2023 17:24:36 +0000 Message-ID: Date: Mon, 15 May 2023 00:24:28 +0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Subject: Re: [edk2-devel] [edk2-platforms][PATCH 2/2] ManageabilityPkg/IpmiBmcElog: Add to ManageabilityPkg To: devel@edk2.groups.io, abner.chang@amd.com Cc: Isaac Oram , Abdul Lateef Attar , Nickle Wang References: <20230512095819.1898-1-abner.chang@amd.com> <20230512095819.1898-2-abner.chang@amd.com> From: "Tinh Nguyen" In-Reply-To: <20230512095819.1898-2-abner.chang@amd.com> X-ClientProxiedBy: SI2PR01CA0015.apcprd01.prod.exchangelabs.com (2603:1096:4:191::15) To DM5PR0102MB3336.prod.exchangelabs.com (2603:10b6:4:9f::11) Return-Path: tinhnguyen@os.amperecomputing.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM5PR0102MB3336:EE_|DM6PR01MB5497:EE_ X-MS-Office365-Filtering-Correlation-Id: a8f17840-133b-4520-f712-08db54a01726 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: yMt9ASyzatl3fsWr/0RE8G8s2v1UWVAIWw9wX8uarc9C6KLno72Ox6TGu70fuK5I9ObFFCNsoIKW6ry3YoaeFO/5AlPy3SMzcvfWMR7nTG5EVyiwhxHwt65oFIfziY9dS9qpfwXPRbR6z3B2AiizChl4Ssvv1m1DEWqtPfAkHjwXpLsaYAYt4V0p/4+9SHj2o1hTMRQ+5lY5THzuoVslOCe2DUGJKMfJ6YZrcIX5oS5uLWa7KGEtvE2Hj+9M6gQEODCmskOrPeaKTSmMCSwrnQqzObmESqlYQOR+P/khXF6Kw+SbYetqQ3dzfQr83WD24dydh5+yge1VHbZmB4SM74lPlQTQR8eoe634VJ/mtE/yJ0IB0IwfpapS0JIk147S/1CH1ba8gGHm+gzJrX2UVDUpUiTpvTeoLI2iPc1MdcDzHzfdD7ms5bXP4OMx1owrUQDz+WgyuvbcfJOMwtQ4Prdj1UJsnUqnmZtb+qHuh0Rr/P3p9+JeI/BjDP4HDOhy2CdwIOHoIa73lIhs0cxvewzIab0fwLolDry0xfO7B+5HAjYy/xwTTjo562xkAvlvjfgzxD7Pqd1Njqq/NqyclcMaaZ5+W2DCRQr9frd4W8DfVpFpXddrvKifWHDzOl+M X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM5PR0102MB3336.prod.exchangelabs.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(39840400004)(136003)(346002)(366004)(376002)(396003)(451199021)(2906002)(31696002)(6512007)(53546011)(6506007)(478600001)(26005)(186003)(5660300002)(6666004)(6486002)(83170400001)(38100700002)(42882007)(4326008)(66476007)(66946007)(2616005)(41300700001)(316002)(66556008)(54906003)(31686004)(8676002)(8936002)(43740500002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aGQvdXN6NjRrQ1RBMlFaUFJPclJ6T3RzWkgvWkM1aHhQL25qejVUbTMrdlJL?= =?utf-8?B?cDhkR081UFYxemhETlZHODh5Ujdic3FOWlBub2YrU0N2Z0l5LzR5SVFma2Nq?= =?utf-8?B?TkpHcmVsZGptZi9CdmkrU09uei9FRzM0eHpVM1lUWkVOVENRMHVoaEZIcVd3?= =?utf-8?B?VC9vaG90aVE1eXhKaVlXSkVBQXJxODVGVCtWbHdib2ZXUVRhNG1xK3VCU1M4?= =?utf-8?B?R3ptVTZ1Q28yejBST0ZtSTNVRi9PL0NTNnk2ZVpWUWE5NGE2UmYrcjhqbzgz?= =?utf-8?B?bmJaSjI5SmhJYzNQWjN1UkhaVG9ZZUZBMGh1Tm5KK0gwRGw5SkZOZXpDc2Rs?= =?utf-8?B?dmxPYlA1aHlVUjRNeUppYmJ2NE05TEJLVDYxTFVteUJUSUVrUGJtaTFmY3o4?= =?utf-8?B?MG9lMDRnbkw3bXZsNGpaaDVJQUJlaEhYTmxDUlgxK1piVDcrU1BQNjkxMDN1?= =?utf-8?B?YkFyT3cydzNiVWJwMGVJelQ5c01wSjAxT1JhMEN1TEx0ZE9LbXBTUGxrWHl4?= =?utf-8?B?ZFB4MXdveVJ3UTFMdUxNQzZRRk5YcWE3bFViUjE4K0F3NW5jRFF6Y1ZXUzFn?= =?utf-8?B?SVJPYTR2cC9GaG4xQURRRklGTHRldnJVRnZzd1ZhZTc1SklGc0pyb3BpZEli?= =?utf-8?B?OVlWazl6OXNHTE9IS1BhV1NoOEpueU1YbDEzOHBLenF2UmQ2QWtBNEtab1hC?= =?utf-8?B?eFBlVks5UHZtc0lacHdSNWhubFRFc1hDYWJJMDJHN0RVb3NPS05aZHlYTWly?= =?utf-8?B?K1hZMnN2V3ZHUTMzMWgwZGRrUFlKWHoyWFJwNk4yM002OGxBTTJaRVpub3Jw?= =?utf-8?B?SEpEdjQrZ3dvRWJ4NmdnL3dmK25IdSs0eHJwcDJaSDBUTUxMcWZ3RndWb09X?= =?utf-8?B?eDFlaWpoZTZ0UWNYWnZZZmZhUFRzVmJLdlg1S1IvWUlzb3BTOGU2U3Qxc2d5?= =?utf-8?B?RmlSbmIvc3BMdHlPamNhSU9CSzlGazVjenNXRVB4QWMzTDZYdlFpcGQ1K0dK?= =?utf-8?B?WE9YMWprWktuQm1hOW1STzRZYWdJcE05Z2VBdXhJdXFnd0t6OFQ4T2RwV0hj?= =?utf-8?B?a3VTKytRRzhVdVZwem5tQWN6czVPVHFMZ1QvODY0YThFNkRCSkZ0S241cXFW?= =?utf-8?B?ZW05dHd6NFVhYUFnSG81a2FoQjUxMENYVWk4V0JFOTlsMHVlS3NiNXd6Q2Ir?= =?utf-8?B?UUZFdlc0U01sSkRNd3U1MHVMWmJ5cnl6cDE5RWdZSThxdFlPRnBDWW92VWhq?= =?utf-8?B?MHhhZlh0a0tkeDlSb3AxSVgrMWlDd2pXYk5wRzUvNUVscENOWFlpY09XR3Vk?= =?utf-8?B?bjZFVDZUZGh3d0xabEorSzduNTBkK0ZiN0FQSWhUVjFvblBJTTNnL3Fxa1dI?= =?utf-8?B?aEp3L2h0MnRVeFlPcUNpVXNtY0FMYW5EWUdqTzRSL0M5Q1ZrRERWdjgvZ1NC?= =?utf-8?B?L09KbFd6bHNKL1ZjcDRyUEJhcDI2Y3FKTE1vak15M1NoYmE4ZTVrL3YrTFZa?= =?utf-8?B?SkJvY0V1YXFkdC9BWlF1MXZiU1ZzU0wzcjU0Y1ZzYjFXUTVxVk1OQlJHeW1y?= =?utf-8?B?QmlrejQzL2JIQ2wrTkIxYW9PZkhCakZQZ0V2bmdRVUxYdGN6WC9jaEtLWVlF?= =?utf-8?B?VkFnNk50Wmc3eFowakRiVmlEQkxyY0MwTDE4R0l1aWNyMEc3dkNyZ1JrdzRS?= =?utf-8?B?TmJGZERvVUc2Y2d3SW9UUWlhVjd6Rm1oNmt2OXFGNWFhekUrRkdXczZUbVZo?= =?utf-8?B?OCttS2xHdXNTT1hadWkzWDUwd25tZ1ZQZVBZOGRmQTFUZ1ZyRGh5RG8zTHFF?= =?utf-8?B?dCtRaTZ4dE9qSExvWVVlZE5DZ3g3dEQxdHlTWVo2TklRdVZLMzNGbk82YUo2?= =?utf-8?B?YThGQmJIRlpzaGpqVjA3ZVRZZWwrNlZnanhzTVltSFNLL20xclZYVlI5bXhC?= =?utf-8?B?MkFVVTBQbDRkdWE0V0EzQWFXbngyQjRVZ0JMU1VaM3hWUDVTeEhUZnRWRkhG?= =?utf-8?B?S09VMWVrN0NrcENwUkY3amRpaDNZa2ViMXUzM2F0V21xaWdCbjdZaFB0TkpH?= =?utf-8?B?QWJiZ1docktMRnN3SG9sS0lJNlAreEo5QTF0NEg0OUlBS3JrTDRoaTBOTWJw?= =?utf-8?B?djhyaVhvNkgybHdBRk16S0NEeVVVZldzS2h0VjY1V0psQVp2ZTVwQ1hLWkNi?= =?utf-8?Q?KM0wwIXJ2/Y8OY1zK4tXVsU=3D?= X-OriginatorOrg: amperemail.onmicrosoft.com X-MS-Exchange-CrossTenant-Network-Message-Id: a8f17840-133b-4520-f712-08db54a01726 X-MS-Exchange-CrossTenant-AuthSource: DM5PR0102MB3336.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 May 2023 17:24:36.6119 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3bc2b170-fd94-476d-b0ce-4229bdc904a7 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: xJerZYdUNqIRYSDIp7RFIKDq6wCMErl06Gt5H6EExh4Lg7HNKkhE+e/HEmZbMCHf+VQuOG5uKapot6LDKaN+XtSnul+rw9vYsATdtWQiRdJSactIXFYq2ZLQgMT9buCm X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR01MB5497 Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Reviewed-by: Tinh Nguyen Regards, - Tinh On 12/05/2023 16:58, Chang, Abner via groups.io wrote: > From: Abner Chang > > Add IpmiBmcElog to ManageabilityPkg. > > Signed-off-by: Abner Chang > Cc: Isaac Oram > Cc: Abdul Lateef Attar > Cc: Nickle Wang > --- > Features/ManageabilityPkg/ManageabilityPkg.dec | 1 + > Features/ManageabilityPkg/Include/Manageability.dsc | 4 ++++ > Features/ManageabilityPkg/ManageabilityPkg.dsc | 2 ++ > Features/ManageabilityPkg/Include/PostMemory.fdf | 4 ++++ > 4 files changed, 11 insertions(+) > > diff --git a/Features/ManageabilityPkg/ManageabilityPkg.dec b/Features/ManageabilityPkg/ManageabilityPkg.dec > index 38813c5f48..7c36ec93ff 100644 > --- a/Features/ManageabilityPkg/ManageabilityPkg.dec > +++ b/Features/ManageabilityPkg/ManageabilityPkg.dec > @@ -79,4 +79,5 @@ > gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxePldmEnable|FALSE|BOOLEAN|0x10000004 > gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxeMctpEnable|FALSE|BOOLEAN|0x10000005 > gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxePldmSmbiosTransferEnable|FALSE|BOOLEAN|0x10000006 > + gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxeIpmiBmcElog|FALSE|BOOLEAN|0x1000000A > > diff --git a/Features/ManageabilityPkg/Include/Manageability.dsc b/Features/ManageabilityPkg/Include/Manageability.dsc > index a432b0ff26..6806093d98 100644 > --- a/Features/ManageabilityPkg/Include/Manageability.dsc > +++ b/Features/ManageabilityPkg/Include/Manageability.dsc > @@ -51,3 +51,7 @@ > !if gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxeMctpEnable == TRUE > ManageabilityPkg/Universal/MctpProtocol/Dxe/MctpProtocolDxe.inf > !endif > + > +!if gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxeIpmiBmcElog == TRUE > + ManageabilityPkg/Universal/IpmiBmcElog/BmcElog.inf > +!endif > diff --git a/Features/ManageabilityPkg/ManageabilityPkg.dsc b/Features/ManageabilityPkg/ManageabilityPkg.dsc > index e3baf27f2a..2262362f97 100644 > --- a/Features/ManageabilityPkg/ManageabilityPkg.dsc > +++ b/Features/ManageabilityPkg/ManageabilityPkg.dsc > @@ -37,6 +37,7 @@ > gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxePldmEnable |TRUE > gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxeMctpEnable |TRUE > gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxePldmSmbiosTransferEnable|TRUE > + gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxeIpmiBmcElog |TRUE > > # > # Include common libraries > @@ -53,5 +54,6 @@ > > [LibraryClasses] > ManageabilityTransportLib|ManageabilityPkg/Library/BaseManageabilityTransportNullLib/BaseManageabilityTransportNull.inf > + IpmiLib|MdeModulePkg/Library/BaseIpmiLibNull/BaseIpmiLibNull.inf > > !include Include/Manageability.dsc > diff --git a/Features/ManageabilityPkg/Include/PostMemory.fdf b/Features/ManageabilityPkg/Include/PostMemory.fdf > index 9100cb2646..e4eed660fd 100644 > --- a/Features/ManageabilityPkg/Include/PostMemory.fdf > +++ b/Features/ManageabilityPkg/Include/PostMemory.fdf > @@ -26,3 +26,7 @@ > !if gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxeMctpEnable == TRUE > INF ManageabilityPkg/Universal/MctpProtocol/Dxe/MctpProtocolDxe.inf > !endif > + > +!if gManageabilityPkgTokenSpaceGuid.PcdManageabilityDxeIpmiBmcElog == TRUE > + INF ManageabilityPkg/Universal/IpmiBmcElog/BmcElog.inf > +!endif