public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: devel@edk2.groups.io, ardb@kernel.org
Cc: "Kinney, Michael D" <michael.d.kinney@intel.com>,
	 Laszlo Ersek <lersek@redhat.com>, "Ni, Ray" <ray.ni@intel.com>
Subject: Re: [edk2-devel] PR fails due to OVMF time out
Date: Mon, 3 Apr 2023 12:37:34 +0200	[thread overview]
Message-ID: <ehbt7v5wtshg6xoiya5yqk6pqnpuqsnevt6w6qadthf6dczlc4@jpqn3agswsnv> (raw)
In-Reply-To: <CAMj1kXFs8_fzZz1F+uQjZviY21ZnG4wNeSD76bPe4+qsrH8giQ@mail.gmail.com>

On Mon, Apr 03, 2023 at 10:21:27AM +0200, Ard Biesheuvel wrote:
> On Sun, 2 Apr 2023 at 20:23, Kinney, Michael D
> <michael.d.kinney@intel.com> wrote:
> >
> > Hi Gerd,
> >
> > I have investigated this failure with enabling -smp 4.  I think this is an
> > important feature that should be on by default.
> >
> 
> Agreed. And given your investigation below (thanks!), we should be
> able to revert the revert as long as we add '-accel
> tcg,thread-single', right?

That is how I read it, yes.

> It would be nice if we could also get some coverage for KVM, but for
> the time being, this seems to be an improvement already (AFAIU, we
> want -smp 4 primarily for the logic used in the code, while there is
> very little code that would actually run concurrently, if any)

Yes, it's to improve MpInit test coverage.  Most code would continue to
run single-threaded.

take care,
  Gerd


  reply	other threads:[~2023-04-03 10:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-31 15:00 PR fails due to OVMF time out Ni, Ray
2023-03-31 19:46 ` Gerd Hoffmann
2023-04-02 18:23   ` Michael D Kinney
2023-04-03  8:21     ` Ard Biesheuvel
2023-04-03 10:37       ` Gerd Hoffmann [this message]
2023-04-04 20:04         ` [edk2-devel] " Michael D Kinney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ehbt7v5wtshg6xoiya5yqk6pqnpuqsnevt6w6qadthf6dczlc4@jpqn3agswsnv \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox