From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124])
 by mx.groups.io with SMTP id smtpd.web10.66713.1680518260480157830
 for <devel@edk2.groups.io>;
 Mon, 03 Apr 2023 03:37:41 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=W4j1+woV;
 spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: kraxel@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1680518259;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=7ARk3GPqSlY4wHTh43SH5nLdWzUJ0L+3FrMcXsXU5bU=;
	b=W4j1+woVsrRIbxwk8ai+qN2YwZfz3s2ji2zXx8dLfLsxkWdXtvBp/903uoVxsMm0eSkQqR
	YljBNACCLCYYQynQBflGEWHrmA00ZoYzT29GpIO+UdTYKuIvjaligW+VkIr9CRJzC/7IWv
	kuptino+ZFt+0QuIIng5uUBhaN7R1so=
Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com
 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-529-3NV9AuA2M1GisvpQh7s3Vw-1; Mon, 03 Apr 2023 06:37:36 -0400
X-MC-Unique: 3NV9AuA2M1GisvpQh7s3Vw-1
Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx02.redhat.com (Postfix) with ESMTPS id B0B373C025AC;
	Mon,  3 Apr 2023 10:37:35 +0000 (UTC)
Received: from sirius.home.kraxel.org (unknown [10.39.193.241])
	by smtp.corp.redhat.com (Postfix) with ESMTPS id 7290840C6EC4;
	Mon,  3 Apr 2023 10:37:35 +0000 (UTC)
Received: by sirius.home.kraxel.org (Postfix, from userid 1000)
	id 277161800393; Mon,  3 Apr 2023 12:37:34 +0200 (CEST)
Date: Mon, 3 Apr 2023 12:37:34 +0200
From: "Gerd Hoffmann" <kraxel@redhat.com>
To: devel@edk2.groups.io, ardb@kernel.org
Cc: "Kinney, Michael D" <michael.d.kinney@intel.com>, 
	Laszlo Ersek <lersek@redhat.com>, "Ni, Ray" <ray.ni@intel.com>
Subject: Re: [edk2-devel] PR fails due to OVMF time out
Message-ID: <ehbt7v5wtshg6xoiya5yqk6pqnpuqsnevt6w6qadthf6dczlc4@jpqn3agswsnv>
References: <MN6PR11MB8244CEF10A845A1EC2B8AFCF8C8F9@MN6PR11MB8244.namprd11.prod.outlook.com>
 <hhigti55nalqi2gzp6la23jdk5lfrji75iftprjbcy7zwfg775@yr6n5edvst5f>
 <CO1PR11MB49293D2949B04786EBEFA93CD28D9@CO1PR11MB4929.namprd11.prod.outlook.com>
 <CAMj1kXFs8_fzZz1F+uQjZviY21ZnG4wNeSD76bPe4+qsrH8giQ@mail.gmail.com>
MIME-Version: 1.0
In-Reply-To: <CAMj1kXFs8_fzZz1F+uQjZviY21ZnG4wNeSD76bPe4+qsrH8giQ@mail.gmail.com>
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Apr 03, 2023 at 10:21:27AM +0200, Ard Biesheuvel wrote:
> On Sun, 2 Apr 2023 at 20:23, Kinney, Michael D
> <michael.d.kinney@intel.com> wrote:
> >
> > Hi Gerd,
> >
> > I have investigated this failure with enabling -smp 4.  I think this is an
> > important feature that should be on by default.
> >
> 
> Agreed. And given your investigation below (thanks!), we should be
> able to revert the revert as long as we add '-accel
> tcg,thread-single', right?

That is how I read it, yes.

> It would be nice if we could also get some coverage for KVM, but for
> the time being, this seems to be an improvement already (AFAIU, we
> want -smp 4 primarily for the logic used in the code, while there is
> very little code that would actually run concurrently, if any)

Yes, it's to improve MpInit test coverage.  Most code would continue to
run single-threaded.

take care,
  Gerd