From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id D2673D80CF6 for ; Fri, 1 Mar 2024 10:59:50 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=MVl1DAANvlqCQlaeKk/0MfZmlS35gaKuyCEUTxlIVqE=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20140610; t=1709290789; v=1; b=kJE8Izg1vIsTDetUMVPnwHgyBqPpgZ1TyTm/Eln/9j1lijcXQTyjhb6w6g3cv4fCpTETC9Lx MehzRfuQhauxgqD8URBdsQIhayfK1UT9M9f8Hwrkv0h+EUi7GMYKtdydr+3ewjFh8OvRQjfV8nd 3HAG5ayuh2cbSeMJv1WC3Z/c= X-Received: by 127.0.0.2 with SMTP id MyB9YY7687511x9Bh55HdF6R; Fri, 01 Mar 2024 02:59:49 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web10.19886.1709290788517678395 for ; Fri, 01 Mar 2024 02:59:48 -0800 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-557-VSIN0QavPhCymqEHhU8tgw-1; Fri, 01 Mar 2024 05:59:42 -0500 X-MC-Unique: VSIN0QavPhCymqEHhU8tgw-1 X-Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9F385800074; Fri, 1 Mar 2024 10:59:41 +0000 (UTC) X-Received: from sirius.home.kraxel.org (unknown [10.39.192.121]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AA0EC4D904; Fri, 1 Mar 2024 10:59:40 +0000 (UTC) X-Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 7A8661800DFF; Fri, 1 Mar 2024 11:59:39 +0100 (CET) Date: Fri, 1 Mar 2024 11:59:39 +0100 From: "Gerd Hoffmann" To: Tom Lendacky Cc: devel@edk2.groups.io, Ard Biesheuvel , Erdem Aktas , Jiewen Yao , Laszlo Ersek , Liming Gao , Michael D Kinney , Min Xu , Zhiguang Liu , Rahul Kumar , Ray Ni , Michael Roth Subject: Re: [edk2-devel] [PATCH v2 14/23] Ovmfpkg/CcSvsmLib: Create CcSvsmLib to handle SVSM related services Message-ID: References: <56d5ceff99e0be9e4e261476deba6a9b01da5c81.1708623001.git.thomas.lendacky@amd.com> <9c7bca53-5099-4128-8630-bb8c17691f65@amd.com> MIME-Version: 1.0 In-Reply-To: <9c7bca53-5099-4128-8630-bb8c17691f65@amd.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,kraxel@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: dCZ28fKzP6jLcfMLC2h4xvmyx7686176AA= Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=kJE8Izg1; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none) On Wed, Feb 28, 2024 at 09:51:41AM -0600, Tom Lendacky wrote: > On 2/28/24 02:40, Gerd Hoffmann wrote: > > > +/** > > > + Perform a native PVALIDATE operation for the page ranges specified. > > > + > > > + Validate or rescind the validation of the specified pages. > > > + > > > + @param[in] Info Pointer to a page state change structure > > > + > > > +**/ > > > +STATIC > > > +VOID > > > +BasePvalidate ( > > > + IN SNP_PAGE_STATE_CHANGE_INFO *Info > > > + ) > > > > This is not mentioned in the commit message. > > > > Looks like you are moving or copying code from BaseMemEncryptSevLib. > > > > Moving code is best done with a patch doing the move only, without other > > functional changes. If that can't be done easily this should explained > > in the commit message. > > I can leave this as unsupported in this patch and then when switching over > to using the functions in patch #16, move the code at that time. > > For the VMSA update, that isn't as easy because of the interaction between > UefiCpuPkg (MpInitLib) and OvmfPkg and requires two separate patches, which > would cause bisection breakage. Oh, right, cross-package code move isn't going to work. > Or I could keep this all here and expand the commit message to indicate that > the base support is being implemented based off of the existing support. I think adding clear annotations to the commit messages is fine then. take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116229): https://edk2.groups.io/g/devel/message/116229 Mute This Topic: https://groups.io/mt/104512963/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-